Skip to contentSkip to conversation

fix missing include directives

PATCH In review John Spencer 3 participants 5 messages Feb 2, 2013 – Feb 21, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix missing include directives

on glibc, those are erroneously (namespace pollution) pulled in via other headers. this doesn't work with conformant libcs (musl libc in this case), we simply need to include all needed headers.

libdm/mm/pool-fast.c +1 -0
@@ -18,6 +18,7 @@
 #endif
 
 #include "dmlib.h"
+#include <stddef.h>
 #include <malloc.h>
 
 struct chunk {
daemons/dmeventd/dmeventd.c +1 -0
@@ -37,6 +37,7 @@
 #include <unistd.h>
 #include <signal.h>
 #include <arpa/inet.h>		/* for htonl, ntohl */
+#include <fcntl.h>
 
 #ifdef linux
 /*
scripts/lvm2_activation_generator_systemd_red_hat.c +1 -0
@@ -19,6 +19,7 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
+#include <limits.h>		/* for PATH_MAX */
 #include "lvm2app.h"
 
 #define KMSG_DEV_PATH        "/dev/kmsg"
#1 lore raw
Quoted 7 lines · John Spencer

on glibc, those are erroneously (namespace pollution) pulled in via other headers. this doesn't work with conformant libcs (musl libc in this case), we simply need to include all needed headers.

ping

#2 lore raw
Quoted 10 lines · John Spencer
Quoted 7 lines · John Spencer

on glibc, those are erroneously (namespace pollution) pulled in via other headers. this doesn't work with conformant libcs (musl libc in this case), we simply need to include all needed headers.

ping

#3 lore raw

Dne 21.2.2013 14:42, John Spencer napsal(a):

Quoted 6 lines · John Spencer
Quoted 5 lines · John Spencer
Quoted 4 lines

on glibc, those are erroneously (namespace pollution) pulled in via other headers. this doesn't work with conformant libcs (musl libc in this case), we simply need to include all needed headers.

Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

ping

accepted

https://www.redhat.com/archives/lvm-devel/2013-February/msg00033.html

Zdenek

#4 lore raw
In reply to John Spencer

Dne 21.2.2013 14:42, John Spencer napsal(a):

Quoted 6 lines · John Spencer
Quoted 5 lines · John Spencer
Quoted 4 lines

on glibc, those are erroneously (namespace pollution) pulled in via other headers. this doesn't work with conformant libcs (musl libc in this case), we simply need to include all needed headers.

Quoted 6 lines
Quoted 5 lines
Quoted 3 lines

ping

Accepted

https://www.redhat.com/archives/lvm-devel/2013-February/msg00033.html

Zdenek