Skip to contentSkip to conversation

drivers/regulator/twl-*: bettet set NUL after free

PATCH New Chen Gang 1 participant 1 message Feb 4, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Chen Gang

author
#1 lore raw

PATCH 1/1 drivers/regulator/twl-*: bettet set NUL after free

In reply to a message not in the archive

oh, sorry, not sent to mailing-list, originally.
(this patch should send to public kernel mailing list)

-------- 原始消息 --------
主题: [PATCH] drivers/regulator/twl-*: bettet set NUL after free
日期: Mon, 04 Feb 2013 10:52:30 +0800
发件人: Chen Gang <[email protected]>
收件人: [email protected], [email protected], Peter Ujfalusi <[email protected]>, Tony Lindgren <[email protected]>

in .remove function, better to set NUL after free, just like others.
in drivers/power/twl4030_charger.c, has already set NULL after free. in drivers/input/keyboard/twl4030_keypad.c, has already set NUL after free.

additional info:
maybe this is not a bug, only for beautify code (can treat it as minor patch)

---
 drivers/regulator/twl-regulator.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/regulator/twl-regulator.c +1 -0
index 74508cc..a9ab46a 100644
@@ -1247,6 +1247,7 @@ static int twlreg_remove(struct platform_device *pdev)
 	struct twlreg_info *info = rdev->reg_data;
 
 	regulator_unregister(rdev);
+	platform_set_drvdata(pdev, NULL);
 	kfree(info);
 	return 0;
 }
Signature · 1 line
1.7.7.6