Issue with Micrel PCI Network Driver.

I am having an issue with one of the network interface drivers. The driver in question is 'drivers/net/ethernet/micrel/ksz884x.c', the driver for the Micrel-Kendin device 8841.
I am trying to get systemd to rename the three network interfaces in my embedded atom system. I have one of the interfaces being renamed (an Intel Corporation 82574L), but the two Micrel interfaces are not being renamed. I traced this down to the driver not populating the /sys/devices/pci* information. Instead it places the driver into /sys/devices/virtual/net/.

Here are the details of the setup I am having the problem on:

    # uname -a ; lspci ; lspci -t ; ls -l /sys/class/net/
    Linux orionlx 3.2.28-rt42-0.1-default+ #1 SMP PREEMPT RT Fri Feb 8 
12:01:13 CST 2013 i686 GNU/Linux
    00:00.0 Host bridge: Intel Corporation System Controller Hub (SCH 
Poulsbo) (rev 07)
    00:02.0 VGA compatible controller: Intel Corporation System 
Controller Hub (SCH Poulsbo) Graphics Controller (rev 07)
    00:1a.0 USB Controller: Intel Corporation System Controller Hub 
(SCH Poulsbo) USB Client Controller (rev 07)
    00:1b.0 Audio device: Intel Corporation System Controller Hub (SCH 
Poulsbo) HD Audio Controller (rev 07)
    00:1c.0 PCI bridge: Intel Corporation System Controller Hub (SCH 
Poulsbo) PCI Express Port 1 (rev 07)
    00:1c.1 PCI bridge: Intel Corporation System Controller Hub (SCH 
Poulsbo) PCI Express Port 2 (rev 07)
    00:1d.0 USB Controller: Intel Corporation System Controller Hub 
(SCH Poulsbo) USB UHCI #1 (rev 07)
    00:1d.1 USB Controller: Intel Corporation System Controller Hub 
(SCH Poulsbo) USB UHCI #2 (rev 07)
    00:1d.2 USB Controller: Intel Corporation System Controller Hub 
(SCH Poulsbo) USB UHCI #3 (rev 07)
    00:1d.7 USB Controller: Intel Corporation System Controller Hub 
(SCH Poulsbo) USB EHCI #1 (rev 07)
    00:1f.0 ISA bridge: Intel Corporation System Controller Hub (SCH 
Poulsbo) LPC Bridge (rev 07)
    00:1f.1 IDE interface: Intel Corporation System Controller Hub (SCH 
Poulsbo) IDE Controller (rev 07)
    01:00.0 PCI bridge: Pericom Semiconductor Device e111 (rev 02)
    02:01.0 PCI bridge: Pericom Semiconductor 
PI7C8152A/PI7C8152B/PI7C8152BI PCI-to-PCI Bridge (rev 01)
    03:00.0 Ethernet controller: Micrel-Kendin Device 8841 (rev 10)
    03:01.0 Ethernet controller: Micrel-Kendin Device 8841 (rev 10)
    04:00.0 Ethernet controller: Intel Corporation 82574L Gigabit 
Network Connection
    -[0000:00]-+-00.0
               +-02.0
               +-1a.0
               +-1b.0
+-1c.0-[0000:01-03]----00.0-[0000:02-03]----01.0-[0000:03]--+-00.0
|                                                           \-01.0
               +-1c.1-[0000:04]----00.0
               +-1d.0
               +-1d.1
               +-1d.2
               +-1d.7
               +-1f.0
               \-1f.1
    lrwxrwxrwx    1 root     root             0 Mar 27 02:04 enp4s0 -> 
../../devices/pci0000:00/0000:00:1c.1/0000:04:00.0/net/enp4s0
    lrwxrwxrwx    1 root     root             0 Mar 27 02:04 eth1 -> 
../../devices/virtual/net/eth1
    lrwxrwxrwx    1 root     root             0 Mar 27 02:04 eth2 -> 
../../devices/virtual/net/eth2
    lrwxrwxrwx    1 root     root             0 Mar 27 02:04 lo -> 
../../devices/virtual/net/lo

This kernel is version 3.2.28 with the real-time patches applied.

If there isn't anyone available to resolve this issue I would be willing to assist. I just do not have any experience writing Network Drivers or PCI drivers. I have only written simple device drivers.

..............................................
Joseph Lutz
Software Developer
NovaTech, LLC
13555 W. 107th Street
Lenexa, KS 66215
(913) 451-1880 (main)
(913) 742-4531 (direct)
[email protected]

[...]

Right, this driver doesn't specify the parent device (PCI device) for the net devices it creates.

All you should need to is add:

	SET_NETDEV_DEV(dev, pdev);

underneath the call to alloc_etherdev().

Ben.

Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Or rather:

	SET_NETDEV_DEV(dev, &pdev->dev);

Ben.

Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

That should of course be fixed. But this bug should not prevent userspace from renaming the device, should it? Sounds like a userspace application making too many stupid assumptions to me. Does it work for network devices attached to other buses?

Bjørn

It prevents userspace from applying a naming policy that incorporates the PCI slot number.

Ben.

Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

Ah, right. Thanks for explaining. That makes more sense.

Bjørn