Skip to contentSkip to conversation

usb: ehci: more bus glues as separate modules

PATCH Superseded manjunath.goudar at linaro.org 3 participants 3 messages Feb 10, 2013 – Feb 11, 2013

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover usb: ehci: more bus glues as separate modules

From: Manjunath Goudar <[email protected]>

Separate the SOC On-Chip host controller driver from ehci-hcd host code into its own driver module

Manjunath Goudar (8):
USB: EHCI: make ehci-spear a separate driver
USB: EHCI: make ehci-atmel a separate driver
USB: EHCI: make ehci-s5p a separate driver
USB: EHCI: make ehci-mv a separate driver
USB: EHCI: make ehci-vt8500 a separate driver
USB: EHCI: make ehci-msm a separate driver
USB: EHCI: make ehci-w90X900 a separate driver
USB: EHCI: make ehci-orion a separate driver

 drivers/usb/host/Kconfig        |   42 +++++++++++--
 drivers/usb/host/Makefile       |    9 ++-
 drivers/usb/host/ehci-atmel.c   |   77 ++++++++++++-----------
 drivers/usb/host/ehci-hcd.c     |   52 +++-------------
 drivers/usb/host/ehci-msm.c     |   85 +++++++++++--------------
 drivers/usb/host/ehci-mv.c      |   80 +++++++++++-------------
 drivers/usb/host/ehci-orion.c   |   91 +++++++++++++--------------
 drivers/usb/host/ehci-s5p.c     |   69 ++++++++++++---------
 drivers/usb/host/ehci-spear.c   |  131 ++++++++++++++++++++-------------------
 drivers/usb/host/ehci-vt8500.c  |   73 ++++++++++------------
 drivers/usb/host/ehci-w90x900.c |   90 ++++++++++++---------------
 drivers/usb/host/ehci.h         |    2 +-
 12 files changed, 392 insertions(+), 409 deletions(-)
Signature · 1 line
1.7.9.5
#1 lore raw

cover usb: ehci: more bus glues as separate modules

Manjunath,

I think this is the second version of this series. Please indicate so in the subject "[PATCH V2 X/Y]" and provide a changelog with each patch so that we can easily confirm suggested changes from one version to the next.

thx,

Jason.

Quoted 37 lines · manjunath.goudar at linaro.org

From: Manjunath Goudar <[email protected]>

Separate the SOC On-Chip host controller driver from ehci-hcd host code into its own driver module

Manjunath Goudar (8):
USB: EHCI: make ehci-spear a separate driver
USB: EHCI: make ehci-atmel a separate driver
USB: EHCI: make ehci-s5p a separate driver
USB: EHCI: make ehci-mv a separate driver
USB: EHCI: make ehci-vt8500 a separate driver
USB: EHCI: make ehci-msm a separate driver
USB: EHCI: make ehci-w90X900 a separate driver
USB: EHCI: make ehci-orion a separate driver

 drivers/usb/host/Kconfig        |   42 +++++++++++--
 drivers/usb/host/Makefile       |    9 ++-
 drivers/usb/host/ehci-atmel.c   |   77 ++++++++++++-----------
 drivers/usb/host/ehci-hcd.c     |   52 +++-------------
 drivers/usb/host/ehci-msm.c     |   85 +++++++++++--------------
 drivers/usb/host/ehci-mv.c      |   80 +++++++++++-------------
 drivers/usb/host/ehci-orion.c   |   91 +++++++++++++--------------
 drivers/usb/host/ehci-s5p.c     |   69 ++++++++++++---------
 drivers/usb/host/ehci-spear.c   |  131 ++++++++++++++++++++-------------------
 drivers/usb/host/ehci-vt8500.c  |   73 ++++++++++------------
 drivers/usb/host/ehci-w90x900.c |   90 ++++++++++++---------------
 drivers/usb/host/ehci.h         |    2 +-
 12 files changed, 392 insertions(+), 409 deletions(-)
Signature · 7 lines
1.7.9.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

cover usb: ehci: more bus glues as separate modules

In reply to manjunath.goudar at linaro.org
Quoted 15 lines · manjunath.goudar at linaro.org

From: Manjunath Goudar<[email protected]>

Separate the SOC On-Chip host controller driver from ehci-hcd host code into its own driver module

Manjunath Goudar (8):
USB: EHCI: make ehci-spear a separate driver
USB: EHCI: make ehci-atmel a separate driver
USB: EHCI: make ehci-s5p a separate driver
USB: EHCI: make ehci-mv a separate driver
USB: EHCI: make ehci-vt8500 a separate driver
USB: EHCI: make ehci-msm a separate driver
USB: EHCI: make ehci-w90X900 a separate driver
USB: EHCI: make ehci-orion a separate driver

Quoted 13 lines
  drivers/usb/host/Kconfig        |   42 +++++++++++--
  drivers/usb/host/Makefile       |    9 ++-
  drivers/usb/host/ehci-atmel.c   |   77 ++++++++++++-----------
  drivers/usb/host/ehci-hcd.c     |   52 +++-------------
  drivers/usb/host/ehci-msm.c     |   85 +++++++++++--------------
  drivers/usb/host/ehci-mv.c      |   80 +++++++++++-------------
  drivers/usb/host/ehci-orion.c   |   91 +++++++++++++--------------
  drivers/usb/host/ehci-s5p.c     |   69 ++++++++++++---------
  drivers/usb/host/ehci-spear.c   |  131 ++++++++++++++++++++-------------------
  drivers/usb/host/ehci-vt8500.c  |   73 ++++++++++------------
  drivers/usb/host/ehci-w90x900.c |   90 ++++++++++++---------------
  drivers/usb/host/ehci.h         |    2 +-
  12 files changed, 392 insertions(+), 409 deletions(-)

Having looked at this, we will end up with a number of modules, each having very similar code in them.#

How about we add drivers/usb/host/ehci-platform.c for all the platform based drivers.

I think it is possible to remove all the specific names, as we certainly don't need the driver advertising itself for each system. Also, does anyone rely on the name field in the HC info, or can it just be "Platform EHCI" ?

Signature · 2 lines
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius