Skip to contentSkip to conversation

kernel: arg2 is unsigned long which is never < 0

PATCH In review Chen Gang 3 participants 3 messages Feb 16, 2013

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH v2 1/1 kernel: arg2 is unsigned long which is never < 0

arg2 will never < 0, for its type is 'unsigned long'

so need beautify the relative source code (better to use macros).

---
 kernel/sys.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
kernel/sys.c +3 -1
index 24d1ef5..eebaf8d 100644
@@ -47,6 +47,7 @@
 #include <linux/syscalls.h>
 #include <linux/kprobes.h>
 #include <linux/user_namespace.h>
+#include <linux/binfmts.h>
 
 #include <linux/kmsg_dump.h>
 /* Move somewhere else to avoid recompiling? */
@@ -2027,7 +2028,8 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3,
 			error = get_dumpable(me->mm);
 			break;
 		case PR_SET_DUMPABLE:
-			if (arg2 < 0 || arg2 > 1) {
+			if (arg2 != SUID_DUMP_DISABLE &&
+			    arg2 != SUID_DUMP_USER) {
 				error = -EINVAL;
 				break;
 			}
Signature · 1 line
1.7.7.6