ipv6: Queue fragments per interface for multicast/link-local addresses.
Subsystems (3)
RFC PATCH 1/1 ipv6: Queue fragments per interface for multicast/link-local addresses.
We should queue fragments for the same link-local address on different interfaces (e.g. fe80::1%eth0 and fe80::1%eth1) to the different queue, because of nature of addressing architecture.
Similarly, we should queue fragments for multicast on different interface to the different queue. This is okay because application joins group on speicific interface, and multicast traffic is expected only on that interface.
--- include/net/ipv6.h | 1 + net/ipv6/reassembly.c | 11 +++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-)
include/net/ipv6.h +1 -0
@@ -463,6 +463,7 @@ enum ip6_defrag_users {struct ip6_create_arg {__be32 id;u32 user; +int ifindex;const struct in6_addr *src;const struct in6_addr *dst; };
net/ipv6/reassembly.c +9 -2
@@ -113,6 +113,7 @@ bool ip6_frag_match(struct inet_frag_queue *q, void *a) fq = container_of(q, struct frag_queue, q);return fq->id == arg->id && + (!arg->ifindex || fq->iif == arg->ifindex) && fq->user == arg->user &&ipv6_addr_equal (&fq->saddr, arg->src) &&ipv6_addr_equal (&fq->daddr, arg->dst);
@@ -182,13 +183,18 @@ static void ip6_frag_expire(unsigned long data) }static __inline__struct frag_queue * -fq_find (struct net *net,__be32 id,const struct in6_addr *src,const struct in6_addr *dst) +fq_find (struct net *net,__be32 id,int ifindex,const struct in6_addr *src,const struct in6_addr *dst) {struct inet_frag_queue *q;struct ip6_create_arg arg;unsigned int hash; +int addr_type =ipv6_addr_type (dst); arg.id = id; +if (addr_type & (IPV6_ADDR_MULTICAST |IPV6_ADDR_LINKLOCAL )) + arg.ifindex = ifindex; +else + arg.ifindex =0 ; arg.user =IP6_DEFRAG_LOCAL_DELIVER ; arg.src = src; arg.dst = dst;
@@ -534,7 +540,8 @@ static int ipv6_frag_rcv(struct sk_buff *skb)IP6_ADD_STATS_BH (net,ip6_dst_idev (skb_dst (skb)),IPSTATS_MIB_REASMFAILS , evicted); - fq =fq_find (net, fhdr->identification, &hdr->saddr, &hdr->daddr); + fq =fq_find (net, fhdr->identification, skb->dev->ifindex, + &hdr->saddr, &hdr->daddr);if (fq !=NULL ) {int ret;
Signature · 1 line
1.7.9.5
Quoted 63 lines · YOSHIFUJI Hideaki
We should queue fragments for the same link-local address on different interfaces (e.g. fe80::1%eth0 and fe80::1%eth1) to the different queue, because of nature of addressing architecture.
Similarly, we should queue fragments for multicast on different interface to the different queue. This is okay because application joins group on speicific interface, and multicast traffic is expected only on that interface.
CC Ben Greear <[email protected]>CC Vlad Yasevich <[email protected]>CC Eric Dumazet <[email protected]>Signed-off-by YOSHIFUJI Hideaki <[email protected]>--- include/net/ipv6.h | 1 + net/ipv6/reassembly.c | 11 +++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-)include/net/ipv6.h +1
-0@@ -463,6 +463,7 @@ enum ip6_defrag_users {struct ip6_create_arg {__be32 id;u32 user; +int ifindex;const struct in6_addr *src;const struct in6_addr *dst; };net/ipv6/reassembly.c +7
-1@@ -113,6 +113,7 @@ bool ip6_frag_match(struct inet_frag_queue *q, void *a) fq = container_of(q, struct frag_queue, q);return fq->id == arg->id && + (!arg->ifindex || fq->iif == arg->ifindex) && fq->user == arg->user &&ipv6_addr_equal (&fq->saddr, arg->src) &&ipv6_addr_equal (&fq->daddr, arg->dst);@@ -182,13 +183,18 @@ static void ip6_frag_expire(unsigned long data) }static __inline__struct frag_queue * -fq_find (struct net *net,__be32 id,const struct in6_addr *src,const struct in6_addr *dst) +fq_find (struct net *net,__be32 id,int ifindex,const struct in6_addr *src,const struct in6_addr *dst) {struct inet_frag_queue *q;struct ip6_create_arg arg;unsigned int hash; +int addr_type =ipv6_addr_type (dst); arg.id = id; +if (addr_type & (IPV6_ADDR_MULTICAST |IPV6_ADDR_LINKLOCAL )) + arg.ifindex = ifindex; +else + arg.ifindex =0 ; arg.user =IP6_DEFRAG_LOCAL_DELIVER ; arg.src = src; arg.dst = dst;
net/ipv6/reassembly.c static int ipv6_frag_rcv(struct sk_buff *skb) · line 547
Quoted 9 lines
net/ipv6/reassembly.c +2
-1@@ -534,7 +540,8 @@ static int ipv6_frag_rcv(struct sk_buff *skb)IP6_ADD_STATS_BH (net,ip6_dst_idev (skb_dst (skb)),IPSTATS_MIB_REASMFAILS , evicted); - fq =fq_find (net, fhdr->identification, &hdr->saddr, &hdr->daddr); + fq =fq_find (net, fhdr->identification, skb->dev->ifindex, + &hdr->saddr, &hdr->daddr);if (fq !=NULL ) {int ret;
Hmm... This breaks net/ipv6/netfilter/nf_conntrack_reasm.c