ARM:kernel: a bug by a redundancy charactor ';'

PATCH New Chen Gang 3 participants 8 messages Feb 16, 2013 – Feb 17, 2013

Subsystems (3)

Arm (32-bit) perf events Arm PMU profiling and debugging

lore

Share & tools

lore

Chen Gang

author

2013-02-16 06:49 UTC #0 lore raw

PATCH 1/1 ARM:kernel: a bug by a redundancy charactor ';'

delete the redundancy charactor ';', which will cause issue.

Signed-off-by Chen Gang <[email protected]>

---
 arch/arm/kernel/perf_event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/kernel/perf_event.c +1 -1

index 31e0eb3..a892067 100644
@@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
 	}
 
 	if (event->group_leader != event) {
-		if (validate_group(event) != 0);
+		if (validate_group(event) != 0)
 			return -EINVAL;
 	}

Signature · 1 line

1.7.7.6

Dirk Behme

2013-02-16 08:04 UTC #1 lore raw

PATCH 1/1 ARM:kernel: a bug by a redundancy charactor ';'

Am 16.02.2013 07:49, schrieb Chen Gang:

Quoted 13 lines

delete the redundancy charactor ';', which will cause issue.
Signed-off-by Chen Gang <[email protected]>
---
  arch/arm/kernel/perf_event.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/kernel/perf_event.c +0 -0
index 31e0eb3..a892067 100644

arch/arm/kernel/perf_event.c __hw_perf_event_init(struct perf_event *event) · line 405

Quoted 7 lines

arch/arm/kernel/perf_event.c +1 -1

@@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
  	}
 
  	if (event->group_leader != event) {
-		if (validate_group(event) != 0);
+		if (validate_group(event) != 0)
  			return -EINVAL;
  	}

Wondering against which branch this patch is, I found that this issue isn't in recent mainline from today, but in -next. Introduced by the patch

ARM: perf: simplify __hw_perf_event_init err handling
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=9dcbf466559f6f2f55d60eb5a1bbebc8e694b52a

While the subject/commit message could be improved (at least mentioning 'perf' somehow and charactor -> character), the change itself looks good.

Best regards

Dirk

Chen Gang

author

2013-02-16 08:38 UTC #2 lore raw

PATCH 1/1 ARM:kernel: a bug by a redundancy charactor ';'

? 2013?02?16? 16:04, Dirk Behme ??:

Quoted 7 lines

Wondering against which branch this patch is, I found that this issue isn't in recent mainline from today, but in -next. Introduced by the patch
ARM: perf: simplify __hw_perf_event_init err handling
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=9dcbf466559f6f2f55d60eb5a1bbebc8e694b52a

for me, either regressing the original patch or committing current
patch are all OK.

Quoted 3 lines

While the subject/commit message could be improved (at least mentioning 'perf' somehow and charactor -> character), the change itself looks good.

if still suggest to commit current patch:
does the subject like this ?
[PATCH] ARM:kernel: a bug for perf by a redundancy character ';'

:-)

thanks.

Signature · 3 lines

Chen Gang

Asianux Corporation

Will Deacon

2013-02-16 12:26 UTC #3 lore raw

PATCH 1/1 ARM:kernel: a bug by a redundancy charactor ';'

Quoted 8 lines · Chen Gang

? 2013?02?16? 16:04, Dirk Behme ??:
Quoted 7 lines
Wondering against which branch this patch is, I found that this issue isn't in recent mainline from today, but in -next. Introduced by the patch
ARM: perf: simplify __hw_perf_event_init err handling
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=9dcbf466559f6f2f55d60eb5a1bbebc8e694b52a

Damn, I really should have spotted this. Thanks for reporting/fixing it.

Quoted 6 lines

Quoted 2 lines
While the subject/commit message could be improved (at least mentioning 'perf' somehow and charactor -> character), the change itself looks good.
if still suggest to commit current patch:
does the subject like this ?
[PATCH] ARM:kernel: a bug for perf by a redundancy character ';'

If you're ok with the following patch, I'll take it into the ARM perf tree.

Cheers,

Will

--->8

Quoted 1 line

From 21fa771c94c4359807bb92dc8532b25c323ac543 Mon Sep 17 00:00:00 2001

From: Chen Gang <[email protected]>
Date: Sat, 16 Feb 2013 06:49:49 +0000
Subject: [PATCH] ARM: perf: remove erroneous semicolon from event
initialisation

Commit 9dcbf466559f ("ARM: perf: simplify __hw_perf_event_init err handling") tidied up the error handling code for perf event initialisation on ARM, but a copy-and-paste error left a dangling semicolon at the end of an if statement.

This patch removes the broken semicolon, restoring the old group validation semantics.

Cc Mark Rutland <[email protected]>

Signed-off-by Chen Gang <[email protected]>

Signed-off-by Will Deacon <[email protected]>

---
 arch/arm/kernel/perf_event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/kernel/perf_event.c +1 -1

index 31e0eb3..a892067 100644
@@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
 	}
 
 	if (event->group_leader != event) {
-		if (validate_group(event) != 0);
+		if (validate_group(event) != 0)
 			return -EINVAL;
 	}

Signature · 1 line

1.8.0

Dirk Behme

2013-02-16 13:44 UTC #4 lore raw

PATCH 1/1 ARM:kernel: a bug by a redundancy charactor ';'

Am 16.02.2013 13:26, schrieb Will Deacon:

Quoted 39 lines · Chen Gang

Quoted 8 lines
? 2013?02?16? 16:04, Dirk Behme ??:
Quoted 7 lines
Wondering against which branch this patch is, I found that this issue isn't in recent mainline from today, but in -next. Introduced by the patch
ARM: perf: simplify __hw_perf_event_init err handling
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=9dcbf466559f6f2f55d60eb5a1bbebc8e694b52a
Damn, I really should have spotted this. Thanks for reporting/fixing it.
Quoted 6 lines
Quoted 2 lines
While the subject/commit message could be improved (at least mentioning 'perf' somehow and charactor -> character), the change itself looks good.
if still suggest to commit current patch:
does the subject like this ?
[PATCH] ARM:kernel: a bug for perf by a redundancy character ';'
If you're ok with the following patch, I'll take it into the ARM perf tree.
Cheers,
Will
--->8
Quoted 1 line
From 21fa771c94c4359807bb92dc8532b25c323ac543 Mon Sep 17 00:00:00 2001
From: Chen Gang <[email protected]>
Date: Sat, 16 Feb 2013 06:49:49 +0000
Subject: [PATCH] ARM: perf: remove erroneous semicolon from event
initialisation
Commit 9dcbf466559f ("ARM: perf: simplify __hw_perf_event_init err handling") tidied up the error handling code for perf event initialisation on ARM, but a copy-and-paste error left a dangling semicolon at the end of an if statement.

Quoted 6 lines

This patch removes the broken semicolon, restoring the old group validation semantics.
Cc Mark Rutland <[email protected]>
Signed-off-by Chen Gang <[email protected]>
Signed-off-by Will Deacon <[email protected]>

Acked-by Dirk Behme <[email protected]>

Dirk

Quoted 18 lines

---
  arch/arm/kernel/perf_event.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/kernel/perf_event.c +1 -1

index 31e0eb3..a892067 100644
@@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
  	}
 
  	if (event->group_leader != event) {
-		if (validate_group(event) != 0);
+		if (validate_group(event) != 0)
  			return -EINVAL;
  	}

Chen Gang

author

2013-02-17 02:07 UTC #5 lore raw

PATCH 1/1 ARM:kernel: a bug by a redundancy charactor ';'

In reply to Will Deacon

? 2013?02?16? 20:26, Will Deacon ??:

Quoted 8 lines

Quoted 6 lines
Quoted 6 lines
While the subject/commit message could be improved (at least mentioning
Quoted 1 line
Quoted 1 line
'perf' somehow and charactor -> character), the change itself looks good.
if still suggest to commit current patch:
does the subject like this ?
[PATCH] ARM:kernel: a bug for perf by a redundancy character ';'
If you're ok with the following patch, I'll take it into the ARM perf tree.

ok, I will send patch v2.
but use [PATCH] instead of [PATCH v2], since need change the subject.

thanks.

Signature · 3 lines

Chen Gang

Asianux Corporation

Chen Gang

author

2013-02-17 02:09 UTC #6 lore raw

PATCH 1/1 ARM:kernel: a bug for perf by a redundancy character ';'

In reply to Will Deacon

delete the redundancy charactor ';', which will cause issue.

Signed-off-by Chen Gang <[email protected]>

Acked-by Dirk Behme <[email protected]>

---
 arch/arm/kernel/perf_event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/kernel/perf_event.c +1 -1

index 31e0eb3..a892067 100644
@@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
 	}
 
 	if (event->group_leader != event) {
-		if (validate_group(event) != 0);
+		if (validate_group(event) != 0)
 			return -EINVAL;
 	}

Signature · 1 line

1.7.7.6

Chen Gang

author

2013-02-17 04:22 UTC #7 lore raw

PATCH 1/1 ARM:kernel: a bug for perf by a redundancy character ';'

oh, sorry, the comments still use charactor.

I will send pach v2.

gchen.

? 2013?02?17? 10:09, Chen Gang ??:

Quoted 23 lines

delete the redundancy charactor ';', which will cause issue.
Signed-off-by Chen Gang <[email protected]>
Acked-by Dirk Behme <[email protected]>
---
 arch/arm/kernel/perf_event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/kernel/perf_event.c +1 -1
index 31e0eb3..a892067 100644
@@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
 	}
 
 	if (event->group_leader != event) {
-		if (validate_group(event) != 0);
+		if (validate_group(event) != 0)
 			return -EINVAL;
 	}
 

Signature · 3 lines

Chen Gang

Asianux Corporation