WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242
Subsystems (4)
Hi,
we have a report of WARNING from 3.7.6 in nouveau at drivers/gpu/drm/nouveau/core/core/mm.c:242 here:
https://bugzilla.novell.com/show_bug.cgi?id=802347#c11
There is an order 4 allocation failure in nouveau_drm_open -> nouveau_vm_create, i.e. this one failed:vm->pgt = kcalloc(vm->lpde - vm->fpde + 1, sizeof(*vm->pgt), GFP_KERNEL);
Then, on the error path in still in nouveau_drm_open, it is followed by a call to nouveau_cli_destroy. But that one calls nouveau_vm_ref -> nouveau_mm_fini -> nouveau_vm_del -> nouveau_mm_fini which triggers the warning.
Any ideas?
thanks,
Signature · 2 lines
js suse labs
Quoted 10 lines · Jiri Slaby
Hi,
we have a report of WARNING from 3.7.6 in nouveau at
drivers/gpu/drm/nouveau/core/core/mm.c:242here:
https://bugzilla.novell.com/show_bug.cgi?id=802347#c11There is an order 4 allocation failure in
nouveau_drm_open->nouveau_vm_create, i.e. this one failed:vm->pgt=kcalloc(vm->lpde - vm->fpde + 1, sizeof(*vm->pgt), GFP_KERNEL);
Quoted 6 lines
Then, on the error path in still in
nouveau_drm_open, it is followed by a call tonouveau_cli_destroy. But that one callsnouveau_vm_ref->nouveau_mm_fini->nouveau_vm_del->nouveau_mm_finiwhich triggers the warning.Any ideas?
Crash/warning should be fixed by commit cfd376b6bfccf33782a0748a9c70f7f752f8b869 "drm/nouveau/vm: fix memory corruption when pgt allocation fails".
Tomorrow I'll post a patch for page allocation failure.
Marcin
Quoted 16 lines · Marcin Slusarz
Quoted 15 lines · Jiri Slaby
Hi,
we have a report of WARNING from 3.7.6 in nouveau at
drivers/gpu/drm/nouveau/core/core/mm.c:242here:
https://bugzilla.novell.com/show_bug.cgi?id=802347#c11There is an order 4 allocation failure in
nouveau_drm_open->nouveau_vm_create, i.e. this one failed:vm->pgt=kcalloc(vm->lpde - vm->fpde + 1, sizeof(*vm->pgt), GFP_KERNEL);Then, on the error path in still in
nouveau_drm_open, it is followed by a call tonouveau_cli_destroy. But that one callsnouveau_vm_ref->nouveau_mm_fini->nouveau_vm_del->nouveau_mm_finiwhich triggers the warning.
Quoted 4 lines
Quoted 1 line
Any ideas?
Crash/warning should be fixed by commit
cfd376b6bfccf33782a0748a9c70f7f752f8b869"drm/nouveau/vm: fix memory corruption when pgt allocation fails".
Oh, thanks for the pointer. Could that bug cause real "memory corruption"? As we're hunting one there...
Isn't this a stable-3.7 candidate?
Quoted 1 line
Tomorrow I'll post a patch for page allocation failure.
What do you mean -- what kind of patch?
Signature · 2 lines
js suse labs
Page allocation failures (was Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242)
Quoted 11 lines · Jiri Slaby
Quoted 10 lines · Marcin Slusarz
Quoted 9 lines · Jiri Slaby
Hi,
we have a report of WARNING from 3.7.6 in nouveau at
drivers/gpu/drm/nouveau/core/core/mm.c:242here:
https://bugzilla.novell.com/show_bug.cgi?id=802347#c11There is an order 4 allocation failure in
nouveau_drm_open->nouveau_vm_create, i.e. this one failed:vm->pgt=kcalloc(vm->lpde - vm->fpde + 1, sizeof(*vm->pgt), GFP_KERNEL);
Hi Jiri,
I had the order 4 allocation failure and nouveau crash back in November on next-20121129. Bugzillas here:
Allocation failure:
https://bugzilla.kernel.org/show_bug.cgi?id=51301
Nouveau bug:
https://bugzilla.kernel.org/show_bug.cgi?id=51291
https://bugs.freedesktop.org/show_bug.cgi?id=58087
IMO, the 32k allocation failure is the more serious bug. Check out the slab info from your report:
Feb 06 13:16:15 desdemona kernel: Node 0 DMA32: 13378*4kB 5026*8kB 1823*16kB 135*32kB 5*64kB 0*128kB 0*256kB 0*512kB 0*1024kB 1*2048kB 0*4096kB = 129576kB Feb 06 13:16:15 desdemona kernel: Node 0 Normal: 1946*4kB 831*8kB 3*16kB 1*32kB
1*64kB 1*128kB 1*256kB 1*512kB 1*1024kB 0*2048kB 0*4096kB = 16496kB
The pages are there: why did the allocation fail?
I think this is related to all that kswapd mess. In my case, the machine really was OOM -- which made no sense. Completely out of page blocks larger than 32k on a 10gb machine with a bunch of emacs and terminal windows open for 3 days, just doing code, build, code, build, code, build?
Regards,
Peter Hurley
Quoted 17 lines · Jiri Slaby
Quoted 16 lines · Marcin Slusarz
Quoted 15 lines · Jiri Slaby
Hi,
we have a report of WARNING from 3.7.6 in nouveau at
drivers/gpu/drm/nouveau/core/core/mm.c:242here:
https://bugzilla.novell.com/show_bug.cgi?id=802347#c11There is an order 4 allocation failure in
nouveau_drm_open->nouveau_vm_create, i.e. this one failed:vm->pgt=kcalloc(vm->lpde - vm->fpde + 1, sizeof(*vm->pgt), GFP_KERNEL);Then, on the error path in still in
nouveau_drm_open, it is followed by a call tonouveau_cli_destroy. But that one callsnouveau_vm_ref->nouveau_mm_fini->nouveau_vm_del->nouveau_mm_finiwhich triggers the warning.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Any ideas?
Crash/warning should be fixed by commit
cfd376b6bfccf33782a0748a9c70f7f752f8b869"drm/nouveau/vm: fix memory corruption when pgt allocation fails".Oh, thanks for the pointer. Could that bug cause real "memory corruption"? As we're hunting one there...
Yes.
Quoted 1 line
Isn't this a stable-3.7 candidate?
Should have been :/.
Quoted 3 lines
Quoted 1 line
Tomorrow I'll post a patch for page allocation failure.
What do you mean -- what kind of patch?
A patch which will change pgt allocation to use vmalloc.
Marcin
Quoted 30 lines · Marcin Slusarz
Quoted 17 lines · Jiri Slaby
Quoted 16 lines · Marcin Slusarz
Quoted 15 lines · Jiri Slaby
Hi,
we have a report of WARNING from 3.7.6 in nouveau at
drivers/gpu/drm/nouveau/core/core/mm.c:242here:
https://bugzilla.novell.com/show_bug.cgi?id=802347#c11There is an order 4 allocation failure in
nouveau_drm_open->nouveau_vm_create, i.e. this one failed:vm->pgt=kcalloc(vm->lpde - vm->fpde + 1, sizeof(*vm->pgt), GFP_KERNEL);Then, on the error path in still in
nouveau_drm_open, it is followed by a call tonouveau_cli_destroy. But that one callsnouveau_vm_ref->nouveau_mm_fini->nouveau_vm_del->nouveau_mm_finiwhich triggers the warning.Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Any ideas?
Crash/warning should be fixed by commit
cfd376b6bfccf33782a0748a9c70f7f752f8b869"drm/nouveau/vm: fix memory corruption when pgt allocation fails".Oh, thanks for the pointer. Could that bug cause real "memory corruption"? As we're hunting one there...
Yes.
Quoted 1 line
Isn't this a stable-3.7 candidate?
Quoted 7 lines
Should have been :/.
Quoted 3 lines
Quoted 1 line
Tomorrow I'll post a patch for page allocation failure.
What do you mean -- what kind of patch?
A patch which will change pgt allocation to use vmalloc.
---
From: Marcin Slusarz <[email protected]>
Subject: [PATCH] drm/nouveau: use vmalloc for pgt allocation
Page tables on nv50 take 48kB, which can be hard to allocate in one piece. Let's use vmalloc.
--- drivers/gpu/drm/nouveau/core/subdev/vm/base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/nouveau/core/subdev/vm/base.c +3 -3
@@ -362,7 +362,7 @@ nouveau_vm_create(struct nouveau_vmmgr *vmm, u64 offset, u64 length, vm->fpde = offset >> (vmm->pgt_bits +12 ); vm->lpde = (offset + length -1 ) >> (vmm->pgt_bits +12 ); - vm->pgt =kcalloc (vm->lpde - vm->fpde +1 ,sizeof (*vm->pgt),GFP_KERNEL ); + vm->pgt =vzalloc ((vm->lpde - vm->fpde +1 ) *sizeof (*vm->pgt));if (!vm->pgt) {kfree (vm);return -ENOMEM ;
@@ -371,7 +371,7 @@ nouveau_vm_create(struct nouveau_vmmgr *vmm, u64 offset, u64 length, ret =nouveau_mm_init (&vm->mm, mm_offset >>12 , mm_length >>12 , block >>12 );if (ret) { -kfree (vm->pgt); +vfree (vm->pgt);kfree (vm);return ret; }
@@ -446,7 +446,7 @@ nouveau_vm_del(struct nouveau_vm *vm) }nouveau_mm_fini (&vm->mm); -kfree (vm->pgt); +vfree (vm->pgt);kfree (vm); }
[stable request] fix for nouveau mem corruption [was: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242]
In reply to Marcin SlusarzQuoted 11 lines · Marcin Slusarz
Quoted 5 lines
Quoted 2 lines
Crash/warning should be fixed by commit
cfd376b6bfccf33782a0748a9c70f7f752f8b869"drm/nouveau/vm: fix memory corruption when pgt allocation fails".Oh, thanks for the pointer. Could that bug cause real "memory corruption"? As we're hunting one there...
Yes.
Quoted 1 line
Isn't this a stable-3.7 candidate?
Should have been :/.
Ok, if you have no objections: stable fellows, please consider the commit above for stable inclusion. As far as I can tell this is only applicable for 3.7 -- Marcin?
Signature · 2 lines
js suse labs
Re: [stable request] fix for nouveau mem corruption [was: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242]
Quoted 9 lines · Jiri Slaby
Quoted 8 lines · Marcin Slusarz
Quoted 5 lines
Quoted 2 lines
Crash/warning should be fixed by commit
cfd376b6bfccf33782a0748a9c70f7f752f8b869"drm/nouveau/vm: fix memory corruption when pgt allocation fails".Oh, thanks for the pointer. Could that bug cause real "memory corruption"? As we're hunting one there...
Yes.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Isn't this a stable-3.7 candidate?
Should have been :/.
Ok, if you have no objections: stable fellows, please consider the commit above for stable inclusion. As far as I can tell this is only applicable for 3.7 -- Marcin?
Correct. Please apply it for 3.7.x.
Marcin
Greg KH
maintainerRe: [stable request] fix for nouveau mem corruption [was: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242]
Quoted 12 lines · Marcin Slusarz
Quoted 11 lines · Jiri Slaby
Quoted 10 lines · Marcin Slusarz
Quoted 5 lines
Quoted 2 lines
Crash/warning should be fixed by commit
cfd376b6bfccf33782a0748a9c70f7f752f8b869"drm/nouveau/vm: fix memory corruption when pgt allocation fails".Oh, thanks for the pointer. Could that bug cause real "memory corruption"? As we're hunting one there...
Yes.
Quoted 1 line
Isn't this a stable-3.7 candidate?
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Should have been :/.
Ok, if you have no objections: stable fellows, please consider the commit above for stable inclusion. As far as I can tell this is only applicable for 3.7 -- Marcin?
Correct. Please apply it for 3.7.x.
Now applied, thanks.
greg k-h
Quoted 8 lines · Marcin Slusarz
Quoted 7 lines · Marcin Slusarz
Quoted 4 lines · Jiri Slaby
Quoted 1 line · Marcin Slusarz
Tomorrow I'll post a patch for page allocation failure.
What do you mean -- what kind of patch?
A patch which will change pgt allocation to use vmalloc.
It's still not in -next. Any plans on this?
Quoted 45 lines
---
From: Marcin Slusarz <[email protected]>
Subject: [PATCH] drm/nouveau: use vmalloc for pgt allocationPage tables on nv50 take 48kB, which can be hard to allocate in one piece. Let's use vmalloc.
Signed-off-by Marcin Slusarz <[email protected]>--- drivers/gpu/drm/nouveau/core/subdev/vm/base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/nouveau/core/subdev/vm/base.c +3
-3@@ -362,7 +362,7 @@ nouveau_vm_create(struct nouveau_vmmgr *vmm, u64 offset, u64 length, vm->fpde = offset >> (vmm->pgt_bits +12 ); vm->lpde = (offset + length -1 ) >> (vmm->pgt_bits +12 ); - vm->pgt =kcalloc (vm->lpde - vm->fpde +1 ,sizeof (*vm->pgt),GFP_KERNEL ); + vm->pgt =vzalloc ((vm->lpde - vm->fpde +1 ) *sizeof (*vm->pgt));if (!vm->pgt) {kfree (vm);return -ENOMEM ;@@ -371,7 +371,7 @@ nouveau_vm_create(struct nouveau_vmmgr *vmm, u64 offset, u64 length, ret =nouveau_mm_init (&vm->mm, mm_offset >>12 , mm_length >>12 , block >>12 );if (ret) { -kfree (vm->pgt); +vfree (vm->pgt);kfree (vm);return ret; }@@ -446,7 +446,7 @@ nouveau_vm_del(struct nouveau_vm *vm) }nouveau_mm_fini (&vm->mm); -kfree (vm->pgt); +vfree (vm->pgt);kfree (vm); }
Signature · 2 lines
js suse labs
Quoted 11 lines · Jiri Slaby
Quoted 8 lines · Marcin Slusarz
Quoted 7 lines · Marcin Slusarz
Quoted 4 lines · Jiri Slaby
Quoted 1 line · Marcin Slusarz
Tomorrow I'll post a patch for page allocation failure.
What do you mean -- what kind of patch?
A patch which will change pgt allocation to use vmalloc.
It's still not in -next. Any plans on this?
Ping...
Quoted 47 lines
Quoted 45 lines
---
From: Marcin Slusarz <[email protected]>
Subject: [PATCH] drm/nouveau: use vmalloc for pgt allocationPage tables on nv50 take 48kB, which can be hard to allocate in one piece. Let's use vmalloc.
Signed-off-by Marcin Slusarz <[email protected]>--- drivers/gpu/drm/nouveau/core/subdev/vm/base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/nouveau/core/subdev/vm/base.c +3
-3@@ -362,7 +362,7 @@ nouveau_vm_create(struct nouveau_vmmgr *vmm, u64 offset, u64 length, vm->fpde = offset >> (vmm->pgt_bits +12 ); vm->lpde = (offset + length -1 ) >> (vmm->pgt_bits +12 ); - vm->pgt =kcalloc (vm->lpde - vm->fpde +1 ,sizeof (*vm->pgt),GFP_KERNEL ); + vm->pgt =vzalloc ((vm->lpde - vm->fpde +1 ) *sizeof (*vm->pgt));if (!vm->pgt) {kfree (vm);return -ENOMEM ;@@ -371,7 +371,7 @@ nouveau_vm_create(struct nouveau_vmmgr *vmm, u64 offset, u64 length, ret =nouveau_mm_init (&vm->mm, mm_offset >>12 , mm_length >>12 , block >>12 );if (ret) { -kfree (vm->pgt); +vfree (vm->pgt);kfree (vm);return ret; }@@ -446,7 +446,7 @@ nouveau_vm_del(struct nouveau_vm *vm) }nouveau_mm_fini (&vm->mm); -kfree (vm->pgt); +vfree (vm->pgt);kfree (vm); }
Signature · 2 lines
js suse labs