Skip to contentSkip to conversation

i.MX6: Add hdmidet command

U-Boot Eric Nelson 3 participants 8 messages Feb 19, 2013 – Feb 20, 2013

lore
Share & tools
lore
#1 lore raw
Quoted 11 lines · Eric Nelson

Hi Stefano,

This seems to have gotten lost in the shuffle.

It's showing as "Changes requested" in Patchwork:

        http://patchwork.ozlabs.org/patch/186280/

Is there something you'd like changed?

Please advise,

I'd say to use space between the '+' as done in other code.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#2 lore raw

Hi Otavio,

Quoted 8 lines · Otavio Salvador
Quoted 6 lines · Eric Nelson

Hi Stefano,

This seems to have gotten lost in the shuffle.

It's showing as "Changes requested" in Patchwork:

Quoted 8 lines
Quoted 5 lines
         http://patchwork.ozlabs.org/patch/186280/

Is there something you'd like changed?

Please advise,

I'd say to use space between the '+' as done in other code.

I must be dense.

Which '+' needs a space?

Please advise,

Eric

#3 lore raw
Quoted 21 lines · Eric Nelson

Hi Otavio,

Quoted 17 lines · Otavio Salvador
Quoted 12 lines · Eric Nelson

Hi Stefano,

This seems to have gotten lost in the shuffle.

It's showing as "Changes requested" in Patchwork:

         http://patchwork.ozlabs.org/patch/186280/

Is there something you'd like changed?

Please advise,

Quoted 6 lines
Quoted 2 lines

I'd say to use space between the '+' as done in other code.

I must be dense.

Which '+' needs a space?

It seems usually when dealing with offsets we have ' + '. Personally I think it is clear to read too. But it's not my call so it is up to you and Stefano.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#4 lore raw
Quoted 26 lines · Otavio Salvador
Quoted 24 lines · Eric Nelson

Hi Otavio,

Quoted 19 lines · Otavio Salvador
Quoted 5 lines · Eric Nelson

Hi Stefano,

This seems to have gotten lost in the shuffle.

Quoted 7 lines

It's showing as "Changes requested" in Patchwork:

          http://patchwork.ozlabs.org/patch/186280/

Is there something you'd like changed?

Please advise,

I'd say to use space between the '+' as done in other code.

Quoted 8 lines
Quoted 3 lines

I must be dense.

Which '+' needs a space?

It seems usually when dealing with offsets we have ' + '. Personally I think it is clear to read too. But it's not my call so it is up to you and Stefano.

Gotcha.

You mean here:

+{

+	u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0);
                                                ^

That's the trouble with commenting on the patchwork link...

No context.

Regards,

Eric

#5 lore raw
Quoted 49 lines · Eric Nelson
Quoted 31 lines · Otavio Salvador
Quoted 28 lines · Eric Nelson

Hi Otavio,

Quoted 22 lines · Otavio Salvador
Quoted 6 lines · Eric Nelson

Hi Stefano,

This seems to have gotten lost in the shuffle.

Quoted 7 lines

It's showing as "Changes requested" in Patchwork:

          http://patchwork.ozlabs.org/patch/186280/

Is there something you'd like changed?

Please advise,

I'd say to use space between the '+' as done in other code.

Quoted 9 lines
Quoted 3 lines

I must be dense.

Which '+' needs a space?

It seems usually when dealing with offsets we have ' + '. Personally I think it is clear to read too. But it's not my call so it is up to you and Stefano.

Gotcha.

You mean here:

(quoted diff) +2 -0
+{
+       u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0);
                                               ^
Quoted 1 line

That's the trouble with commenting on the patchwork link...

Yes; a space between both macros.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#6 lore raw
Quoted 47 lines · Otavio Salvador
Quoted 45 lines · Eric Nelson
Quoted 31 lines · Otavio Salvador
Quoted 28 lines · Eric Nelson

Hi Otavio,

Quoted 22 lines · Otavio Salvador
Quoted 6 lines · Eric Nelson

Hi Stefano,

This seems to have gotten lost in the shuffle.

Quoted 7 lines

It's showing as "Changes requested" in Patchwork:

           http://patchwork.ozlabs.org/patch/186280/

Is there something you'd like changed?

Please advise,

I'd say to use space between the '+' as done in other code.

Quoted 9 lines
Quoted 3 lines

I must be dense.

Which '+' needs a space?

It seems usually when dealing with offsets we have ' + '. Personally I think it is clear to read too. But it's not my call so it is up to you and Stefano.

Gotcha.

You mean here:

Quoted 8 lines
Quoted 5 lines
(quoted diff) +2 -0
+{
+       u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0);
                                                ^

That's the trouble with commenting on the patchwork link...

Yes; a space between both macros.

And a run through checkpatch...

I am dense today.

#7 lore raw
Quoted 52 lines · Eric Nelson
Quoted 51 lines · Otavio Salvador
Quoted 49 lines · Eric Nelson
Quoted 31 lines · Otavio Salvador
Quoted 28 lines · Eric Nelson

Hi Otavio,

Quoted 22 lines · Otavio Salvador
Quoted 6 lines · Eric Nelson

Hi Stefano,

This seems to have gotten lost in the shuffle.

Quoted 7 lines

It's showing as "Changes requested" in Patchwork:

           http://patchwork.ozlabs.org/patch/186280/

Is there something you'd like changed?

Please advise,

I'd say to use space between the '+' as done in other code.

Quoted 9 lines
Quoted 3 lines

I must be dense.

Which '+' needs a space?

It seems usually when dealing with offsets we have ' + '. Personally I think it is clear to read too. But it's not my call so it is up to you and Stefano.

Gotcha.

You mean here:

(quoted diff) +2 -0
+{
+       u8 reg = __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0);
                                                ^
Quoted 9 lines
Quoted 4 lines
Quoted 1 line

That's the trouble with commenting on the patchwork link...

Yes; a space between both macros.

And a run through checkpatch...

I am dense today.

Right, sorry for late answer - it is only to fix checkpatch warning, nothing more. I wll then apply it

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================