Skip to contentSkip to conversation

why is it not allowed to add a new socket protocol family as an external module?

DISCUSSION Chris Friesen 4 participants 11 messages Feb 20, 2013 – Feb 21, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

I was just wondering why the kernel doesn't allow a new network protocol family to be loaded as as a kernel module built outside the kernel source tree.

Most of the networking code would seem to allow this, but the check for
"if (ops->family >= NPROTO)" in sock_register() means that only protocol families defined in socket.h can be registered.

Was this intentional for ideological reasons, or has nobody wanted to be able to add arbitrary network protocols without patching the kernel and rebuilding?

Thanks,
Chris

#1 lore raw
Quoted 6 lines · On Wed, 20 Feb 2013 10:56:13 -0600 Chris Friesen <[email protected]>…

Hi,

I was just wondering why the kernel doesn't allow a new network protocol family to be loaded as as a kernel module built outside the kernel source tree.

Quoted 8 lines

Most of the networking code would seem to allow this, but the check for "if (ops->family >= NPROTO)" in sock_register() means that only protocol families defined in socket.h can be registered.

Was this intentional for ideological reasons, or has nobody wanted to be able to add arbitrary network protocols without patching the kernel and rebuilding?

If you want an answer, to the question, use a tool like cscope and learn to read the kernel code. There are several tables of pointers sized by NPROTO.

#2 lore raw
Quoted 11 lines · Stephen Hemminger
Quoted 5 lines · On Wed, 20 Feb 2013 10:56:13 -0600 Chris Friesen<[email protected]>…

Hi,

I was just wondering why the kernel doesn't allow a new network protocol family to be loaded as as a kernel module built outside the kernel source tree.

If you want an answer, to the question, use a tool like cscope and learn to read the kernel code. There are several tables of pointers sized by NPROTO.

That's a bit insulting, don't you think?

Yes, there are a number of tables sized by NPROTO/AF_MAX/PF_MAX (and the fact that we use all three within the kernel is kind of sad) but there is no technical reason why we couldn't extend those dynamically if desired (with a linked list of additional protocols, perhaps).

Hence my question--is the restriction for an ideological reason or simply because nobody thought it was worth the effort?

Chris

maintainer
#3 lore raw

From: Chris Friesen <[email protected]>
Date: Wed, 20 Feb 2013 18:44:50 -0600

Quoted 11 lines · Stephen Hemminger
Quoted 9 lines
Quoted 6 lines · On Wed, 20 Feb 2013 10:56:13 -0600 Chris Friesen<[email protected]>…

Hi,

I was just wondering why the kernel doesn't allow a new network protocol
family to be loaded as as a kernel module built outside the kernel source tree.

Quoted 5 lines
Quoted 3 lines

If you want an answer, to the question, use a tool like cscope and learn to read the kernel code. There are several tables of pointers sized by NPROTO.

That's a bit insulting, don't you think?

Absolutely not insulting at all.

The list is _NOT_ a place to go when you're just too damn lazy to take the 10 seconds it would have taken to answer your question with a quick NPROTO grep on the kernel sources.

Stephen's response to you was therefore %100 appropriate, and I would have told you likewise if I had been the first to respond.

#5 lore raw
In reply to Chris Friesen
Quoted 8 lines · Chris Friesen

Yes, there are a number of tables sized by NPROTO/AF_MAX/PF_MAX (and the fact that we use all three within the kernel is kind of sad) but there is no technical reason why we couldn't extend those dynamically if desired (with a linked list of additional protocols, perhaps).

Hence my question--is the restriction for an ideological reason or simply because nobody thought it was worth the effort?

I guess nobody did the preliminary work.

lockdep might be the tricky part.

net/core/sock.c:197:static const char *const af_family_key_strings[AF_MAX+1] = {
net/core/sock.c:211: "sk_lock-AF_NFC" , "sk_lock-AF_MAX"
net/core/sock.c:213:static const char *const af_family_slock_key_strings[AF_MAX+1] = {
net/core/sock.c:227: "slock-AF_NFC" , "slock-AF_MAX"
net/core/sock.c:229:static const char *const af_family_clock_key_strings[AF_MAX+1] = {
net/core/sock.c:243: "clock-AF_NFC" , "clock-AF_MAX"
net/core/sock.c:250:static struct lock_class_key af_callback_keys[AF_MAX];

#4 lore raw
In reply to David Miller
Quoted 19 lines · David Miller

From: Chris Friesen<[email protected]> Date: Wed, 20 Feb 2013 18:44:50 -0600

Quoted 10 lines · Stephen Hemminger
Quoted 8 lines
Quoted 5 lines · On Wed, 20 Feb 2013 10:56:13 -0600 Chris Friesen<[email protected]>…

Hi,

I was just wondering why the kernel doesn't allow a new network protocol family to be loaded as as a kernel module built outside the kernel source tree.

Quoted 5 lines
Quoted 3 lines

If you want an answer, to the question, use a tool like cscope and learn to read the kernel code. There are several tables of pointers sized by NPROTO.

That's a bit insulting, don't you think?

Quoted 8 lines

Absolutely not insulting at all.

The list is _NOT_ a place to go when you're just too damn lazy to take the 10 seconds it would have taken to answer your question with a quick NPROTO grep on the kernel sources.

Stephen's response to you was therefore %100 appropriate, and I would have told you likewise if I had been the first to respond.

As the rest of my reply to Stephen should have made clear, I in fact did read the code prior to asking the question. My question was not about the details of the current implementation, but rather the rationale behind them.

I'm fully aware that there are statically-sized tables in the current code, and thus the current code does not support dynamically adding protocols. However, it would be reasonably straightforward to extend the static tables with some form of dynamic data structure to handle adding new network protocols at runtime.

If the current restriction is intentional (to minimize the likelihood of non-GPL'd network protocols, for instance), then there's no point in anyone submitting patches to add support for dynamic network protocols.
If it's just because nobody has bothered to do it yet, then it might
be an interesting project.

Chris

#6 lore raw
In reply to Eric Dumazet
Quoted 15 lines · Eric Dumazet
Quoted 8 lines · Chris Friesen

Yes, there are a number of tables sized by NPROTO/AF_MAX/PF_MAX (and the fact that we use all three within the kernel is kind of sad) but there is no technical reason why we couldn't extend those dynamically if desired (with a linked list of additional protocols, perhaps).

Hence my question--is the restriction for an ideological reason or simply because nobody thought it was worth the effort?

I guess nobody did the preliminary work.

lockdep might be the tricky part.

Quoted 7 lines

net/core/sock.c:197:static const char *const af_family_key_strings[AF_MAX+1] = {
net/core/sock.c:211: "sk_lock-AF_NFC" , "sk_lock-AF_MAX"
net/core/sock.c:213:static const char *const af_family_slock_key_strings[AF_MAX+1] = {
net/core/sock.c:227: "slock-AF_NFC" , "slock-AF_MAX"
net/core/sock.c:229:static const char *const af_family_clock_key_strings[AF_MAX+1] = {
net/core/sock.c:243: "clock-AF_NFC" , "clock-AF_MAX"
net/core/sock.c:250:static struct lock_class_key af_callback_keys[AF_MAX];

Unless I'm missing something that looks straightforward.

When registering dynamically the new protocol would need to specify one string, the protocol name. ("AF_MYPROTOCOL" or something). The three key strings are derived from that.

The three lock_class_key structs (corresponding to af_family_keys/af_family_slock_keys/af_callback_keys) can be auto-allocated by the network core at dynamic registration time.

sock_lock_init(), sk_clone_lock(), and sock_init_data() would need special-casing for protocol number larger than AF_MAX. The most readable would probably be to do the mapping from family to key/string in helper functions rather than hard-coding a table offset right in these routines.

Yes, there would be a runtime penalty, but it should be minimal. For static protocols it would be a few "sk->sk_family < AF_MAX" checks. For dynamic protocols they might need to walk a linked list, which in all probability would be very short.

Chris

#7 lore raw
Quoted 40 lines · On Thu, 21 Feb 2013 09:47:33 -0600 Chris Friesen <[email protected]>…
Quoted 15 lines · Eric Dumazet
Quoted 8 lines · Chris Friesen

Yes, there are a number of tables sized by NPROTO/AF_MAX/PF_MAX (and the fact that we use all three within the kernel is kind of sad) but there is no technical reason why we couldn't extend those dynamically if desired (with a linked list of additional protocols, perhaps).

Hence my question--is the restriction for an ideological reason or simply because nobody thought it was worth the effort?

I guess nobody did the preliminary work.

lockdep might be the tricky part.

Quoted 7 lines

net/core/sock.c:197:static const char *const af_family_key_strings[AF_MAX+1] = {
net/core/sock.c:211: "sk_lock-AF_NFC" , "sk_lock-AF_MAX"
net/core/sock.c:213:static const char *const af_family_slock_key_strings[AF_MAX+1] = {
net/core/sock.c:227: "slock-AF_NFC" , "slock-AF_MAX"
net/core/sock.c:229:static const char *const af_family_clock_key_strings[AF_MAX+1] = {
net/core/sock.c:243: "clock-AF_NFC" , "clock-AF_MAX"
net/core/sock.c:250:static struct lock_class_key af_callback_keys[AF_MAX];

Unless I'm missing something that looks straightforward.

When registering dynamically the new protocol would need to specify one string, the protocol name. ("AF_MYPROTOCOL" or something). The three key strings are derived from that.

The three lock_class_key structs (corresponding to af_family_keys/af_family_slock_keys/af_callback_keys) can be auto-allocated by the network core at dynamic registration time.

sock_lock_init(), sk_clone_lock(), and sock_init_data() would need special-casing for protocol number larger than AF_MAX. The most readable would probably be to do the mapping from family to key/string in helper functions rather than hard-coding a table offset right in these routines.

Quoted 4 lines

Yes, there would be a runtime penalty, but it should be minimal. For static protocols it would be a few "sk->sk_family < AF_MAX" checks. For dynamic protocols they might need to walk a linked list, which in all probability would be very short.

It is not impossible to make this dynamic, you would need to make the table an allocated object and use proper locking like RCU. Oh, and because it is using GPL, the symbols would have to be EXPORT_SYMBOL_GPL(), so any dream of proprietary stacks there would be skating on even thinner ice.
The lockdep stuff makes it more complicated but not impossible.

The bigger issue is how would you manage statically assigned id's which
are not visible int headers or kernel source. How would you keep AF_VENDOR_PROTOCOL1 from not colliding with AF_VENDOR_PROTOCOL2?

#8 lore raw
Quoted 5 lines · Stephen Hemminger

It is not impossible to make this dynamic, you would need to make the table an allocated object and use proper locking like RCU. Oh, and because it is using GPL, the symbols would have to be EXPORT_SYMBOL_GPL(), so any dream of proprietary stacks there would be skating on even thinner ice.
The lockdep stuff makes it more complicated but not impossible.

I'm not even thinking about closed-source stacks. In our particular case the use-case is highly proprietary (not to mention legacy and obscure) but GPL-compliant.

Quoted 3 lines

The bigger issue is how would you manage statically assigned id's which
are not visible int headers or kernel source. How would you keep AF_VENDOR_PROTOCOL1 from not colliding with AF_VENDOR_PROTOCOL2?

I wouldn't expect many people to have multiple dynamic protocols loaded, so I'm not sure this would be a big problem.

For a fully generic solution I think we'd need to do dynamic numbering and export the mapping somewhere like /sys/class/net or /proc/sys/net/core/. This would makes things a bit non-standard for the userspace code, but would allow arbitrary numbers of dynamic protocols without collision.

Or maybe we get really crazy and do protocol namespaces. :)

Chris

#9 lore raw
In reply to Chris Friesen
Quoted 26 lines · Chris Friesen
Quoted 15 lines · Eric Dumazet
Quoted 8 lines · Chris Friesen

Yes, there are a number of tables sized by NPROTO/AF_MAX/PF_MAX (and the fact that we use all three within the kernel is kind of sad) but there is no technical reason why we couldn't extend those dynamically if desired (with a linked list of additional protocols, perhaps).

Hence my question--is the restriction for an ideological reason or simply because nobody thought it was worth the effort?

I guess nobody did the preliminary work.

lockdep might be the tricky part.

Quoted 7 lines

net/core/sock.c:197:static const char *const af_family_key_strings[AF_MAX+1] = {
net/core/sock.c:211: "sk_lock-AF_NFC" , "sk_lock-AF_MAX"
net/core/sock.c:213:static const char *const af_family_slock_key_strings[AF_MAX+1] = {
net/core/sock.c:227: "slock-AF_NFC" , "slock-AF_MAX"
net/core/sock.c:229:static const char *const af_family_clock_key_strings[AF_MAX+1] = {
net/core/sock.c:243: "clock-AF_NFC" , "clock-AF_MAX"
net/core/sock.c:250:static struct lock_class_key af_callback_keys[AF_MAX];

Unless I'm missing something that looks straightforward.

Quoted 7 lines

When registering dynamically the new protocol would need to specify one string, the protocol name. ("AF_MYPROTOCOL" or something). The three key strings are derived from that.

The three lock_class_key structs (corresponding to af_family_keys/af_family_slock_keys/af_callback_keys) can be auto-allocated by the network core at dynamic registration time.

Nope, this was the point I specifically raised but you missed it

Take a look at kernel/lockdep.c, lines 2981-2988

All the other stuff you mention seems pretty obvious.

#10 lore raw
Quoted 11 lines · Eric Dumazet
Quoted 3 lines · Chris Friesen

The three lock_class_key structs (corresponding to af_family_keys/af_family_slock_keys/af_callback_keys) can be auto-allocated by the network core at dynamic registration time.

Nope, this was the point I specifically raised but you missed it

Take a look at kernel/lockdep.c, lines 2981-2988

All the other stuff you mention seems pretty obvious.

Ah, sorry. I'm not familiar with the guts of lockdep, so I was not aware that the keys needed to be static.

Given that the lockdep code considers module addresses to be okay, it should work to make the keys static in the KLM implementing the new protocol and pass the addresses in at registration time.

Chris