PowerPC:PSeries: strncpy need limit destnation length

PATCH New Chen Gang 1 participant 1 message Feb 26, 2013 PowerPC

Share & tools

Chen Gang

author

2013-02-26 02:52 UTC #0 lore raw

PATCH 1/1 PowerPC:PSeries: strncpy need limit destnation length

the dest buf len is 80 (HVCS_CLC_LENGTH + 1).
the src buf len is PAGE_SIZE.
if src buf string len is more than 80, it will cause issue.

Signed-off-by Chen Gang <[email protected]>

---
 arch/powerpc/platforms/pseries/hvcserver.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

arch/powerpc/platforms/pseries/hvcserver.c +3 -2

index fcf4b4c..4557e91 100644
@@ -23,6 +23,7 @@
 #include <linux/list.h>
 #include <linux/module.h>
 #include <linux/slab.h>
+#include <linux/string.h>
 
 #include <asm/hvcall.h>
 #include <asm/hvcserver.h>

@@ -188,9 +189,9 @@ int hvcs_get_partner_info(uint32_t unit_address, struct list_head *head,
 			= (unsigned int)last_p_partition_ID;
 
 		/* copy the Null-term char too */
-		strncpy(&next_partner_info->location_code[0],
+		strlcpy(&next_partner_info->location_code[0],
 			(char *)&pi_buff[2],
-			strlen((char *)&pi_buff[2]) + 1);
+			sizeof(next_partner_info->location_code));
 
 		list_add_tail(&(next_partner_info->node), head);
 		next_partner_info = NULL;

Signature · 1 line

1.7.7.6