Skip to contentSkip to conversation

drivers/isdn: beautify code, delete 'break' after 'return'

PATCH In review Chen Gang 2 participants 6 messages Feb 27, 2013 – Mar 19, 2013

Subsystems (2)
lore
Share & tools
lore

Chen Gang

author
#0 lore raw

delete 'break' statement after 'return' statement

---
 drivers/isdn/i4l/isdn_tty.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/isdn/i4l/isdn_tty.c +0 -1
index d8a7d83..925a7ed 100644
@@ -3425,7 +3425,6 @@ isdn_tty_parse_at(modem_info *info)
 			p++;
 			isdn_tty_cmd_ATA(info);
 			return;
-			break;
 		case 'D':
 			/* D - Dial */
 			if (info->msr & UART_MSR_DCD)
Signature · 1 line
1.7.7.6
author
#1 lore raw

oh, sorry, the subject misses [PATCH], I will send again.

Quoted 21 lines · Chen Gang

delete 'break' statement after 'return' statement

---
 drivers/isdn/i4l/isdn_tty.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/isdn/i4l/isdn_tty.c +0 -1
index d8a7d83..925a7ed 100644
@@ -3425,7 +3425,6 @@ isdn_tty_parse_at(modem_info *info)
 			p++;
 			isdn_tty_cmd_ATA(info);
 			return;
-			break;
 		case 'D':
 			/* D - Dial */
 			if (info->msr & UART_MSR_DCD)
Signature · 3 lines
Chen Gang

Asianux Corporation
author
#2 lore raw

PATCH 1/1 drivers/isdn: beautify code, delete 'break' after 'return'

In reply to Chen Gang

delete 'break' statement after 'return' statement

---
 drivers/isdn/i4l/isdn_tty.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/isdn/i4l/isdn_tty.c +0 -1
index d8a7d83..925a7ed 100644
@@ -3425,7 +3425,6 @@ isdn_tty_parse_at(modem_info *info)
 			p++;
 			isdn_tty_cmd_ATA(info);
 			return;
-			break;
 		case 'D':
 			/* D - Dial */
 			if (info->msr & UART_MSR_DCD)
Signature · 1 line
1.7.7.6
author
#3 lore raw

Hello Maintainers:

is it patch ok ?

thanks.

Quoted 21 lines · Chen Gang

delete 'break' statement after 'return' statement

---
 drivers/isdn/i4l/isdn_tty.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/isdn/i4l/isdn_tty.c +0 -1
index d8a7d83..925a7ed 100644
@@ -3425,7 +3425,6 @@ isdn_tty_parse_at(modem_info *info)
 			p++;
 			isdn_tty_cmd_ATA(info);
 			return;
-			break;
 		case 'D':
 			/* D - Dial */
 			if (info->msr & UART_MSR_DCD)
Signature · 3 lines
Chen Gang

Asianux Corporation
#4 lore raw
Quoted 3 lines · Chen Gang

Hello Maintainers:

is it patch ok ?

This one is now applied.

Signature · 2 lines
Jiri Kosina
SUSE Labs
author
#5 lore raw
Quoted 6 lines · Jiri Kosina
Quoted 3 lines · Chen Gang
Quoted 3 lines

Hello Maintainers:

is it patch ok ?

This one is now applied.

thanks.

Signature · 3 lines
Chen Gang

Asianux Corporation