mfd: omap-usb-host: bug fix for 3.9
Subsystems (2)
Hi Samuel,
One of my patch that I sent for 3.9 introduces a bug that fails to update the port mode hostconfig register. Because of that, the port modes will always be 0 (i.e. EHCI PHY mode) and other modes will not work. PHY mode will work, so beagle/panda have no issues.
Since my hardware setup uses only PHY mode, I couldn't catch this problem earlier.
Below is the fix.
Quoted 1 line
From
82466757a212bd8b54d806c9d56b1acccbd4d464Mon Sep 17 00:00:00 2001
From: Roger Quadros <[email protected]>
Date: Wed, 27 Feb 2013 15:19:24 +0200
Subject: [PATCH] mfd: omap-usb-host: Actually update hostconfig
The helper functions omap_usbhs_rev1_hostconfig()
and omap_usbhs_rev2_hostconfig() don't write into
the hostconfig register. Make sure that we write
the return value into the hostconfig register.
--- drivers/mfd/omap-usb-host.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/mfd/omap-usb-host.c +3 -3
@@ -460,15 +460,15 @@ static void omap_usbhs_init(struct device *dev)switch (omap->usbhs_rev) {case OMAP_USBHS_REV1 : -omap_usbhs_rev1_hostconfig (omap, reg); + reg =omap_usbhs_rev1_hostconfig (omap, reg);break ;case OMAP_USBHS_REV2 : -omap_usbhs_rev2_hostconfig (omap, reg); + reg =omap_usbhs_rev2_hostconfig (omap, reg);break ;default :/* newer revisions */ -omap_usbhs_rev2_hostconfig (omap, reg); + reg =omap_usbhs_rev2_hostconfig (omap, reg);break ; }
Signature · 1 line
1.7.4.1
Hi Samuel,
Quoted 10 lines · Roger Quadros
Hi Samuel,
One of my patch that I sent for 3.9 introduces a bug that fails to update the port mode hostconfig register. Because of that, the port modes will always be 0 (i.e. EHCI PHY mode) and other modes will not work. PHY mode will work, so beagle/panda have no issues.
Since my hardware setup uses only PHY mode, I couldn't catch this problem earlier.
Below is the fix.
Gentle reminder to pick this for 3.9-rc2. Thanks.
cheers,
-roger
Quoted 40 lines
Quoted 2 lines
From
82466757a212bd8b54d806c9d56b1acccbd4d464Mon Sep 17 00:00:00 2001From: Roger Quadros <[email protected]>
Date: Wed, 27 Feb 2013 15:19:24 +0200
Subject: [PATCH] mfd: omap-usb-host: Actually update hostconfigThe helper functions
omap_usbhs_rev1_hostconfig()
andomap_usbhs_rev2_hostconfig()don't write into
the hostconfig register. Make sure that we write
the return value into the hostconfig register.Signed-off-by Roger Quadros <[email protected]>--- drivers/mfd/omap-usb-host.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/mfd/omap-usb-host.c +3
-3@@ -460,15 +460,15 @@ static void omap_usbhs_init(struct device *dev)switch (omap->usbhs_rev) {case OMAP_USBHS_REV1 : -omap_usbhs_rev1_hostconfig (omap, reg); + reg =omap_usbhs_rev1_hostconfig (omap, reg);break ;case OMAP_USBHS_REV2 : -omap_usbhs_rev2_hostconfig (omap, reg); + reg =omap_usbhs_rev2_hostconfig (omap, reg);break ;default :/* newer revisions */ -omap_usbhs_rev2_hostconfig (omap, reg); + reg =omap_usbhs_rev2_hostconfig (omap, reg);break ; }
Hi Roger,
Quoted 21 lines · Roger Quadros
Hi Samuel,
One of my patch that I sent for 3.9 introduces a bug that fails to update the port mode hostconfig register. Because of that, the port modes will always be 0 (i.e. EHCI PHY mode) and other modes will not work. PHY mode will work, so beagle/panda have no issues.
Since my hardware setup uses only PHY mode, I couldn't catch this problem earlier.
Below is the fix.
From
82466757a212bd8b54d806c9d56b1acccbd4d464Mon Sep 17 00:00:00 2001
From: Roger Quadros <[email protected]>
Date: Wed, 27 Feb 2013 15:19:24 +0200
Subject: [PATCH] mfd: omap-usb-host: Actually update hostconfigThe helper functions
omap_usbhs_rev1_hostconfig()
andomap_usbhs_rev2_hostconfig()don't write into
the hostconfig register. Make sure that we write
the return value into the hostconfig register.
Quoted 4 lines
Signed-off-by Roger Quadros <[email protected]>--- drivers/mfd/omap-usb-host.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
Patch applied now, thanks.
Cheers,
Samuel.
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/