spare/sysrq: fix inconstistent help message of sysrq key
PATCH 6/8 spare/sysrq: fix inconstistent help message of sysrq key
Currently help message of /proc/sysrq-trigger highlight its upper-case characters, like below:
SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E) memory-full-oom-kill(F) kill-all-tasks(I) ...
this would confuse user trigger sysrq by upper-case character, which is inconsistent with the real lower-case character registed key.
This inconsistent help message will also lead more confused when 26 upper-case letters put into use in future.
This patch fix spare sysrq key: "global-regs(y)"
--- arch/sparc/kernel/process_64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/sparc/kernel/process_64.c +2 -2
@@ -315,7 +315,7 @@ static void sysrq_handle_globreg(int key)static struct sysrq_key_op sparc_globalreg_op = { .handler = sysrq_handle_globreg, - .help_msg ="global-regs(Y)" , + .help_msg ="global-regs(y)" , .action_msg ="Show Global CPU Regs" , };
@@ -385,7 +385,7 @@ static void sysrq_handle_globpmu(int key)static struct sysrq_key_op sparc_globalpmu_op = { .handler = sysrq_handle_globpmu, - .help_msg ="global-pmu(X)" , + .help_msg ="global-pmu(x)" , .action_msg ="Show Global PMU Regs" , };
Signature · 1 line
1.7.9.7
From: "zhangwei(Jovi)" <[email protected]>
Date: Thu, 7 Mar 2013 17:00:32 +0800
Quoted 9 lines
Currently help message of
/proc/sysrq-triggerhighlight its upper-case characters, like below:SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E) memory-full-oom-kill(F) kill-all-tasks(I) ...
this would confuse user trigger sysrq by upper-case character, which is inconsistent with the real lower-case character registed key.
Quoted 6 lines
This inconsistent help message will also lead more confused when 26 upper-case letters put into use in future.
This patch fix spare sysrq key: "global-regs(y)"
Signed-off-by zhangwei(Jovi) <[email protected]>
Quoted 12 lines · David Miller
From: "zhangwei(Jovi)" <[email protected]>
Date: Thu, 7 Mar 2013 17:00:32 +0800Quoted 9 lines
Currently help message of
/proc/sysrq-triggerhighlight its upper-case characters, like below:SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E) memory-full-oom-kill(F) kill-all-tasks(I) ...
this would confuse user trigger sysrq by upper-case character, which is inconsistent with the real lower-case character registed key.
Quoted 9 lines
Quoted 6 lines
This inconsistent help message will also lead more confused when 26 upper-case letters put into use in future.
This patch fix spare sysrq key: "global-regs(y)"
Signed-off-by zhangwei(Jovi) <[email protected]>Acked-by David S. Miller <[email protected]>
David, this patch is already got your ack,
so would you please pick up this patch into your tree for next 3.10? Thanks.
David Miller
maintainerFrom: "zhangwei(Jovi)" <[email protected]>
Date: Sat, 20 Apr 2013 15:41:03 +0800
Quoted 16 lines · David Miller
Quoted 15 lines
From: "zhangwei(Jovi)" <[email protected]>
Date: Thu, 7 Mar 2013 17:00:32 +0800Quoted 12 lines
Currently help message of
/proc/sysrq-triggerhighlight its upper-case characters, like below:SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E) memory-full-oom-kill(F) kill-all-tasks(I) ...
this would confuse user trigger sysrq by upper-case character, which is inconsistent with the real lower-case character registed key.
This inconsistent help message will also lead more confused when 26 upper-case letters put into use in future.
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
This patch fix spare sysrq key: "global-regs(y)"
Signed-off-by zhangwei(Jovi) <[email protected]>Acked-by David S. Miller <[email protected]>David, this patch is already got your ack,
so would you please pick up this patch into your tree for next 3.10?
Sparc patches should be sent to [email protected] so that they are properly queued up and tracked in patchwork.