Skip to contentSkip to conversation

firewire net: Clear dev->broadcast_rcv_context and dev->broadcast_state after destruction of context.

RFC In review YOSHIFUJI Hideaki 1 participant 1 message Mar 8, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC 6/11 firewire net: Clear dev->broadcast_rcv_context and dev->broadcast_state after destruction of context.

Clear dev->broadcast_rcv_context to NULL and set dev->broadcast_state to FWNET_BROADCAST_ERROR after descruction of broadcast context.

---
 drivers/firewire/net.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/firewire/net.c +3 -0
index d9b2105..efed4a6 100644
@@ -1626,11 +1626,14 @@ static int fwnet_remove(struct device *_dev)
 		fwnet_fifo_stop(dev);
 		if (dev->broadcast_rcv_context) {
 			fw_iso_context_stop(dev->broadcast_rcv_context);
+
 			kfree(dev->broadcast_rcv_buffer_ptrs);
 			dev->broadcast_rcv_buffer_ptrs = NULL;
 			fw_iso_buffer_destroy(&dev->broadcast_rcv_buffer,
 					      dev->card);
 			fw_iso_context_destroy(dev->broadcast_rcv_context);
+			dev->broadcast_rcv_context = NULL;
+			dev->broadcast_state = FWNET_BROADCAST_ERROR;
 		}
 		for (i = 0; dev->queued_datagrams && i < 5; i++)
 			ssleep(1);
Signature · 1 line
1.7.9.5