Skip to contentSkip to conversation

firewire net: Check dev->broadcast_state inside fwnet_broadcast_start().

RFC In review YOSHIFUJI Hideaki 1 participant 1 message Mar 8, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC 4/11 firewire net: Check dev->broadcast_state inside fwnet_broadcast_start().

---
 drivers/firewire/net.c |   12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/firewire/net.c +7 -5
index fbd07eb..9a2634a 100644
@@ -1156,6 +1156,9 @@ static int fwnet_broadcast_start(struct fwnet_device *dev)
 	unsigned long offset;
 	unsigned u;
 
+	if (dev->broadcast_state != FWNET_BROADCAST_ERROR)
+		return 0;
+
 	max_receive = 1U << (dev->card->max_receive + 1);
 	num_packets = (FWNET_ISO_PAGE_COUNT * PAGE_SIZE) / max_receive;
 
@@ -1258,11 +1261,10 @@ static int fwnet_open(struct net_device *net)
 	if (ret)
 		return ret;
 
-	if (dev->broadcast_state == FWNET_BROADCAST_ERROR) {
-		ret = fwnet_broadcast_start(dev);
-		if (ret)
-			goto out;
-	}
+	ret = fwnet_broadcast_start(dev);
+	if (ret)
+		goto out;
+
 	netif_start_queue(net);
 
 	spin_lock_irq(&dev->lock);
Signature · 1 line
1.7.9.5