Skip to contentSkip to conversation

ARM:kernel: beautify code, rel->r_offset is __u32 which never < 0

PATCH New Chen Gang 1 participant 1 message Mar 10, 2013 Arm (32-bit)

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 ARM:kernel: beautify code, rel->r_offset is __u32 which never < 0

rel->r_offset is __u32 which never < 0.
it is defined in uapi/linux/elf.h

---
 arch/arm/kernel/module.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/kernel/module.c +1 -1
index 1e9be5d..386086e 100644
@@ -74,7 +74,7 @@ apply_relocate(Elf32_Shdr *sechdrs, const char *strtab, unsigned int symindex,
 		sym = ((Elf32_Sym *)symsec->sh_addr) + offset;
 		symname = strtab + sym->st_name;
 
-		if (rel->r_offset < 0 || rel->r_offset > dstsec->sh_size - sizeof(u32)) {
+		if (rel->r_offset > dstsec->sh_size - sizeof(u32)) {
 			pr_err("%s: section %u reloc %u sym '%s': out of bounds relocation, offset %d size %u\n",
 			       module->name, relindex, i, symname,
 			       rel->r_offset, dstsec->sh_size);
Signature · 1 line
1.7.7.6