ARM:kernel: beautify code, using 'static const' instead of 'const static'
PATCH 1/1 ARM:kernel: beautify code, using 'static const' instead of 'const static'
better using 'static const' instead of 'const static'
--- arch/arm/kernel/smp_twd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/kernel/smp_twd.c +1 -1
@@ -362,7 +362,7 @@ int __init twd_local_timer_register(struct twd_local_timer *tlt) }#ifdef CONFIG_OF -const static struct of_device_id twd_of_match[]__initconst = { +static const struct of_device_id twd_of_match[]__initconst = { { .compatible ="arm,cortex-a9-twd-timer" , }, { .compatible ="arm,cortex-a5-twd-timer" , }, { .compatible = "arm,arm11mp-twd-timer", },
Signature · 1 line
1.7.7.6
Quoted 13 lines · Chen Gang
better using 'static const' instead of 'const static'
Signed-off-by Chen Gang <[email protected]>--- arch/arm/kernel/smp_twd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/kernel/smp_twd.c +0
-0
arch/arm/kernel/smp_twd.c int __init twd_local_timer_register(struct twd_local_timer *tlt) · line 365
Quoted 5 lines
arch/arm/kernel/smp_twd.c +1
-1@@ -362,7 +362,7 @@ int __init twd_local_timer_register(struct twd_local_timer *tlt) }#ifdef CONFIG_OF -const static struct of_device_id twd_of_match[] __initconst = { +static const struct of_device_id twd_of_match[] __initconst = {
This will go away with conversion to use CLKSRC_OF.
Rob
Quoted 4 lines
arch/arm/kernel/smp_twd.c +0
-0{ .compatible = "arm,cortex-a9-twd-timer", }, { .compatible = "arm,cortex-a5-twd-timer", }, { .compatible = "arm,arm11mp-twd-timer", },
? 2013?03?11? 09:26, Rob Herring ??:
Quoted 16 lines · Chen Gang
Quoted 15 lines
Quoted 15 lines
better using 'static const' instead of 'const static'
Signed-off-by Chen Gang <[email protected]>--- arch/arm/kernel/smp_twd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/arm/kernel/smp_twd.c +0
-0@@ -362,7 +362,7 @@ int __init twd_local_timer_register(struct twd_local_timer *tlt) }
Quoted 4 lines
Quoted 3 lines
arch/arm/kernel/smp_twd.c int __init twd_local_timer_register(struct twd_local_timer *tlt) · line 365
Quoted 3 lines
arch/arm/kernel/smp_twd.c +1
-1#ifdef CONFIG_OF -const static struct of_device_id twd_of_match[] __initconst = { +static const struct of_device_id twd_of_match[] __initconst = {This will go away with conversion to use
CLKSRC_OF.
excuse me, I am not quite familiar with ARM, so I do not quite
understand what you said.
could you describe it with more details ?
and how about this patch ?
a. do not need this patch.
b. or this patch need improving.
c. or this patch is ok, can be applied.
thanks.
Signature · 3 lines
Chen Gang Asianux Corporation