Skip to contentSkip to conversation

ARM:vexpress: beautify code, using 'static const' instead of 'const static'

PATCH New Chen Gang 3 participants 4 messages Mar 10, 2013 – Mar 11, 2013

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/versatile express platform
lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 ARM:vexpress: beautify code, using 'static const' instead of 'const static'

better using 'static const' instead of 'const static'

Signed-off-by Chen Gang <[email protected]>
---
 arch/arm/mach-vexpress/platsmp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-vexpress/platsmp.c +1 -1
index dc1ace5..9152bf7 100644
@@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = {
 
 static void *vexpress_dt_cortex_a9_scu_base __initdata;
 
-const static char *vexpress_dt_cortex_a9_match[] __initconst = {
+static const char *vexpress_dt_cortex_a9_match[] __initconst = {
 	"arm,cortex-a5-scu",
 	"arm,cortex-a9-scu",
 	NULL
Signature · 1 line
1.7.7.6
#1 lore raw

PATCH 1/1 ARM:vexpress: beautify code, using 'static const' instead of 'const static'

Quoted 13 lines · Chen Gang

better using 'static const' instead of 'const static'

Signed-off-by Chen Gang <[email protected]>
---
 arch/arm/mach-vexpress/platsmp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-vexpress/platsmp.c +0 -0
index dc1ace5..9152bf7 100644

arch/arm/mach-vexpress/platsmp.c static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = { · line 43

Quoted 5 lines
arch/arm/mach-vexpress/platsmp.c +1 -1
@@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = {
 
 static void *vexpress_dt_cortex_a9_scu_base __initdata;
 
-const static char *vexpress_dt_cortex_a9_match[] __initconst = {
+static const char *vexpress_dt_cortex_a9_match[] __initconst = {
Acked-by Viresh Kumar <[email protected]>
author
#2 lore raw

PATCH 1/1 ARM:vexpress: beautify code, using 'static const' instead of 'const static'

? 2013?03?10? 10:57, Viresh Kumar ??:

Quoted 15 lines · Chen Gang
Quoted 14 lines
Quoted 14 lines

better using 'static const' instead of 'const static'

Signed-off-by Chen Gang <[email protected]>
---
 arch/arm/mach-vexpress/platsmp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-vexpress/platsmp.c +0 -0
index dc1ace5..9152bf7 100644
@@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = {
Quoted 7 lines
Quoted 4 lines

arch/arm/mach-vexpress/platsmp.c static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = { · line 43

Quoted 4 lines
arch/arm/mach-vexpress/platsmp.c +1 -1
 static void *vexpress_dt_cortex_a9_scu_base __initdata;
 
-const static char *vexpress_dt_cortex_a9_match[] __initconst = {
+static const char *vexpress_dt_cortex_a9_match[] __initconst = {
Acked-by Viresh Kumar <[email protected]>

thank you.

:-)

Signature · 3 lines
Chen Gang

Asianux Corporation
#3 lore raw

PATCH 1/1 ARM:vexpress: beautify code, using 'static const' instead of 'const static'

In reply to Chen Gang
Quoted 12 lines · Chen Gang

better using 'static const' instead of 'const static'

Signed-off-by Chen Gang <[email protected]>
---
 arch/arm/mach-vexpress/platsmp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-vexpress/platsmp.c +0 -0
index dc1ace5..9152bf7 100644

arch/arm/mach-vexpress/platsmp.c static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = { · line 46

Quoted 8 lines
arch/arm/mach-vexpress/platsmp.c +1 -1
@@ -40,7 +40,7 @@ static struct map_desc vexpress_dt_cortex_a9_scu_map __initdata = {
 
 static void *vexpress_dt_cortex_a9_scu_base __initdata;
 
-const static char *vexpress_dt_cortex_a9_match[] __initconst = {
+static const char *vexpress_dt_cortex_a9_match[] __initconst = {
 	"arm,cortex-a5-scu",
 	"arm,cortex-a9-scu",
 	NULL

Thanks for spotting this. I will keep this in mind, but I can't promise to take this patch as it goes, because the platsmp.c is likely to change (shrink) in near future. Either way I'll make sure you get due credit :-)

Cheers!

Pawel