Skip to contentSkip to conversation

drivers/clk: fixup commit 72480014b86c8b51fb51c5c6a0525876055c37c7

PATCH New Chen Gang 2 participants 4 messages Mar 10, 2013 – Mar 15, 2013 Common clk

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 drivers/clk: fixup commit 72480014b86c8b51fb51c5c6a0525876055c37c7

prate is not defined, will cause compiling issue. need use parent_rate instead of prate.

---
 drivers/clk/clk-vt8500.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/clk/clk-vt8500.c +1 -1
index b5538bb..09c6331 100644
@@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
 	divisor =  parent_rate / rate;
 
 	/* If prate / rate would be decimal, incr the divisor */
-	if (rate * divisor < *prate)
+	if (rate * divisor < parent_rate)
 		divisor++;
 
 	if (divisor == cdev->div_mask + 1)
Signature · 1 line
1.7.7.6
author
#1 lore raw

PATCH 1/1 drivers/clk: fixup commit 72480014b86c8b51fb51c5c6a0525876055c37c7

is there any member to help checking and applying it ?

this issue is repeated again by randconfig make, today.

? 2013?03?10? 11:48, Chen Gang ??:

Quoted 23 lines

prate is not defined, will cause compiling issue. need use parent_rate instead of prate.

---
 drivers/clk/clk-vt8500.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/clk/clk-vt8500.c +1 -1
index b5538bb..09c6331 100644
@@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
 	divisor =  parent_rate / rate;
 
 	/* If prate / rate would be decimal, incr the divisor */
-	if (rate * divisor < *prate)
+	if (rate * divisor < parent_rate)
 		divisor++;
 
 	if (divisor == cdev->div_mask + 1)
Signature · 3 lines
Chen Gang

Asianux Corporation
#2 lore raw

PATCH 1/1 drivers/clk: fixup commit 72480014b86c8b51fb51c5c6a0525876055c37c7

Quoted 22 lines · Chen Gang

is there any member to help checking and applying it ?

this issue is repeated again by randconfig make, today.

? 2013?03?10? 11:48, Chen Gang ??:

Quoted 16 lines

prate is not defined, will cause compiling issue. need use parent_rate instead of prate.

---
 drivers/clk/clk-vt8500.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/clk/clk-vt8500.c +0 -0
index b5538bb..09c6331 100644
@@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
 	divisor =  parent_rate / rate;
 
Quoted 9 lines

drivers/clk/clk-vt8500.c static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, · line 163

Quoted 7 lines
drivers/clk/clk-vt8500.c +1 -1
 	/* If prate / rate would be decimal, incr the divisor */
-	if (rate * divisor < *prate)
+	if (rate * divisor < parent_rate)
 		divisor++;
 
 	if (divisor == cdev->div_mask + 1)

The patch for this is in Mike's clk-fixes branch.

Regards
Tony Prisk

author
#3 lore raw

PATCH 1/1 drivers/clk: fixup commit 72480014b86c8b51fb51c5c6a0525876055c37c7

? 2013?03?15? 01:48, Tony Prisk ??:

Quoted 28 lines · Chen Gang
Quoted 27 lines
Quoted 27 lines

is there any member to help checking and applying it ?

this issue is repeated again by randconfig make, today.

? 2013?03?10? 11:48, Chen Gang ??:

Quoted 21 lines
Quoted 21 lines

prate is not defined, will cause compiling issue. need use parent_rate instead of prate.

---
 drivers/clk/clk-vt8500.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/clk/clk-vt8500.c +1 -1
index b5538bb..09c6331 100644
@@ -157,7 +157,7 @@ static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate,
 	divisor =  parent_rate / rate;
 
 	/* If prate / rate would be decimal, incr the divisor */
-	if (rate * divisor < *prate)
+	if (rate * divisor < parent_rate)
 		divisor++;
 
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

drivers/clk/clk-vt8500.c static int vt8500_dclk_set_rate(struct clk_hw *hw, unsigned long rate, · line 163

Quoted 2 lines
drivers/clk/clk-vt8500.c +0 -0
 	if (divisor == cdev->div_mask + 1)

The patch for this is in Mike's clk-fixes branch.

thanks.

hope to integrate next-* tree soon.

:-)

Signature · 3 lines
Chen Gang

Asianux Corporation