Skip to contentSkip to conversation

xfs: Remove obsoleted m_inode_shrink from xfs_mount structure

PATCH Applied Jeff Liu 3 participants 3 messages Mar 11, 2013 – Mar 14, 2013 XFS filesystem

lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

PATCH 1/1 xfs: Remove obsoleted m_inode_shrink from xfs_mount structure

Looks the old m_inode_shrink is obsoleted as we perform inodes reclaim per AG via m_reclaim_workqueue, this patch remove it from the xfs_mount structure if so.

Cc Dave Chinner <[email protected]>
---
 fs/xfs/xfs_mount.h |    1 -
 1 file changed, 1 deletion(-)
fs/xfs/xfs_mount.h +0 -1
index bc90706..687c171 100644
@@ -207,7 +207,6 @@ typedef struct xfs_mount {
 						     trimming */
 	__int64_t		m_update_flags;	/* sb flags we need to update
 						   on the next remount,rw */
-	struct shrinker		m_inode_shrink;	/* inode reclaim shrinker */
 	int64_t			m_low_space[XFS_LOWSP_MAX];
 						/* low free space thresholds */
 
Signature · 6 lines
1.7.9.5

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Jeff Liu

Looks the old m_inode_shrink is obsoleted as we perform inodes reclaim per AG via m_reclaim_workqueue, this patch remove it from the xfs_mount structure if so.

Cc Dave Chinner<[email protected]>
---
  fs/xfs/xfs_mount.h |    1 -
  1 file changed, 1 deletion(-)
fs/xfs/xfs_mount.h +0 -0
index bc90706..687c171 100644

fs/xfs/xfs_mount.h typedef struct xfs_mount { · line 212

Quoted 7 lines
fs/xfs/xfs_mount.h +0 -1
@@ -207,7 +207,6 @@ typedef struct xfs_mount {
  						     trimming */
  	__int64_t		m_update_flags;	/* sb flags we need to update
  						   on the next remount,rw */
-	struct shrinker		m_inode_shrink;	/* inode reclaim shrinker */
  	int64_t			m_low_space[XFS_LOWSP_MAX];
  						/* low free space thresholds */
 

Obsoleted in commit:

commit 8daaa83145ef1f0a146680618328dbbd0fa76939

Author: Dave Chinner <[email protected]>
Date:   Fri Jul 8 14:14:46 2011 +1000

xfs: make use of new shrinker callout for the inode cache

Looks good.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs