scsi/tracing: include correct header file
PATCH 12/13 scsi/tracing: include correct header file
scsi_trace.c just export function scsi_trace_parse_cdb to event tracing infrastructure, It's not necessary to include trace/events/scsi.h
--- drivers/scsi/scsi_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/scsi_trace.c +1 -1
@@ -17,7 +17,7 @@*/ #include <linux/kernel.h> #include <linux/trace_seq.h> -#include <trace/events/scsi.h> +#include <scsi/scsi.h> #define SERVICE_ACTION16 (cdb) (cdb[1] & 0x1f)#define SERVICE_ACTION32 (cdb) ((cdb[8] << 8) | cdb[9])
Signature · 1 line
1.7.9.7
As you didn't include James in the header patch [0/13], he didn't see you say:
"Two patches changed compilation on scsi subsystem, it should go through to
SCSI tree."
In the future, send them as a separate patch series. There's no dependencies on these patches with the rest of the series. They should have been sent directly to James, with me as the Cc.
-- Steve
Quoted 22 lines · zhangwei(Jovi)
scsi_trace.cjust export functionscsi_trace_parse_cdbto event tracing infrastructure, It's not necessary to includetrace/events/scsi.hSigned-off-by zhangwei(Jovi) <[email protected]>--- drivers/scsi/scsi_trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/scsi/scsi_trace.c +1
-1@@ -17,7 +17,7 @@*/ #include <linux/kernel.h> #include <linux/trace_seq.h> -#include <trace/events/scsi.h> +#include <scsi/scsi.h> #define SERVICE_ACTION16 (cdb) (cdb[1] & 0x1f)#define SERVICE_ACTION32 (cdb) ((cdb[8] << 8) | cdb[9])
Quoted 10 lines · Steven Rostedt
As you didn't include James in the header patch [0/13], he didn't see you say:
"Two patches changed compilation on scsi subsystem, it should go through to
SCSI tree."In the future, send them as a separate patch series. There's no dependencies on these patches with the rest of the series. They should have been sent directly to James, with me as the Cc.
Actually, if you want them applied, they need to go to the SCSI list <[email protected]>. It tracks all my pending patches. Stuff to me personally has a high probability of getting forgotten.
Thanks,
James
Quoted 7 lines · James Bottomley
Quoted 3 lines
In the future, send them as a separate patch series. There's no dependencies on these patches with the rest of the series. They should have been sent directly to James, with me as the Cc.
Actually, if you want them applied, they need to go to the SCSI list <[email protected]>. It tracks all my pending patches. Stuff to me personally has a high probability of getting forgotten.
Zhangwei,
As you may be sending patches to other maintainers, please read the MAINTAINERS file and send appropriate patches in a separate series to them as directed:
SCSI SUBSYSTEM
M: "James E.J. Bottomley" <[email protected]> L: [email protected] T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-pending-2.6.git S: Maintained F: drivers/scsi/ F: include/scsi/
Cc the listed maintainers, as well as the listed "L:" lists.
-- Steve
Quoted 26 lines · Steven Rostedt
Quoted 7 lines · James Bottomley
Quoted 3 lines
In the future, send them as a separate patch series. There's no dependencies on these patches with the rest of the series. They should have been sent directly to James, with me as the Cc.
Actually, if you want them applied, they need to go to the SCSI list <[email protected]>. It tracks all my pending patches. Stuff to me personally has a high probability of getting forgotten.
Zhangwei,
As you may be sending patches to other maintainers, please read the
MAINTAINERSfile and send appropriate patches in a separate series to them as directed:SCSI SUBSYSTEM
M: "James E.J. Bottomley" <[email protected]> L: [email protected] T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6.git T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-pending-2.6.git S: Maintained F: drivers/scsi/ F: include/scsi/
Quoted 2 lines
Cc the listed maintainers, as well as the listed "L:" lists.
Thanks, sometimes I forgot cc mailing list in MAINTAINERS file(just attention on M),
I will got this in next patch submission.
I will resend those two patches with Cc [email protected]
Quoted 8 lines
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 3 lines · Jovi Zhang
Thanks, sometimes I forgot cc mailing list in
MAINTAINERSfile(just attention on M),
I will got this in next patch submission.
Note, the patches I said were fine, please do not resend. I'll take them as is.
Quoted 2 lines
I will resend those two patches with Cc [email protected]
Send them as their own patch set. They do not need to be included with the others.
-- Steve