Skip to contentSkip to conversation

mmap: find_vma: remove the WARN_ON_ONCE(!mm) check

PATCH New Zhang Yanfei 1 participant 1 message Mar 13, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmap: find_vma: remove the WARN_ON_ONCE(!mm) check

Remove the WARN_ON_ONCE(!mm) check as the comment suggested. Kernel code calls find_vma only when it is absolutely sure that the mm_struct arg to it is non-NULL.

---
 mm/mmap.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
mm/mmap.c +0 -3
index 2664a47..9da664e 100644
@@ -1933,9 +1933,6 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
 {
 	struct vm_area_struct *vma = NULL;
 
-	if (WARN_ON_ONCE(!mm))		/* Remove this in linux-3.6 */
-		return NULL;
-
 	/* Check the cache first. */
 	/* (Cache hit rate is typically around 35%.) */
 	vma = mm->mmap_cache;
Signature · 1 line
1.7.1