Skip to contentSkip to conversation

ARM: kirkwood: Fix chip-delay for GoFlex Net

PATCH New Eric Hutter 4 participants 5 messages Mar 18, 2013 – Mar 28, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: kirkwood: Fix chip-delay for GoFlex Net

Hi,

This fixes "Too few good blocks within range" issues on GoFlex Net by setting chip-delay to 40. I've been using this patch on my device for quite a while now (accessing uboot vars is not possible without it). The basic problem was discussed at
http://forum.doozan.com/read.php?2,7451 and I think this fix should go mainstream.

Greetings

Eric Hutter

---
  arch/arm/boot/dts/kirkwood-goflexnet.dts | 1 +
  1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/arch/arm/boot/dts/kirkwood-goflexnet.dts
index bd83b8f..c3573be 100644

arch/arm/boot/dts/kirkwood-goflexnet.dts +1 -0
@@ -77,6 +77,7 @@
          };
 
          nand at 3000000 {
+            chip-delay = <40>;
              status = "okay";
 
              partition at 0 {
Signature · 1 line
1.8.1.4
#1 lore raw

PATCH 1/1 ARM: kirkwood: Fix chip-delay for GoFlex Net

Quoted 4 lines · Eric Hutter

Hi,

This fixes "Too few good blocks within range" issues on GoFlex Net by setting chip-delay to 40.

Hi Eric

Its a problem seen by a couple of other boards as well, e.g. dns320 and dns325.

Quoted 22 lines
---
 arch/arm/boot/dts/kirkwood-goflexnet.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/kirkwood-goflexnet.dts +1 -0
index bd83b8f..c3573be 100644
@@ -77,6 +77,7 @@
         };
 
         nand at 3000000 {
+            chip-delay = <40>;
             status = "okay";
 
             partition at 0 {
Signature · 1 line
1.8.1.4
#2 lore raw

PATCH 1/1 ARM: kirkwood: Fix chip-delay for GoFlex Net

Quoted 10 lines · Andrew Lunn
Quoted 4 lines · Eric Hutter

Hi,

This fixes "Too few good blocks within range" issues on GoFlex Net by setting chip-delay to 40.

Hi Eric

Its a problem seen by a couple of other boards as well, e.g. dns320 and dns325.

The MTD core default of 20us is too small for modern NAND flash.. This number is based on the chip's datahseet, it should be the longest non-programming command BUSY interval. Eric, if you haven't already, it is worth a quick check of the datasheet to verify. Eg the Micron flash on my Kirkwood system should be 70us.

u-boot can sometimes get away with a smaller value because it only uses a limited set of commands.

It is on my TODO list to implement ONFI READY/BUSY# pin support in the orion-nand driver via a GPIO - could other systems make use of this as well?

Regards,
Jason

#3 lore raw

PATCH 1/1 ARM: kirkwood: Fix chip-delay for GoFlex Net

In reply to Eric Hutter
Quoted 11 lines · Eric Hutter

Hi,

This fixes "Too few good blocks within range" issues on GoFlex Net by setting chip-delay to 40. I've been using this patch on my device for quite a while now (accessing uboot vars is not possible without it). The basic problem was discussed at
http://forum.doozan.com/read.php?2,7451 and I think this fix should go mainstream.

Greetings

Quoted 7 lines

Eric Hutter

---
 arch/arm/boot/dts/kirkwood-goflexnet.dts | 1 +
 1 file changed, 1 insertion(+)

Nice catch! I'll include this in the next round of fixes I push.

thx,

Jason.

Applied
#4 lore raw

PATCH 1/1 ARM: kirkwood: Fix chip-delay for GoFlex Net

In reply to Eric Hutter
Quoted 9 lines · Eric Hutter

Hi,

This fixes "Too few good blocks within range" issues on GoFlex Net by setting chip-delay to 40. I've been using this patch on my device for quite a while now (accessing uboot vars is not possible without it). The basic problem was discussed at
http://forum.doozan.com/read.php?2,7451 and I think this fix should go mainstream.

Quoted 7 lines

Greetings

Eric Hutter

---

[1] (see below)

Quoted 2 lines
 arch/arm/boot/dts/kirkwood-goflexnet.dts | 1 +
 1 file changed, 1 insertion(+)

Applied to mvebu/fixes.

I cleaned up the commit message to remove the conversational pieces. In the future, you can place this type of info here [1]. When patches are applied from an email message, everything after the Subject line and before the '---' becomes the commit message.

I've also Cc'd this to stable for v3.6.x and newer.

thx,

Jason.