Skip to contentSkip to conversation

xf86-dri-vivante: Fix build with latest X server base

PATCH Superseded Gary Thomas 2 participants 4 messages Mar 19, 2013

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xf86-dri-vivante: Fix build with latest X server base

mibstore functions are no longer supported. This patch removes them from this driver.

---
 .../xf86-dri-vivante/remove-mibstore.patch         |   24 ++++++++++++++++++++
 .../xorg-driver/xf86-dri-vivante_12.09.01.bb       |    4 +++-
 2 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch
recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch new file +19 -0
new file mode 100644
index 0000000..1c48563
@@ -0,0 +1,24 @@
+Index: xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h
+===================================================================
+--- xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_util/vivante_common.h
++++ xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h
+@@ -48,7 +48,6 @@ extern "C" {
+ + + #include "mipointer.h"
+-#include "mibstore.h"
+ #include "micmap.h"
+ #include "mipointrst.h"
+ #include "inputstr.h"
+Index: xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c
+===================================================================
+--- xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_fbdev/vivante_fbdev_driver.c
++++ xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c
+@@ -746,7 +746,6 @@ VivScreenInit(SCREEN_INIT_ARGS_DECL) {
+ + +     xf86SetBlackWhitePixels(pScreen);
+-    miInitializeBackingStore(pScreen);
+     xf86SetBackingStore(pScreen);
+ +     pScrn->vtSema = TRUE;
recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb +3 -0
index acc5479..9f63fb8 100644
@@ -6,7 +6,9 @@ SECTION = "x11/base"
 DEPENDS = "virtual/libx11 util-macros xf86-video-imxfb-vivante"
 LIC_FILES_CHKSUM = "file://src/dri.h;enline=27;md5=79a9064e49ae41adca4827cd2281a014"
 -SRC_URI = "${FSL_MIRROR}/dri-xorg-graphic-imx-viv-${PV}.bin;fsl-eula=true"
+SRC_URI = "${FSL_MIRROR}/dri-xorg-graphic-imx-viv-${PV}.bin;fsl-eula=true \
+           file://remove-mibstore.patch \
+"
 SRC_URI[md5sum] = "8c90045cd5f4dba81095856634ba5136"
 SRC_URI[sha256sum] = "c844dc180e43901359bbdb4f797ab178b3821fbf63bdee9577e5a0afe5d7f6ad"
 -- 1.7.9.5
#1 lore raw
Quoted 36 lines · Gary Thomas

mibstore functions are no longer supported. This patch removes them from this driver.

---
 .../xf86-dri-vivante/remove-mibstore.patch         |   24
++++++++++++++++++++
 .../xorg-driver/xf86-dri-vivante_12.09.01.bb       |    4 +++-
 2 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644

recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch

diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch b/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch new file mode 100644
index 0000000..1c48563

recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch new file +1 -0
@@ -0,0 +1,24 @@
+Index:

xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h

+===================================================================
+---

xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_util/vivante_common.h ++++ xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h +@@ -48,7 +48,6 @@ extern "C" {
+ + + #include "mipointer.h"
+-#include "mibstore.h"
+ #include "micmap.h"
+ #include "mipointrst.h"
+ #include "inputstr.h"
+Index:
xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c

+===================================================================
+---
Quoted 8 lines

xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_fbdev/vivante_fbdev_driver.c
++++
xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c +@@ -746,7 +746,6 @@ VivScreenInit(SCREEN_INIT_ARGS_DECL) {
+ + + xf86SetBlackWhitePixels(pScreen);

+-    miInitializeBackingStore(pScreen);
+     xf86SetBackingStore(pScreen);
+ +     pScrn->vtSema = TRUE;

What the side effects of this change?

Quoted 23 lines
recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb +0 -0
index acc5479..9f63fb8 100644
@@ -6,7 +6,9 @@ SECTION = "x11/base"
 DEPENDS = "virtual/libx11 util-macros xf86-video-imxfb-vivante"
 LIC_FILES_CHKSUM =

"file://src/dri.h;enline=27;md5=79a9064e49ae41adca4827cd2281a014"
-SRC_URI = "${FSL_MIRROR}/dri-xorg-graphic-imx-viv-${PV}.bin;fsl-eula=true"

recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb +3 -0
+SRC_URI = "${FSL_MIRROR}/dri-xorg-graphic-imx-viv-${PV}.bin;fsl-eula=true \
+           file://remove-mibstore.patch \
+"
 SRC_URI[md5sum] = "8c90045cd5f4dba81095856634ba5136"
 SRC_URI[sha256sum] =

"c844dc180e43901359bbdb4f797ab178b3821fbf63bdee9577e5a0afe5d7f6ad"
-- 1.7.9.5

_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
#2 lore raw
Quoted 39 lines · Otavio Salvador
Quoted 38 lines · Gary Thomas

mibstore functions are no longer supported. This patch removes them from this driver.

---
  .../xf86-dri-vivante/remove-mibstore.patch         |   24
++++++++++++++++++++
  .../xorg-driver/xf86-dri-vivante_12.09.01.bb       |    4 +++-
  2 files changed, 27 insertions(+), 1 deletion(-)

create mode 100644
recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch

diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch b/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch new file mode 100644
index 0000000..1c48563

recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch new file +1 -0
@@ -0,0 +1,24 @@
+Index:

xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h

+===================================================================
+---

xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_util/vivante_common.h ++++ xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h +@@ -48,7 +48,6 @@ extern "C" {
+ + + #include "mipointer.h"
+-#include "mibstore.h"
+ #include "micmap.h"
+ #include "mipointrst.h"
+ #include "inputstr.h"
+Index:
xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c

+===================================================================
+---

xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_fbdev/vivante_fbdev_driver.c
++++

Quoted 8 lines
Quoted 6 lines

xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c +@@ -746,7 +746,6 @@ VivScreenInit(SCREEN_INIT_ARGS_DECL) {
+ + + xf86SetBlackWhitePixels(pScreen);

+-    miInitializeBackingStore(pScreen);
+     xf86SetBackingStore(pScreen);
+ +     pScrn->vtSema = TRUE;

What the side effects of this change?

Unknown, but it seems to work fine. I found this same change in other drivers in OE, e.g.
http://patches.openembedded.org/patch/46133/

This checkin shows when/where that file was deleted and mentions the reasons.
http://lists.x.org/archives/xorg-devel/2012-September/033575.html

Quoted 18 lines
Quoted 18 lines
recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb +0 -0
index acc5479..9f63fb8 100644
@@ -6,7 +6,9 @@ SECTION = "x11/base"
  DEPENDS = "virtual/libx11 util-macros xf86-video-imxfb-vivante"
  LIC_FILES_CHKSUM =

"file://src/dri.h;enline=27;md5=79a9064e49ae41adca4827cd2281a014"
-SRC_URI = "${FSL_MIRROR}/dri-xorg-graphic-imx-viv-${PV}.bin;fsl-eula=true"

recipes-graphics/xorg-driver/xf86-dri-vivante_12.09.01.bb +3 -0
+SRC_URI = "${FSL_MIRROR}/dri-xorg-graphic-imx-viv-${PV}.bin;fsl-eula=true \
+           file://remove-mibstore.patch \
+"
  SRC_URI[md5sum] = "8c90045cd5f4dba81095856634ba5136"
  SRC_URI[sha256sum] =

"c844dc180e43901359bbdb4f797ab178b3821fbf63bdee9577e5a0afe5d7f6ad"
-- 1.7.9.5

#3 lore raw
Quoted 59 lines · Gary Thomas
Quoted 47 lines · Otavio Salvador
Quoted 44 lines · Gary Thomas

mibstore functions are no longer supported. This patch removes them from this driver.

---
  .../xf86-dri-vivante/remove-mibstore.patch         |   24
++++++++++++++++++++
  .../xorg-driver/xf86-dri-vivante_12.09.01.bb       |    4 +++-
  2 files changed, 27 insertions(+), 1 deletion(-)

create mode 100644
recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch

diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch b/recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch new file mode 100644
index 0000000..1c48563

recipes-graphics/xorg-driver/xf86-dri-vivante/remove-mibstore.patch new file +1 -0
@@ -0,0 +1,24 @@
+Index:

xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h

+===================================================================
+---

xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_util/vivante_common.h
++++
xserver-xorg-video-imx-viv-12.09.01/src/vivante_util/vivante_common.h +@@ -48,7 +48,6 @@ extern "C" {
+ + + #include "mipointer.h"
+-#include "mibstore.h"
+ #include "micmap.h"
+ #include "mipointrst.h"
+ #include "inputstr.h"
+Index:

xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c

+===================================================================
+---

xserver-xorg-video-imx-viv-12.09.01.orig/src/vivante_fbdev/vivante_fbdev_driver.c
++++

Quoted 9 lines
Quoted 6 lines

xserver-xorg-video-imx-viv-12.09.01/src/vivante_fbdev/vivante_fbdev_driver.c +@@ -746,7 +746,6 @@ VivScreenInit(SCREEN_INIT_ARGS_DECL) {
+ + + xf86SetBlackWhitePixels(pScreen);

+-    miInitializeBackingStore(pScreen);
+     xf86SetBackingStore(pScreen);
+ +     pScrn->vtSema = TRUE;

What the side effects of this change?

Quoted 7 lines

Unknown, but it seems to work fine. I found this same change in other drivers in OE, e.g.
http://patches.openembedded.org/patch/46133/

This checkin shows when/where that file was deleted and mentions the reasons.
http://lists.x.org/archives/xorg-devel/2012-September/033575.html

So please put this information in the commit log.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br