USB-related build errors on Tegra in next-20130319

DISCUSSION Stephen Warren 4 participants 10 messages Mar 19, 2013 – Mar 20, 2013 4 messages not in the archive

Subsystems (5)

Arm (32-bit) USB Arm sub-architectures Linux-next tree +1 more subsystems

lore

Share & tools

lore

Stephen Warren

author

2013-03-19 16:29 UTC #0 lore raw

Felipe,

I see the following Kconfig warnings in next-20130319:

Quoted 5 lines

warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct dependencies (USB_SUPPORT && USB_PHY && ARM)
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI_VIEWPORT which has unmet direct dependencies (USB_SUPPORT && USB_PHY && USB_ULPI) include/config/auto.conf:624:warning: override: ARCH_MULTIPLATFORM changes choice state
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct dependencies (USB_SUPPORT && USB_PHY && ARM)
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI_VIEWPORT which has unmet direct dependencies (USB_SUPPORT && USB_PHY && USB_ULPI)

Which I believe are the cause of the following build errors:

Quoted 11 lines

drivers/built-in.o: In function `controller_resume':
drivers/usb/host/ehci-tegra.c:556: undefined reference to tegra_usb_phy_preresume' drivers/usb/host/ehci-tegra.c:479: undefined reference to tegra_ehci_phy_restore_start' drivers/usb/host/ehci-tegra.c:551: undefined reference to tegra_ehci_phy_restore_end' drivers/usb/host/ehci-tegra.c:546: undefined reference to tegra_ehci_phy_restore_end' drivers/built-in.o: In function `tegra_ehci_probe':
drivers/usb/host/ehci-tegra.c:734: undefined reference to tegra_usb_phy_open' drivers/built-in.o: In function tegra_ehci_hub_control':
drivers/usb/host/ehci-tegra.c:162: undefined reference to tegra_usb_phy_postresume' drivers/usb/host/ehci-tegra.c:215: undefined reference to tegra_usb_phy_preresume'
make: *** [vmlinux] Error 1

I pointed out at least the Kconfig problems when you posted the PHY error handling cleanup series, so I'm not sure why those patches were applied.

Felipe Balbi

2013-03-20 12:20 UTC #1 lore raw

Hi,

Quoted 22 lines · Stephen Warren

I see the following Kconfig warnings in next-20130319:
Quoted 5 lines
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct dependencies (USB_SUPPORT && USB_PHY && ARM)
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI_VIEWPORT which has unmet direct dependencies (USB_SUPPORT && USB_PHY && USB_ULPI) include/config/auto.conf:624:warning: override: ARCH_MULTIPLATFORM changes choice state
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct dependencies (USB_SUPPORT && USB_PHY && ARM)
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI_VIEWPORT which has unmet direct dependencies (USB_SUPPORT && USB_PHY && USB_ULPI)
Which I believe are the cause of the following build errors:
Quoted 11 lines
drivers/built-in.o: In function `controller_resume':
drivers/usb/host/ehci-tegra.c:556: undefined reference to tegra_usb_phy_preresume' drivers/usb/host/ehci-tegra.c:479: undefined reference to tegra_ehci_phy_restore_start' drivers/usb/host/ehci-tegra.c:551: undefined reference to tegra_ehci_phy_restore_end' drivers/usb/host/ehci-tegra.c:546: undefined reference to tegra_ehci_phy_restore_end' drivers/built-in.o: In function `tegra_ehci_probe':
drivers/usb/host/ehci-tegra.c:734: undefined reference to tegra_usb_phy_open' drivers/built-in.o: In function tegra_ehci_hub_control':
drivers/usb/host/ehci-tegra.c:162: undefined reference to tegra_usb_phy_postresume' drivers/usb/host/ehci-tegra.c:215: undefined reference to tegra_usb_phy_preresume'
make: *** [vmlinux] Error 1

Quoted 3 lines

I pointed out at least the Kconfig problems when you posted the PHY error handling cleanup series, so I'm not sure why those patches were applied.

Because tegra EHCI shouldn't be selecting the PHY and you didn't even have a proper PHY driver. Try patch below:

From cc705d4038f6adc24dc0d2ad9a1b28a798fafb95 Mon Sep 17 00:00:00 2001
From: Felipe Balbi <[email protected]>
Date: Wed, 20 Mar 2013 14:18:28 +0200
Subject: [PATCH] arm: tegra: fix Kconfig select clauses

USB_ULPI and USB_ULPI_VIEWPORT shouldn't really be selected directly by anyone, but since Tegra still needs some time before turning ulpi viewport into a proper PHY driver, we need to keep the selects in place.

This patch just fixes the conditional select
so that it will continue to build after merging
the latest PHY layer changes.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-tegra/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

arch/arm/mach-tegra/Kconfig +4 -4

index d1c4893..dbc653e 100644
@@ -18,8 +18,8 @@ config ARCH_TEGRA_2x_SOC
 	select PL310_ERRATA_727915 if CACHE_L2X0
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select USB_ARCH_HAS_EHCI if USB_SUPPORT
-	select USB_ULPI if USB
-	select USB_ULPI_VIEWPORT if USB_SUPPORT
+	select USB_ULPI if USB_PHY
+	select USB_ULPI_VIEWPORT if USB_PHY
 	help
 	  Support for NVIDIA Tegra AP20 and T20 processors, based on the
 	  ARM CortexA9MP CPU and the ARM PL310 L2 cache controller

@@ -37,8 +37,8 @@ config ARCH_TEGRA_3x_SOC
 	select PINCTRL_TEGRA30
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select USB_ARCH_HAS_EHCI if USB_SUPPORT
-	select USB_ULPI if USB
-	select USB_ULPI_VIEWPORT if USB_SUPPORT
+	select USB_ULPI if USB_PHY
+	select USB_ULPI_VIEWPORT if USB_PHY
 	help
 	  Support for NVIDIA Tegra T30 processor family, based on the
 	  ARM CortexA9MP CPU and the ARM PL310 L2 cache controller

Signature · 4 lines

1.8.2

-- 
balbi

A message that is not in the archive (sent off-list or not yet received): 20130320122031.GI29659-S8G//mZuvNWo5Im9Ml3/[email protected]

Stephen Warren

author

2013-03-20 16:39 UTC #3 lore raw

Quoted 35 lines · Felipe Balbi

Hi,
Quoted 32 lines · Stephen Warren
I see the following Kconfig warnings in next-20130319:
Quoted 4 lines
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct dependencies (USB_SUPPORT && USB_PHY && ARM) warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI_VIEWPORT which has unmet
Quoted 8 lines
direct dependencies (USB_SUPPORT && USB_PHY && USB_ULPI) include/config/auto.conf:624:warning: override:
ARCH_MULTIPLATFORM changes choice state warning:
(ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct dependencies (USB_SUPPORT && USB_PHY && ARM)
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI_VIEWPORT which has unmet direct dependencies (USB_SUPPORT && USB_PHY && USB_ULPI)
Which I believe are the cause of the following build errors:
Quoted 14 lines
drivers/built-in.o: In function `controller_resume':
drivers/usb/host/ehci-tegra.c:556: undefined reference to `tegra_usb_phy_preresume' drivers/usb/host/ehci-tegra.c:479:
undefined reference to tegra_ehci_phy_restore_start' drivers/usb/host/ehci-tegra.c:551: undefined reference to tegra_ehci_phy_restore_end' drivers/usb/host/ehci-tegra.c:546:
undefined reference to tegra_ehci_phy_restore_end' drivers/built-in.o: In function tegra_ehci_probe':
drivers/usb/host/ehci-tegra.c:734: undefined reference to tegra_usb_phy_open' drivers/built-in.o: In function tegra_ehci_hub_control': drivers/usb/host/ehci-tegra.c:162:
undefined reference to tegra_usb_phy_postresume' drivers/usb/host/ehci-tegra.c:215: undefined reference to tegra_usb_phy_preresume' make: *** [vmlinux] Error 1

Quoted 6 lines

Quoted 3 lines
I pointed out at least the Kconfig problems when you posted the PHY error handling cleanup series, so I'm not sure why those patches were applied.
Because tegra EHCI shouldn't be selecting the PHY and you didn't even have a proper PHY driver. Try patch below:

I understand that, but applying the patches without that resolved still seems wrong. Just because something is currently sub-optimal doesn't mean it should get broken.

The patch you gave fixes the Kconfig warnings, but not the build failure.

The issue is that: tegra_defconfig enables CONFIG_USB_EHCI_TEGRA, but not CONFIG_USB_PHY since it's new. ehci-tegra.c directly calls functions exported by phy-tegra-usb.c. However, phy-tegra-usb.c doesn't get built, since drivers/usb/Makefile adds phy/ to obj-$(CONFIG_USB_PHY), so doesn't end up "recursing" into the sub-directory at all. drivers/usb/phy/Makefile contains:
obj-$(CONFIG_USB_EHCI_TEGRA)+= phy-tegra-usb.o which used to couple the two builds together, in the absence of this new change that limits the building of phy/.

For now, I think the correct solution is to have USB_EHCI_TEGRA select USB_PHY. I validated that solves the build problem, and has the bonus of not needing any changes to tegra_defconfig.

In the series that converts phy-usb-tegra.c to a real driver, we can give it its own Kconfig option, and have USB_EHCI_TEGRA depend on that, if you want. We'll then also need to take a patch through the Tegra tree to update tegra_defconfig.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Felipe Balbi

2013-03-20 16:45 UTC #5 lore raw

Hi,

Quoted 59 lines · Stephen Warren

Quoted 35 lines · Felipe Balbi
Hi,
Quoted 32 lines · Stephen Warren
I see the following Kconfig warnings in next-20130319:
Quoted 4 lines
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct dependencies (USB_SUPPORT && USB_PHY && ARM) warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI_VIEWPORT which has unmet
Quoted 8 lines
direct dependencies (USB_SUPPORT && USB_PHY && USB_ULPI) include/config/auto.conf:624:warning: override:
ARCH_MULTIPLATFORM changes choice state warning:
(ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI which has unmet direct dependencies (USB_SUPPORT && USB_PHY && ARM)
warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC) selects USB_ULPI_VIEWPORT which has unmet direct dependencies (USB_SUPPORT && USB_PHY && USB_ULPI)
Which I believe are the cause of the following build errors:
Quoted 14 lines
drivers/built-in.o: In function `controller_resume':
drivers/usb/host/ehci-tegra.c:556: undefined reference to `tegra_usb_phy_preresume' drivers/usb/host/ehci-tegra.c:479:
undefined reference to tegra_ehci_phy_restore_start' drivers/usb/host/ehci-tegra.c:551: undefined reference to tegra_ehci_phy_restore_end' drivers/usb/host/ehci-tegra.c:546:
undefined reference to tegra_ehci_phy_restore_end' drivers/built-in.o: In function tegra_ehci_probe':
drivers/usb/host/ehci-tegra.c:734: undefined reference to tegra_usb_phy_open' drivers/built-in.o: In function tegra_ehci_hub_control': drivers/usb/host/ehci-tegra.c:162:
undefined reference to tegra_usb_phy_postresume' drivers/usb/host/ehci-tegra.c:215: undefined reference to tegra_usb_phy_preresume' make: *** [vmlinux] Error 1
Quoted 6 lines
Quoted 3 lines
I pointed out at least the Kconfig problems when you posted the PHY error handling cleanup series, so I'm not sure why those patches were applied.
Because tegra EHCI shouldn't be selecting the PHY and you didn't even have a proper PHY driver. Try patch below:
I understand that, but applying the patches without that resolved still seems wrong. Just because something is currently sub-optimal doesn't mean it should get broken.
The patch you gave fixes the Kconfig warnings, but not the build failure.
The issue is that: tegra_defconfig enables CONFIG_USB_EHCI_TEGRA, but not CONFIG_USB_PHY since it's new. ehci-tegra.c directly calls functions exported by phy-tegra-usb.c. However, phy-tegra-usb.c doesn't get built, since drivers/usb/Makefile adds phy/ to obj-$(CONFIG_USB_PHY), so doesn't end up "recursing" into the sub-directory at all. drivers/usb/phy/Makefile contains:
obj-$(CONFIG_USB_EHCI_TEGRA)+= phy-tegra-usb.o which used to couple the two builds together, in the absence of this new change that limits the building of phy/.

Quoted 8 lines

For now, I think the correct solution is to have USB_EHCI_TEGRA select USB_PHY. I validated that solves the build problem, and has the bonus of not needing any changes to tegra_defconfig.
In the series that converts phy-usb-tegra.c to a real driver, we can give it its own Kconfig option, and have USB_EHCI_TEGRA depend on that, if you want. We'll then also need to take a patch through the Tegra tree to update tegra_defconfig.

Alright, do you want to send that patch ? My bad that I missed that build error...

Signature · 1 line

balbi

A message that is not in the archive (sent off-list or not yet received): 20130320164553.GL1567-S8G//mZuvNWo5Im9Ml3/[email protected]

Stephen Warren

author

2013-03-20 16:51 UTC #7 lore raw

Quoted 4 lines · Felipe Balbi

Hi,
Quoted 1 line · Stephen Warren
On 03/20/2013 06:20 AM, Felipe Balbi wrote:

...

Quoted 2 lines

Quoted 2 lines
The patch you gave fixes the Kconfig warnings, but not the build failure.

...

Quoted 3 lines

Quoted 3 lines
For now, I think the correct solution is to have USB_EHCI_TEGRA select USB_PHY. I validated that solves the build problem, and has the bonus of not needing any changes to tegra_defconfig.

...

Quoted 2 lines

Alright, do you want to send that patch ? My bad that I missed that build error...

Sure. Do you want to roll it into your patch and repost it, or me to send a separate patch?

I assume you'd apply both to the same branch that contains the patches that add the USB_PHY config option? If the arch/arm patch gets applied to the Tegra tree instead, it'll cause breakage there since USB_PHY won't exist yet, so USB will be disabled until merged with the USB tree in 3.10-rc1.

Felipe Balbi

2013-03-20 17:11 UTC #8 lore raw

Hi,

Quoted 12 lines · Stephen Warren

Quoted 4 lines · Felipe Balbi
Hi,
Quoted 1 line · Stephen Warren
On 03/20/2013 06:20 AM, Felipe Balbi wrote:
...
Quoted 2 lines
Quoted 2 lines
The patch you gave fixes the Kconfig warnings, but not the build failure.
...
Quoted 3 lines
Quoted 3 lines
For now, I think the correct solution is to have USB_EHCI_TEGRA select USB_PHY. I validated that solves the build problem, and has the bonus of not needing any changes to tegra_defconfig.

Quoted 6 lines

...
Quoted 2 lines
Alright, do you want to send that patch ? My bad that I missed that build error...
Sure. Do you want to roll it into your patch and repost it, or me to send a separate patch?

updated patch below:

From c2b3334a624e4231952ab050e29445b8c62f662d Mon Sep 17 00:00:00 2001
From: Felipe Balbi <[email protected]>
Date: Wed, 20 Mar 2013 14:18:28 +0200
Subject: [PATCH] arm: tegra: fix Kconfig select clauses

This patch just fixes the conditional select
so that it will continue to build after merging
the latest PHY layer changes.

Signed-off-by Felipe Balbi <[email protected]>

---
 arch/arm/mach-tegra/Kconfig | 8 ++++----
 drivers/usb/host/Kconfig    | 1 +
 2 files changed, 5 insertions(+), 4 deletions(-)

arch/arm/mach-tegra/Kconfig +4 -4

index d1c4893..dbc653e 100644
@@ -18,8 +18,8 @@ config ARCH_TEGRA_2x_SOC
 	select PL310_ERRATA_727915 if CACHE_L2X0
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select USB_ARCH_HAS_EHCI if USB_SUPPORT
-	select USB_ULPI if USB
-	select USB_ULPI_VIEWPORT if USB_SUPPORT
+	select USB_ULPI if USB_PHY
+	select USB_ULPI_VIEWPORT if USB_PHY
 	help
 	  Support for NVIDIA Tegra AP20 and T20 processors, based on the
 	  ARM CortexA9MP CPU and the ARM PL310 L2 cache controller

@@ -37,8 +37,8 @@ config ARCH_TEGRA_3x_SOC
 	select PINCTRL_TEGRA30
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select USB_ARCH_HAS_EHCI if USB_SUPPORT
-	select USB_ULPI if USB
-	select USB_ULPI_VIEWPORT if USB_SUPPORT
+	select USB_ULPI if USB_PHY
+	select USB_ULPI_VIEWPORT if USB_PHY
 	help
 	  Support for NVIDIA Tegra T30 processor family, based on the
 	  ARM CortexA9MP CPU and the ARM PL310 L2 cache controller

drivers/usb/host/Kconfig +1 -0

index ba1347c..1b58587 100644
@@ -179,6 +179,7 @@ config USB_EHCI_TEGRA
        boolean "NVIDIA Tegra HCD support"
        depends on USB_EHCI_HCD && ARCH_TEGRA
        select USB_EHCI_ROOT_HUB_TT
+       select USB_PHY
        help
          This driver enables support for the internal USB Host Controllers
          found in NVIDIA Tegra SoCs. The controllers are EHCI compliant.

Signature · 9 lines

1.8.2

Another possibility would be to:

select USB_PHY if USB
select USB_ULPI
select USB_ULPI_VIEWPORT

Would you prefer that one instead ?

Quoted 5 lines

I assume you'd apply both to the same branch that contains the patches that add the USB_PHY config option? If the arch/arm patch gets applied to the Tegra tree instead, it'll cause breakage there since USB_PHY won't exist yet, so USB will be disabled until merged with the USB tree in 3.10-rc1.

alright, but I need your Acked-by to the updated patch. I have now compiled it with tegra_defconfig (is that the one which should be used?) and it's compiling fine without any issues.

Signature · 1 line

balbi

Stephen Warren

Acked-by Tested-by

2013-03-20 17:26 UTC #9 lore raw

Quoted 23 lines · Felipe Balbi

Hi,
Quoted 20 lines · Stephen Warren
Quoted 5 lines · Felipe Balbi
Hi,
Quoted 1 line · Stephen Warren
On 03/20/2013 06:20 AM, Felipe Balbi wrote:
...
Quoted 2 lines
Quoted 2 lines
The patch you gave fixes the Kconfig warnings, but not the build failure.
...
Quoted 4 lines
Quoted 4 lines
For now, I think the correct solution is to have USB_EHCI_TEGRA select USB_PHY. I validated that solves the build problem, and has the bonus of not needing any changes to tegra_defconfig.
...
Quoted 2 lines
Alright, do you want to send that patch ? My bad that I missed that build error...
Sure. Do you want to roll it into your patch and repost it, or me to send a separate patch?

Oops, sorry, I meant to write "Do you want *me* to" ...

Quoted 1 line

updated patch below:

Anyway, the updated patch you sent does solve the problem, so:

Acked-by Stephen Warren <[email protected]>

Tested-by Stephen Warren <[email protected]>

(both build and ran it on HW to make sure nothing was missing)

Feel free to use yours or the separate one I sent; entirely your call.

A message that is not in the archive (sent off-list or not yet received): [email protected]

Felipe Balbi

2013-03-20 17:30 UTC #11 lore raw

Quoted 29 lines · Stephen Warren

Quoted 23 lines · Felipe Balbi
Hi,
Quoted 20 lines · Stephen Warren
Quoted 5 lines · Felipe Balbi
Hi,
Quoted 1 line · Stephen Warren
On 03/20/2013 06:20 AM, Felipe Balbi wrote:
...
Quoted 2 lines
Quoted 2 lines
The patch you gave fixes the Kconfig warnings, but not the build failure.
...
Quoted 4 lines
Quoted 4 lines
For now, I think the correct solution is to have USB_EHCI_TEGRA select USB_PHY. I validated that solves the build problem, and has the bonus of not needing any changes to tegra_defconfig.
...
Quoted 2 lines
Alright, do you want to send that patch ? My bad that I missed that build error...
Sure. Do you want to roll it into your patch and repost it, or me to send a separate patch?
Oops, sorry, I meant to write "Do you want *me* to" ...
Quoted 1 line
updated patch below:

Quoted 7 lines

Anyway, the updated patch you sent does solve the problem, so:
Acked-by Stephen Warren <[email protected]>
Tested-by Stephen Warren <[email protected]>
(both build and ran it on HW to make sure nothing was missing)
Feel free to use yours or the separate one I sent; entirely your call.

I wonder if the third option isn't nicer ?

select USB_PHY if USB
select USB_ULPI
select USB_ULPI_VIEWPORT

then all changes are in tegra's Kconfig itself ?

Signature · 1 line

balbi

Stephen Warren

2013-03-20 17:42 UTC #12 lore raw

Quoted 37 lines · Felipe Balbi

Quoted 36 lines · Stephen Warren
Quoted 24 lines · Felipe Balbi
Hi,
Quoted 20 lines · Stephen Warren
Quoted 5 lines · Felipe Balbi
Hi,
Quoted 1 line · Stephen Warren
On 03/20/2013 06:20 AM, Felipe Balbi wrote:
...
Quoted 2 lines
Quoted 2 lines
The patch you gave fixes the Kconfig warnings, but not the build failure.
...
Quoted 4 lines
Quoted 4 lines
For now, I think the correct solution is to have USB_EHCI_TEGRA select USB_PHY. I validated that solves the build problem, and has the bonus of not needing any changes to tegra_defconfig.
...
Quoted 2 lines
Alright, do you want to send that patch ? My bad that I missed that build error...
Sure. Do you want to roll it into your patch and repost it, or me to send a separate patch?
Oops, sorry, I meant to write "Do you want *me* to" ...
Quoted 1 line
updated patch below:
Anyway, the updated patch you sent does solve the problem, so:
Acked-by Stephen Warren <[email protected]> Tested-by: Stephen
Warren <[email protected]> (both build and ran it on HW to make sure nothing was missing)

Quoted 8 lines

Quoted 2 lines
Feel free to use yours or the separate one I sent; entirely your call.
I wonder if the third option isn't nicer ?
select USB_PHY if USB select USB_ULPI select USB_ULPI_VIEWPORT
then all changes are in tegra's Kconfig itself ?

I imagine that'd work although I didn't try it. However, I suspect it's more correct to have USB_EHCI_TEGRA do the select (or later, do a depend), since that's the option which actually has the dependency. Otherwise, you're just making USB_EHCI_TEGRA's dependencies work via selects in some other pretty unrelated node.

Felipe Balbi

2013-03-20 17:56 UTC #13 lore raw

Hi,

Quoted 45 lines · Stephen Warren

Quoted 44 lines · Felipe Balbi
Quoted 30 lines · Stephen Warren
Quoted 24 lines · Felipe Balbi
Hi,
Quoted 20 lines · Stephen Warren
Quoted 5 lines · Felipe Balbi
Hi,
Quoted 1 line · Stephen Warren
On 03/20/2013 06:20 AM, Felipe Balbi wrote:
...
Quoted 2 lines
Quoted 2 lines
The patch you gave fixes the Kconfig warnings, but not the build failure.
...
Quoted 4 lines
Quoted 4 lines
For now, I think the correct solution is to have USB_EHCI_TEGRA select USB_PHY. I validated that solves the build problem, and has the bonus of not needing any changes to tegra_defconfig.
...
Quoted 2 lines
Alright, do you want to send that patch ? My bad that I missed that build error...
Sure. Do you want to roll it into your patch and repost it, or me to send a separate patch?
Oops, sorry, I meant to write "Do you want *me* to" ...
Quoted 1 line
updated patch below:
Quoted 8 lines
Anyway, the updated patch you sent does solve the problem, so:
Acked-by Stephen Warren <[email protected]> Tested-by: Stephen
Warren <[email protected]> (both build and ran it on HW to make sure nothing was missing)
Feel free to use yours or the separate one I sent; entirely your call.
I wonder if the third option isn't nicer ?
select USB_PHY if USB select USB_ULPI select USB_ULPI_VIEWPORT

Quoted 7 lines

Quoted 1 line
then all changes are in tegra's Kconfig itself ?
I imagine that'd work although I didn't try it. However, I suspect it's more correct to have USB_EHCI_TEGRA do the select (or later, do a depend), since that's the option which actually has the dependency. Otherwise, you're just making USB_EHCI_TEGRA's dependencies work via selects in some other pretty unrelated node.

alright, let's keep it your way, I'll add your Acked-by and Tested-by tags and push the patch to my 'next' branch, should show up in linux-next tomorrow.

Signature · 1 line

balbi