Skip to contentSkip to conversation

pci-versatile.c: Update for API change in list_for_each_entry()

PATCH In review Arnd Bergmann 4 participants 5 messages Feb 25, 2015 – Feb 27, 2015 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pci-versatile.c: Update for API change in list_for_each_entry()

From: Joachim Nilsson <[email protected]>

In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what appears to be an API update. This patch is a very simple correction, merely posted as a heads-up to the maintainers. Hopefully a better fix can be forwarded to Linus.

[arnd: the patch actually looks correct, so let's take this version]

---

Joachim reported the bug, and I independently found the same problem. The patch he sent to the list did not apply for me for an unknown reason, but I fixed it up and forward it now to the right list of recipients.

drivers/pci/host/pci-versatile.c +1 -1
index 1ec694a52379..464bf492ee2a 100644
@@ -80,7 +80,7 @@ static int versatile_pci_parse_request_of_pci_ranges(struct device *dev,
 	if (err)
 		return err;
 
-	resource_list_for_each_entry(win, res, list) {
+	resource_list_for_each_entry(win, res) {
 		struct resource *parent, *res = win->res;
 
 		switch (resource_type(res)) {
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Arnd Bergmann

From: Joachim Nilsson <[email protected]>

In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what appears to be an API update. This patch is a very simple correction, merely posted as a heads-up to the maintainers. Hopefully a better fix can be forwarded to Linus.

[arnd: the patch actually looks correct, so let's take this version]

Quoted 7 lines

---

Joachim reported the bug, and I independently found the same problem. The patch he sent to the list did not apply for me for an unknown reason, but I fixed it up and forward it now to the right list of recipients.

Yours,
Linus Walleij

#2 lore raw
Quoted 15 lines · Linus Walleij
Quoted 13 lines · Arnd Bergmann

From: Joachim Nilsson <[email protected]>

In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what appears to be an API update. This patch is a very simple correction, merely posted as a heads-up to the maintainers. Hopefully a better fix can be forwarded to Linus.

[arnd: the patch actually looks correct, so let's take this version]

---

Quoted 5 lines
Quoted 3 lines

Joachim reported the bug, and I independently found the same problem. The patch he sent to the list did not apply for me for an unknown reason, but I fixed it up and forward it now to the right list of recipients.

Do I need to take this one? Bjorn?

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
maintainer Acked-by Linus Walleij Acked-by
#3 lore raw
Quoted 16 lines · Rafael J. Wysocki
Quoted 15 lines · Linus Walleij
Quoted 13 lines · Arnd Bergmann

From: Joachim Nilsson <[email protected]>

In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what appears to be an API update. This patch is a very simple correction, merely posted as a heads-up to the maintainers. Hopefully a better fix can be forwarded to Linus.

[arnd: the patch actually looks correct, so let's take this version]

---

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Joachim reported the bug, and I independently found the same problem. The patch he sent to the list did not apply for me for an unknown reason, but I fixed it up and forward it now to the right list of recipients.

Do I need to take this one? Bjorn?

Yeah, if you don't mind, why don't you take it, Rafael. I think it was introduced by 872912352c5b ("Merge tag 'pm+acpi-3.20-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm"). I don't really understand that commit, but it looks like this part of it is the problem:

- list_for_each_entry(win, res, list) {
++ resource_list_for_each_entry(win, res, list) {

If you do, would you mind updating the subject line and adding these acks?

PCI: versatile: Update for list_for_each_entry() API change

Bjorn

#4 lore raw
Quoted 34 lines · Bjorn Helgaas
Quoted 16 lines · Rafael J. Wysocki
Quoted 15 lines · Linus Walleij
Quoted 13 lines · Arnd Bergmann

From: Joachim Nilsson <[email protected]>

In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what appears to be an API update. This patch is a very simple correction, merely posted as a heads-up to the maintainers. Hopefully a better fix can be forwarded to Linus.

[arnd: the patch actually looks correct, so let's take this version]

---

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Joachim reported the bug, and I independently found the same problem. The patch he sent to the list did not apply for me for an unknown reason, but I fixed it up and forward it now to the right list of recipients.

Do I need to take this one? Bjorn?

Yeah, if you don't mind, why don't you take it, Rafael. I think it was introduced by 872912352c5b ("Merge tag 'pm+acpi-3.20-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm"). I don't really understand that commit, but it looks like this part of it is the problem:

- list_for_each_entry(win, res, list) {
++ resource_list_for_each_entry(win, res, list) {

Quoted 6 lines

If you do, would you mind updating the subject line and adding these acks?

PCI: versatile: Update for list_for_each_entry() API change

Done.

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.