drivers/block/drbd: remove erroneous semicolon

PATCH In review Chen Gang 2 participants 6 messages Mar 27, 2013 – Apr 10, 2013

Subsystems (2)

Block layer DRBD driver

lore

Share & tools

lore

Chen Gang

author

2013-03-27 06:56 UTC #0 lore raw

PATCH 1/1 drivers/block/drbd: remove erroneous semicolon

need remove it, or always return -EBUSY.
it is found by compiler with 'EXTRA_CFLAG=-W'.

Signed-off-by Chen Gang <[email protected]>

---
 drivers/block/drbd/drbd_actlog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/block/drbd/drbd_actlog.c +1 -1

index 6afe173..6608076 100644
@@ -389,7 +389,7 @@ int drbd_al_begin_io_nonblock(struct drbd_conf *mdev, struct drbd_interval *i)
 		if (unlikely(tmp != NULL)) {
 			struct bm_extent  *bm_ext = lc_entry(tmp, struct bm_extent, lce);
 			if (test_bit(BME_NO_WRITES, &bm_ext->flags)) {
-				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags));
+				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags))
 					return -EBUSY;
 				return -EWOULDBLOCK;
 			}

Signature · 1 line

1.7.7.6

Chen Gang

author

2013-04-03 08:01 UTC #1 lore raw

Hello maintainers:

when you have time, please help to check this patch whether is OK.

thanks.

gchen.

Quoted 23 lines · Chen Gang

need remove it, or always return -EBUSY.
it is found by compiler with 'EXTRA_CFLAG=-W'.

Signed-off-by Chen Gang <[email protected]>

---
 drivers/block/drbd/drbd_actlog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/block/drbd/drbd_actlog.c +1 -1

index 6afe173..6608076 100644
@@ -389,7 +389,7 @@ int drbd_al_begin_io_nonblock(struct drbd_conf *mdev, struct drbd_interval *i)
 		if (unlikely(tmp != NULL)) {
 			struct bm_extent  *bm_ext = lc_entry(tmp, struct bm_extent, lce);
 			if (test_bit(BME_NO_WRITES, &bm_ext->flags)) {
-				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags));
+				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags))
 					return -EBUSY;
 				return -EWOULDBLOCK;
 			}

Signature · 3 lines

Chen Gang

Asianux Corporation

Lars Ellenberg

maintainer

2013-04-08 20:45 UTC #2 lore raw

Quoted 5 lines · Chen Gang

Hello maintainers:
when you have time, please help to check this patch whether is OK.
thanks.

Thanks.

It has already been queued in:
http://git.kernel.dk/?p=linux-block.git;a=commit;h=0b6ef4164f50698eee536903d69d086add1a7889

Quoted 24 lines · Chen Gang

Quoted 23 lines

need remove it, or always return -EBUSY.
it is found by compiler with 'EXTRA_CFLAG=-W'.

Signed-off-by Chen Gang <[email protected]>

---
 drivers/block/drbd/drbd_actlog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/block/drbd/drbd_actlog.c +1 -1

index 6afe173..6608076 100644
@@ -389,7 +389,7 @@ int drbd_al_begin_io_nonblock(struct drbd_conf *mdev, struct drbd_interval *i)
 		if (unlikely(tmp != NULL)) {
 			struct bm_extent  *bm_ext = lc_entry(tmp, struct bm_extent, lce);
 			if (test_bit(BME_NO_WRITES, &bm_ext->flags)) {
-				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags));
+				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags))
 					return -EBUSY;
 				return -EWOULDBLOCK;
 			}

Chen Gang

author

2013-04-09 01:23 UTC #3 lore raw

Quoted 11 lines · Lars Ellenberg

Quoted 5 lines · Chen Gang
Quoted 5 lines
Hello maintainers:
when you have time, please help to check this patch whether is OK.
thanks.
Thanks.
It has already been queued in:
http://git.kernel.dk/?p=linux-block.git;a=commit;h=0b6ef4164f50698eee536903d69d086add1a7889

ok thanks.

it seems I am a little earlier than the link's patch.

    I found it on Wed 27 Mar 2013 14:56
    link's patch found it on Wed 27 Mar 2013 21:08

;-)

but that's all right, it doesn't matter.

thanks.

:-)

gchen.

Quoted 25 lines

Quoted 24 lines

Quoted 24 lines · Chen Gang

Quoted 23 lines

need remove it, or always return -EBUSY.
it is found by compiler with 'EXTRA_CFLAG=-W'.

Signed-off-by Chen Gang <[email protected]>

---
 drivers/block/drbd/drbd_actlog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/block/drbd/drbd_actlog.c +1 -1

index 6afe173..6608076 100644
@@ -389,7 +389,7 @@ int drbd_al_begin_io_nonblock(struct drbd_conf *mdev, struct drbd_interval *i)
 		if (unlikely(tmp != NULL)) {
 			struct bm_extent  *bm_ext = lc_entry(tmp, struct bm_extent, lce);
 			if (test_bit(BME_NO_WRITES, &bm_ext->flags)) {
-				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags));
+				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags))
 					return -EBUSY;
 				return -EWOULDBLOCK;
 			}

Signature · 3 lines

Chen Gang

Asianux Corporation

Lars Ellenberg

maintainer

2013-04-09 15:56 UTC #4 lore raw

Quoted 13 lines · Chen Gang

Quoted 11 lines · Lars Ellenberg
Quoted 5 lines · Chen Gang
Quoted 5 lines
Hello maintainers:
when you have time, please help to check this patch whether is OK.
thanks.
Thanks.
It has already been queued in:
http://git.kernel.dk/?p=linux-block.git;a=commit;h=0b6ef4164f50698eee536903d69d086add1a7889

Quoted 6 lines

ok thanks.
it seems I am a little earlier than the link's patch.
    I found it on Wed 27 Mar 2013 14:56
    link's patch found it on Wed 27 Mar 2013 21:08

The original report (by kbuild test robot) is from the week before iirc (don't have it anymore), the original commit in our drbd repo the day before.

But:

Quoted 5 lines

;-)
but that's all right, it doesn't matter.
thanks.

;-)

Chen Gang

author

2013-04-10 04:01 UTC #5 lore raw

Quoted 2 lines · Lars Ellenberg

The original report (by kbuild test robot) is from the week before iirc (don't have it anymore), the original commit in our drbd repo the day before.

really it is !!

thanks.

:-)

Signature · 3 lines

Chen Gang

Asianux Corporation