sysfs: Add crash_notes_size to export percpu note size
Subsystems (3)
PATCH 2/2 Documentation: Add ABI entry for crash_notes and crash_notes_size
In reply to Zhang YanfeiAdd an Documentation/ABI entry for /sys/devices/system/cpu/cpu0/crash_notes and /sys/devices/system/cpu/cpu0/crash_notes_size.
--- Documentation/ABI/testing/sysfs-devices-system-cpu | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)
Documentation/ABI/testing/sysfs-devices-system-cpu +12 -0
@@ -173,3 +173,15 @@ Description: Processor frequency boosting control Boosting allows the CPU and the firmware to run at a frequency beyound it's nominal limit. More details can be found in Documentation/cpu-freq/boost.txt + + +What: /sys/devices/system/cpu/cpu#/crash_notes + /sys/devices/system/cpu/cpu#/crash_notes_size +Date: April 2013 +Contact: [email protected] +Description: address and size of the percpu note. + + crash_notes: the physical address of the memory that holds the + note of cpu#. + + crash_notes_size: size of the note of cpu#.
Signature · 1 line
1.7.1
PATCH 1/2 sysfs: Add crash_notes_size to export percpu note size
For percpu notes, we are exporting only address and not size. So the userspace tool kexec-tools is putting an upper limit of 1024 and putting the value in p_memsz and p_filesz fields. So the patch add the new sysfile crash_notes_size to export the exact percpu note size and let the kexec-tools parse it intead of using 1024.
The idea came from Vivek Goyal. And a later patch will be sent to kexec-tools to let it parse the size.
--- drivers/base/cpu.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)
drivers/base/cpu.c +14 -0
@@ -132,6 +132,17 @@ static ssize_t show_crash_notes(struct device *dev, struct device_attribute *attreturn rc; } static DEVICE_ATTR(crash_notes, 0400, show_crash_notes, NULL); + +static ssize_t show_crash_notes_size (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +ssize_t rc; + + rc =sprintf (buf,"%lu\n" ,sizeof (note_buf_t)); +return rc; +} +static DEVICE_ATTR(crash_notes_size, 0400, show_crash_notes_size, NULL);#endif /*
@@ -259,6 +270,9 @@ int __cpuinit register_cpu(struct cpu *cpu, int num)#ifdef CONFIG_KEXEC if (!error) error =device_create_file (&cpu->dev, &dev_attr_crash_notes); +if (!error) + error =device_create_file (&cpu->dev, + &dev_attr_crash_notes_size);#endif return error; }
Signature · 6 lines
1.7.1 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Hi, simon
I forgot to add your email in the CC, could you please help reviewing this patch since I will send the kexec-tools patch if this patch is accepted.
Thanks
Zhang
Quoted 49 lines · Zhang Yanfei
For percpu notes, we are exporting only address and not size. So the userspace tool kexec-tools is putting an upper limit of 1024 and putting the value in
p_memszandp_fileszfields. So the patch add the new sysfilecrash_notes_sizeto export the exact percpu note size and let the kexec-tools parse it intead of using 1024.The idea came from Vivek Goyal. And a later patch will be sent to kexec-tools to let it parse the size.
Cc Greg KH <[email protected]>Cc "Eric W. Biederman" <[email protected]>Cc Vivek Goyal <[email protected]>Signed-off-by Zhang Yanfei <[email protected]>--- drivers/base/cpu.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)drivers/base/cpu.c +14
-0@@ -132,6 +132,17 @@ static ssize_t show_crash_notes(struct device *dev, struct device_attribute *attreturn rc; } static DEVICE_ATTR(crash_notes, 0400, show_crash_notes, NULL); + +static ssize_t show_crash_notes_size (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +ssize_t rc; + + rc =sprintf (buf,"%lu\n" ,sizeof (note_buf_t)); +return rc; +} +static DEVICE_ATTR(crash_notes_size, 0400, show_crash_notes_size, NULL);#endif /* @@ -259,6 +270,9 @@ int __cpuinit register_cpu(struct cpu *cpu, int num)#ifdef CONFIG_KEXEC if (!error) error =device_create_file (&cpu->dev, &dev_attr_crash_notes); +if (!error) + error =device_create_file (&cpu->dev, + &dev_attr_crash_notes_size);#endif return error; }
Simon Horman
Acked-byQuoted 18 lines · Zhang Yanfei
Hi, simon
I forgot to add your email in the CC, could you please help reviewing this patch since I will send the kexec-tools patch if this patch is accepted.
Thanks
ZhangQuoted 8 lines · Zhang Yanfei
For percpu notes, we are exporting only address and not size. So the userspace tool kexec-tools is putting an upper limit of 1024 and putting the value in
p_memszandp_fileszfields. So the patch add the new sysfilecrash_notes_sizeto export the exact percpu note size and let the kexec-tools parse it intead of using 1024.The idea came from Vivek Goyal. And a later patch will be sent to kexec-tools to let it parse the size.
Quoted 43 lines
Quoted 41 lines
Cc Greg KH <[email protected]>Cc "Eric W. Biederman" <[email protected]>Cc Vivek Goyal <[email protected]>Signed-off-by Zhang Yanfei <[email protected]>--- drivers/base/cpu.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-)drivers/base/cpu.c +14
-0@@ -132,6 +132,17 @@ static ssize_t show_crash_notes(struct device *dev, struct device_attribute *attreturn rc; } static DEVICE_ATTR(crash_notes, 0400, show_crash_notes, NULL); + +static ssize_t show_crash_notes_size (struct device *dev, +struct device_attribute *attr, +char *buf) +{ +ssize_t rc; + + rc =sprintf (buf,"%lu\n" ,sizeof (note_buf_t)); +return rc; +} +static DEVICE_ATTR(crash_notes_size, 0400, show_crash_notes_size, NULL);#endif /* @@ -259,6 +270,9 @@ int __cpuinit register_cpu(struct cpu *cpu, int num)#ifdef CONFIG_KEXEC if (!error) error =device_create_file (&cpu->dev, &dev_attr_crash_notes); +if (!error) + error =device_create_file (&cpu->dev, + &dev_attr_crash_notes_size);#endif return error; }
Re: [PATCH 2/2] Documentation: Add ABI entry for crash_notes and crash_notes_size
In reply to Zhang YanfeiQuoted 7 lines · Zhang Yanfei
Add an
Documentation/ABIentry for/sys/devices/system/cpu/cpu0/crash_notesand/sys/devices/system/cpu/cpu0/crash_notes_size.Cc Greg KH <[email protected]>Cc "Eric W. Biederman" <[email protected]>Cc Vivek Goyal <[email protected]>Signed-off-by Zhang Yanfei <[email protected]>
Assuming that patch 1 of this series is accepted:
Quoted 33 lines
--- Documentation/ABI/testing/sysfs-devices-system-cpu | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)Documentation/ABI/testing/sysfs-devices-system-cpu +12
-0@@ -173,3 +173,15 @@ Description: Processor frequency boosting control Boosting allows the CPU and the firmware to run at a frequency beyound it's nominal limit. More details can be found in Documentation/cpu-freq/boost.txt + + +What: /sys/devices/system/cpu/cpu#/crash_notes + /sys/devices/system/cpu/cpu#/crash_notes_size +Date: April 2013 +Contact: [email protected] +Description: address and size of the percpu note. + + crash_notes: the physical address of the memory that holds the + note of cpu#. + + crash_notes_size: size of the note of cpu#.Signature · 7 lines
1.7.1 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec