On git and mail requests
I know some projects use separate dev and user mailing lists. Perhaps we could follow this route.
Jérémie
Quoted 17 lines · Matthew Khouzam
Hello tracing sorcerers,
I was having a harder and harder time reading the mailing list's discussions. I have a filter to hide "patches" in my mail client. I think though it would be interesting maybe to use redmine's code review system and keep the mailing list for support? That way we can see the user issues more easily?
Any thoughts?
Matthew_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Signature · 3 lines
Jérémie Galarneau EfficiOS Inc. http://www.efficios.com
I don't think we have enough traffic to justify 2 mailing list.
Yannick
Quoted 26 lines · Jérémie Galarneau
I know some projects use separate dev and user mailing lists. Perhaps we could follow this route.
Jérémie
Quoted 17 lines · Matthew Khouzam
Hello tracing sorcerers,
I was having a harder and harder time reading the mailing list's discussions. I have a filter to hide "patches" in my mail client. I think though it would be interesting maybe to use redmine's code review system and keep the mailing list for support? That way we can see the user issues more easily?
Any thoughts?
Matthew_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
So to conclude from the discussion on IRC. It is being considered but redmine's code review system is not good enough yet.
Glad it was thought out.
btw, if anyone else is having the issue, filter on the word "PATCH" in the header, the mailing list becomes much cleaner. :)
Quoted 35 lines · Yannick Brosseau
I don't think we have enough traffic to justify 2 mailing list.
Yannick
Quoted 25 lines · Jérémie Galarneau
I know some projects use separate dev and user mailing lists. Perhaps we could follow this route.
Jérémie
Quoted 17 lines · Matthew Khouzam
Hello tracing sorcerers,
I was having a harder and harder time reading the mailing list's discussions. I have a filter to hide "patches" in my mail client. I think though it would be interesting maybe to use redmine's code review system and keep the mailing list for support? That way we can see the user issues more easily?
Any thoughts?
Matthew_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
I think the point is that having patches in emails is not very convenient. Given the quality of web based tools available today, I think it would be relevant that the LTTng project adopt one of them.
With the current system:
- it is hard to see what the resulting code is. You juste have a blob of + and -, and it is very hard to see what the code looks in the end. Web based code review tools allow you to quickly see the modifications as part of the complete file, with nice colors and other visual aids.
- It is hard to follow the sequence of comments. With a web based tool, all discussions related to a topic are clearly laid out.
- It is hard to follow the evolution of a patch (differences between patch versions)
- Sometimes patches on the list fall into cracks and are never replied to.
Code review has proven to be very useful to maintain code quality and avoid bugs. It might be only me, but the current system doesn't encourage me to go look at other people's code and comment, because it is hard to do so.
Simon
Quoted 36 lines · Jérémie Galarneau
I know some projects use separate dev and user mailing lists. Perhaps we could follow this route.
Jérémie
Quoted 13 lines · Matthew Khouzam
Hello tracing sorcerers,
I was having a harder and harder time reading the mailing list's discussions. I have a filter to hide "patches" in my mail client. I think though it would be interesting maybe to use redmine's code review system and keep the mailing list for support? That way we can see the user issues more easily?
Any thoughts?
MatthewQuoted 4 lines
_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Quoted 4 lines · Simon Marchi
I think the point is that having patches in emails is not very convenient. Given the quality of web based tools available today, I think it would be relevant that the LTTng project adopt one of them.
Quoted 13 lines
With the current system:
- it is hard to see what the resulting code is. You juste have a blob of + and -, and it is very hard to see what the code looks in the end. Web based code review tools allow you to quickly see the modifications as part of the complete file, with nice colors and other visual aids.
- It is hard to follow the sequence of comments. With a web based tool, all discussions related to a topic are clearly laid out.
- It is hard to follow the evolution of a patch (differences between patch versions)
- Sometimes patches on the list fall into cracks and are never replied to.
Is there any of the available code review tools that can work offline?
Not that I know. But for example, with Gerrit, you could probably fetch all the changesets you were asked to review to your git tree before boarding your plane to Australia and at least read them. You would still have to enter your comments when you get back online.
Do you happen to work offline often ? Is this really important ?
Quoted 24 lines · Yannick Brosseau
Quoted 4 lines · Simon Marchi
I think the point is that having patches in emails is not very convenient. Given the quality of web based tools available today, I think it would be relevant that the LTTng project adopt one of them.
Quoted 13 lines
With the current system:
- it is hard to see what the resulting code is. You juste have a blob of + and -, and it is very hard to see what the code looks in the end. Web based code review tools allow you to quickly see the modifications as part of the complete file, with nice colors and other visual aids.
- It is hard to follow the sequence of comments. With a web based tool, all discussions related to a topic are clearly laid out.
- It is hard to follow the evolution of a patch (differences between patch versions)
- Sometimes patches on the list fall into cracks and are never replied to.Is there any of the available code review tools that can work offline?
_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
2013/3/28 Simon Marchi <[email protected]>
Quoted 7 lines
Not that I know. But for example, with Gerrit, you could probably fetch all the changesets you were asked to review to your git tree before boarding your plane to Australia and at least read them. You would still have to enter your comments when you get back online.
Do you happen to work offline often ? Is this really important ?
For what it's worth, I like the current e-mail based patching system. Using another tool would just conduct me to have to :
1/ Follow online if there isn't any way to get the information by email 2/ Subscribe to the "send me all the info by email" if it exists 3/ Have to connect (and login?) to the website to answer if necessary, so taking more time to do it than now if there isn't any "reply directly by email" system
4/ Answer by email if it's possible
So, in the best situation, I'll do exactly as I do right now. In the worst condition... I'll not be able to continue following what happens on the lttng world as I'll never think about giving a look at a website. I like the way the information comes to me, I'd not like to have to search for the information.
_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
2013/3/28 Simon Marchi <[email protected]>
Quoted 7 lines
Not that I know. But for example, with Gerrit, you could probably fetch all the changesets you were asked to review to your git tree before boarding your plane to Australia and at least read them. You would still have to enter your comments when you get back online.
Do you happen to work offline often ? Is this really important ?
For what it's worth, I like the current e-mail based patching system. Using another tool would just conduct me to have to :
1/ Follow online if there isn't any way to get the information by email 2/ Subscribe to the "send me all the info by email" if it exists 3/ Have to connect (and login?) to the website to answer if necessary, so taking more time to do it than now if there isn't any "reply directly by email" system
4/ Answer by email if it's possible
So, in the best situation, I'll do exactly as I do right now. In the worst condition... I'll not be able to continue following what happens on the lttng world as I'll never think about giving a look at a website. I like the way the information comes to me, I'd not like to have to search for the information.
_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
R4E works offline and I can hook you up with the devs.
I think you don't want online only but that you can "sync" then review on the run.
Here's the recently edited, soon to be reverted list of software from wiki.
http://en.wikipedia.org/wiki/List_of_tools_for_code_review
Quoted 24 lines · Yannick Brosseau
Quoted 4 lines · Simon Marchi
I think the point is that having patches in emails is not very convenient. Given the quality of web based tools available today, I think it would be relevant that the LTTng project adopt one of them.
Quoted 13 lines
With the current system:
- it is hard to see what the resulting code is. You juste have a blob of + and -, and it is very hard to see what the code looks in the end. Web based code review tools allow you to quickly see the modifications as part of the complete file, with nice colors and other visual aids.
- It is hard to follow the sequence of comments. With a web based tool, all discussions related to a topic are clearly laid out.
- It is hard to follow the evolution of a patch (differences between patch versions)
- Sometimes patches on the list fall into cracks and are never replied to.Is there any of the available code review tools that can work offline?
_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev