Skip to contentSkip to conversation

idle: delete (*idle)()

PATCH New Luck, Tony 1 participant 1 message Mar 29, 2013

lore
Share & tools
lore

Luck, Tony

author
#0 lore raw

PATCH 1/1 idle: delete (*idle)()

From: Len Brown <[email protected]>

Commit 3e7fc708eb
ia64 idle: delete pm_idle
in 3.9-rc1 didn't finish the job, leaving an un-initialized reference to (*idle)().

---
[Haven't seen a crash from this - but seems like we are
just being lucky that "idle" is zero so it does get initialized before we jump to randomland]

 arch/ia64/kernel/process.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
arch/ia64/kernel/process.c +1 -4
index e34f565..6f7dc8b 100644
@@ -291,7 +291,6 @@ cpu_idle (void)
 		}
 
 		if (!need_resched()) {
-			void (*idle)(void);
 #ifdef CONFIG_SMP
 			min_xtp();
 #endif
@@ -299,9 +298,7 @@ cpu_idle (void)
 			if (mark_idle)
 				(*mark_idle)(1);
 
-			if (!idle)
-				idle = default_idle;
-			(*idle)();
+			default_idle();
 			if (mark_idle)
 				(*mark_idle)(0);
 #ifdef CONFIG_SMP
Signature · 1 line
1.8.1.4