Skip to contentSkip to conversation

vlc: new package

PATCH New Alexey Brodkin 1 participant 1 message Apr 2, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vlc: new package

Quoted 4 lines · Bernd Kuhls

Hi,

Alexey Brodkin <Alexey.Brodkin-HKixBCOQz3hWk0Htik3J/[email protected]> wrote in

news:1363687526-8469-1-git-send-email-abrodkin-HKixBCOQz3hWk0Htik3J/w at public.gmane.org:

Quoted 10 lines
Quoted 2 lines

+ifeq ($(BR2_PACKAGE_AVCODEC),y)

shouldn?t this be called BR2_PACKAGE_VLC_AVCODEC?

Quoted 1 line

+ifeq ($(BR2_PACKAGE_LUA),y)

and this BR2_PACKAGE_VLC_LUA?

Regards, Bernd

Hi Bernd,

The idea is to check if "avcodec" and "lua" packages were selected in configuration utility (menuconfig/xconfig etc).

Indeed we may rely on VLC's symbols BR2_PACKAGE_AVCODEC and BR2_PACKAGE_LUA that select BR2_PACKAGE_FFMPEG and BR2_PACKAGE_LUA accordingly.

So initial proposal is to sort of double check if we do have "avcodec" and "lua" selected.

Even though you believe it's better to check VLC's own symbols I may do a re-spin.

-Alexey