fsfreeze: avoid to return zero in __get_user_pages
Subsystems (3)
PATCH 4/4 fsfreeze: avoid to return zero in __get_user_pages
In case of VM_FAULT_RETRY, __get_user_pages returns the number of pages alredy gotten, but there isn't a check if this number is zero. Instead, we have to return a proper error code so we can avoid a possible extra call of __get_user_pages. There are several places where get_user_pages is called inside a loop until all the pages requested are gotten or an error code is returned.
--- mm/memory.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
mm/memory.c +1 -1
@@ -1858,7 +1858,7 @@ long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm,if (ret &VM_FAULT_RETRY ) {if (nonblocking) *nonblocking =0 ; -return i; +return i ? i : -ERESTARTSYS ; }/*
Signature · 1 line
1.7.3.4
Quoted 17 lines · Marco Stornelli
In case of
VM_FAULT_RETRY,__get_user_pagesreturns the number of pages alredy gotten, but there isn't a check if this number is zero. Instead, we have to return a proper error code so we can avoid a possible extra call of__get_user_pages. There are several places whereget_user_pagesis called inside a loop until all the pages requested are gotten or an error code is returned.Signed-off-by Marco Stornelli <[email protected]>--- mm/memory.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)mm/memory.c +0
-0
mm/memory.c long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm, · line 1861
Quoted 5 lines
mm/memory.c +1
-1@@ -1858,7 +1858,7 @@ long __get_user_pages(struct task_struct *tsk, struct mm_struct *mm,if (ret &VM_FAULT_RETRY ) {if (nonblocking) *nonblocking =0 ; -return i; +return i ? i : -ERESTARTSYS ;
nonblock argument is only used from __mm_populate() and it expect __get_user_pages() return 0.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>