Skip to contentSkip to conversation

kernel: debug: memcpy overlaped, use memmove instead of memcpy.

PATCH Superseded Chen Gang 1 participant 2 messages Apr 7, 2013 – Apr 17, 2013 KGDB / KDB /debug_core

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 kernel: debug: memcpy overlaped, use memmove instead of memcpy.

in memcpy, src and dest are overlaped.
for default implementaion or some architectures, it is OK. but we can not be sure that it is OK for all platforms. and in this condition, the performance are not quite important.

so better to use standard ways: let memmove instead of memcpy.

---
 kernel/debug/kdb/kdb_support.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/debug/kdb/kdb_support.c +2 -2
index d35cc2d..990b3cc 100644
@@ -129,13 +129,13 @@ int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab)
 		}
 		if (i >= ARRAY_SIZE(kdb_name_table)) {
 			debug_kfree(kdb_name_table[0]);
-			memcpy(kdb_name_table, kdb_name_table+1,
+			memmove(kdb_name_table, kdb_name_table+1,
 			       sizeof(kdb_name_table[0]) *
 			       (ARRAY_SIZE(kdb_name_table)-1));
 		} else {
 			debug_kfree(knt1);
 			knt1 = kdb_name_table[i];
-			memcpy(kdb_name_table+i, kdb_name_table+i+1,
+			memmove(kdb_name_table+i, kdb_name_table+i+1,
 			       sizeof(kdb_name_table[0]) *
 			       (ARRAY_SIZE(kdb_name_table)-i-1));
 		}
Signature · 1 line
1.7.7.6
author
#1 lore raw

Hello maintainers:

please help check this patch, when you have time, thanks.

Quoted 34 lines · Chen Gang

in memcpy, src and dest are overlaped.
for default implementaion or some architectures, it is OK. but we can not be sure that it is OK for all platforms. and in this condition, the performance are not quite important.

so better to use standard ways: let memmove instead of memcpy.

---
 kernel/debug/kdb/kdb_support.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/debug/kdb/kdb_support.c +2 -2
index d35cc2d..990b3cc 100644
@@ -129,13 +129,13 @@ int kdbnearsym(unsigned long addr, kdb_symtab_t *symtab)
 		}
 		if (i >= ARRAY_SIZE(kdb_name_table)) {
 			debug_kfree(kdb_name_table[0]);
-			memcpy(kdb_name_table, kdb_name_table+1,
+			memmove(kdb_name_table, kdb_name_table+1,
 			       sizeof(kdb_name_table[0]) *
 			       (ARRAY_SIZE(kdb_name_table)-1));
 		} else {
 			debug_kfree(knt1);
 			knt1 = kdb_name_table[i];
-			memcpy(kdb_name_table+i, kdb_name_table+i+1,
+			memmove(kdb_name_table+i, kdb_name_table+i+1,
 			       sizeof(kdb_name_table[0]) *
 			       (ARRAY_SIZE(kdb_name_table)-i-1));
 		}
Signature · 3 lines
Chen Gang

Asianux Corporation