Skip to contentSkip to conversation

Fix wrong >4G filtering

PATCH New Vladimir 'φ-coder/phcoder' Serbinenko 2 participants 3 messages Apr 7, 2013 – Apr 16, 2013 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix wrong >4G filtering

Filtering of >4G chunks is wrong and one of such chunks can be improperly declared as usable ram top after being cut down to 4G, so uboot tries to relocate to ROM.

arch/x86/cpu/coreboot/sdram.c +4 -1
index 786009c..3b8dd5e 100644
@@ -77,8 +77,11 @@ ulong board_get_usable_ram_top(ulong total_size)
 			continue;
 
 		/* Filter memory over 4GB. */
+		if (start > 0xffffffffULL)
+			continue;
 		if (end > 0xffffffffULL)
-			end = 0x100000000ULL;
+			end = 0xffffffffULL;
+
 		/* Skip this region if it's too small. */
 		if (end - start < total_size)
 			continue;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 294 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130407/3ed956bc/attachment.pgp>

#1 lore raw

PATCH 1/1 Fix wrong >4G filtering

Quoted 3 lines · Vladimir '?-coder/phcoder' Serbinenko

Filtering of >4G chunks is wrong and one of such chunks can be improperly declared as usable ram top after being cut down to 4G, so uboot tries to relocate to ROM.

With commit message re-formatted to 80cols, applied to x86/master, thank you.

#2 lore raw

PATCH 1/1 Fix wrong >4G filtering

+Tom

Hi Vladimir,

Quoted 7 lines · Simon Glass
Quoted 3 lines · Vladimir '?-coder/phcoder' Serbinenko

Filtering of >4G chunks is wrong and one of such chunks can be improperly declared as usable ram top after being cut down to 4G, so uboot tries to relocate to ROM.

With commit message re-formatted to 80cols, applied to x86/master, thank you.

My mistake - this is missing a signoff, and also should not have a Nickname in your email.

Can you please resend this patch with these problems fixed?

Regards,
Simon