ipconfig: stop ip-config if disabled method directed
Subsystems (3)
PATCH 1/1 ipconfig: stop ip-config if disabled method directed
Hi,
Looks insignificant, but a misusage of kernel level auto configuration results in an invalid ipv4 address set.
That is a kind of corner case, but I think it is be better sanitizing
the input a bit more for our simple in_aton().
--
CONFIG_IP_PNP=yCONFIG_IP_PNP_DHCP=n
Command line: ip=dhcp
result in false ip address 62.0.0.0 set.
If directed autoconf method is not compiled into the kernel, ip-config should be terminated.
--- net/ipv4/ipconfig.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
net/ipv4/ipconfig.c +10 -0
@@ -1586,6 +1586,16 @@ static int __init ip_auto_config_setup(char *addrs)if (ic_proto_name (addrs))return 1 ; +/* This mean the kernel is not configured to have the method. */ +if (strcmp (addrs,"dhcp" ) ==0 || +strcmp (addrs,"bootp" ) ==0 || +strcmp (addrs,"rarp" ) ==0 || +strcmp (addrs,"both" ) ==0 ) { +pr_warn ("IP-Config: autoconf [%s] not compiled in\n" , addrs); + ic_enable =0 ; +return 1 ; + } +/* If no static IP is given, turn off autoconfig and bail. */ if (*addrs == 0 || strcmp(addrs, "off") == 0 ||
Signature · 1 line
1.8.1.5
David Miller
maintainerFrom: Takashi Yoshii <[email protected]>
Date: Wed, 10 Apr 2013 16:23:54 +0900
Quoted 11 lines
Looks insignificant, but a misusage of kernel level auto configuration results in an invalid ipv4 address set.
That is a kind of corner case, but I think it is be better sanitizing
the input a bit more for our simplein_aton().
--
CONFIG_IP_PNP=yCONFIG_IP_PNP_DHCP=n
Command line: ip=dhcp
result in false ip address 62.0.0.0 set.
Quoted 4 lines
If directed autoconf method is not compiled into the kernel, ip-config should be terminated.
Signed-off-by Takashi Yoshii <[email protected]>
This is a poor submission.
When you put _before_ the "--" is the commit message, and the text afterwards will be removed and not considered as part of the commit message.
Secondly, put this logic into ic_proto_name() so we don't duplicate all of these string comparisons.
Thirdly, consider simply removing all of these silly Kconfig options, they seem rediculous.