Skip to contentSkip to conversation

Snapshot

RFC Julien Desfossez 3 participants 5 messages Apr 11, 2013 4 messages not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Hi,

Quoted 7 lines

Hi everyone,

This is the initial RFC for snapshot in lttng-tools. Once accepted, it will be available in "doc/proposals/0006-lttng-snapshot.txt".

Any questions, comments or fixes are VERY welcome. There are probably English mistakes so feel free to point it out to me.

It looks good, just a few comments :

For the add-output command, I think we discussed adding the --max-size parameter as well to limit the size of the snapshots written to this output.

For the "lttng snapshot record", I think the options should allow to specify -C/-D also since we can specify an URL.

"This is a blocking call meaning that it will return only if the snapshot is completed" --> "only when the snapshot is completed or an error is returned"

"For now, no-wait is not supported by we keep" --> "but we"

Since it will block the caller, should we add a timeout parameter to lttng_snapshot_record ?

Thanks,

Julien

#2 lore raw
In reply to a message not in the archive

Looks great! A few very minor points:

In the "Motivation" section, English mistake: "could be particularly useful *with in* flight recorder mode" should be "could be particularly useful *in* flight recorder mode". Also, "informationS" is generally regarded as incorrect. Information has no plural form.

In the "Proposed Solution" section, "the lttng command line UI new command is presented" should be "the new lttng command-line UI command is presented".

I'd propose rewriting the sentence "Unlike the other lttng command, this one uses the git alike UI but in the form of the object first and
action after where previous command only use action such as
"enable-event" as
"This new command uses a git-alike UI, but in the form of the object first followed by the desired action, whereas other commands only use actions such as "enable-event"".

I'm not sure I would use an hyphen in "lttng snapshot list-output" when an output alias is present. That's an entirely subjective but it would seem more consistent with git (git remote -v, for instance).

Could you clarify what the expected behavior would be when no session name is provided to "lttng snapshot record"? I guess it would capture a snapshot for every session created with the --no-output option. Also, what happens if a single URL is provided and no session name is given (with multiple active flight recorder sessions)?

Thanks,
Jérémie

Quoted 9 lines · David Goulet

Hi everyone,

This is the initial RFC for snapshot in lttng-tools. Once accepted, it will be available in "doc/proposals/0006-lttng-snapshot.txt".

Any questions, comments or fixes are VERY welcome. There are probably English mistakes so feel free to point it out to me.

Quoted 8 lines

Thanks!
David

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

#4 lore raw
In reply to a message not in the archive

Julien Desfossez:

Quoted 7 lines

Hi,

Quoted 5 lines

Hi everyone,

This is the initial RFC for snapshot in lttng-tools. Once accepted, it will be available in "doc/proposals/0006-lttng-snapshot.txt".

Quoted 7 lines
Quoted 2 lines

Any questions, comments or fixes are VERY welcome. There are probably English mistakes so feel free to point it out to me.

It looks good, just a few comments :

For the add-output command, I think we discussed adding the --max-size parameter as well to limit the size of the snapshots written to this output.

Yup I forgot to add it.

Quoted 3 lines

For the "lttng snapshot record", I think the options should allow to specify -C/-D also since we can specify an URL.

Yup!

Quoted 4 lines

"This is a blocking call meaning that it will return only if the snapshot is completed" --> "only when the snapshot is completed or an error is returned"

Fixed

Quoted 2 lines

"For now, no-wait is not supported by we keep" --> "but we"

Fixed

Quoted 3 lines

Since it will block the caller, should we add a timeout parameter to lttng_snapshot_record ?

That would probably be a timer on the session daemon side and the health check would be the thing to use to monitor if the session daemon is stuck.

On the client side, the problem is that we have NO way of knowing what will be the duration of the operation

I'll send the second version soon with jgalar fixes.

Thanks!
David

Quoted 4 lines

Thanks,

Julien

#6 lore raw
In reply to a message not in the archive

Jérémie Galarneau:

Quoted 19 lines

Looks great! A few very minor points:

In the "Motivation" section, English mistake: "could be particularly useful *with in* flight recorder mode" should be "could be particularly useful *in* flight recorder mode". Also, "informationS" is generally regarded as incorrect. Information has no plural form.

In the "Proposed Solution" section, "the lttng command line UI new command is presented" should be "the new lttng command-line UI command is presented".

I'd propose rewriting the sentence "Unlike the other lttng command, this one uses the git alike UI but in the form of the object first and
action after where previous command only use action such as
"enable-event" as
"This new command uses a git-alike UI, but in the form of the object first followed by the desired action, whereas other commands only use actions such as "enable-event"".

Quoted 3 lines

I'm not sure I would use an hyphen in "lttng snapshot list-output" when an output alias is present. That's an entirely subjective but it would seem more consistent with git (git remote -v, for instance).

What output format do you propose?

Quoted 6 lines

Could you clarify what the expected behavior would be when no session name is provided to "lttng snapshot record"? I guess it would capture a snapshot for every session created with the --no-output option. Also, what happens if a single URL is provided and no session name is given (with multiple active flight recorder sessions)?

lttng command always work on the current session if none is defined. I'll make it clearer in the RFC.

Thanks!
David

Quoted 29 lines

Thanks,
Jérémie

Quoted 9 lines · David Goulet

Hi everyone,

This is the initial RFC for snapshot in lttng-tools. Once accepted, it will be available in "doc/proposals/0006-lttng-snapshot.txt".

Any questions, comments or fixes are VERY welcome. There are probably English mistakes so feel free to point it out to me.

Quoted 8 lines

Thanks!
David

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

#8 lore raw
In reply to a message not in the archive
Quoted 22 lines · David Goulet

Jérémie Galarneau:

Quoted 19 lines

Looks great! A few very minor points:

In the "Motivation" section, English mistake: "could be particularly useful *with in* flight recorder mode" should be "could be particularly useful *in* flight recorder mode". Also, "informationS" is generally regarded as incorrect. Information has no plural form.

In the "Proposed Solution" section, "the lttng command line UI new command is presented" should be "the new lttng command-line UI command is presented".

I'd propose rewriting the sentence "Unlike the other lttng command, this one uses the git alike UI but in the form of the object first and
action after where previous command only use action such as
"enable-event" as
"This new command uses a git-alike UI, but in the form of the object first followed by the desired action, whereas other commands only use actions such as "enable-event"".

Quoted 6 lines
Quoted 3 lines

I'm not sure I would use an hyphen in "lttng snapshot list-output" when an output alias is present. That's an entirely subjective but it would seem more consistent with git (git remote -v, for instance).

What output format do you propose?

Pretty much the same thing:
[1]: file://[...]
[2]: net://1.1.1.1:8762:9123
[3] ALIAS: file://[...]

Then again, I don't feel strongly about it.

Quoted 9 lines
Quoted 6 lines

Could you clarify what the expected behavior would be when no session name is provided to "lttng snapshot record"? I guess it would capture a snapshot for every session created with the --no-output option. Also, what happens if a single URL is provided and no session name is given (with multiple active flight recorder sessions)?

lttng command always work on the current session if none is defined. I'll make it clearer in the RFC.

Will there be a way to snapshot every flight-recorder session (say, on a trigger) or should it be done by invoking the command with every session name? Just trying to make the RFC as precise as possible :)

Quoted 33 lines

Thanks!
David

Quoted 29 lines

Thanks,
Jérémie

Quoted 9 lines · David Goulet

Hi everyone,

This is the initial RFC for snapshot in lttng-tools. Once accepted, it will be available in "doc/proposals/0006-lttng-snapshot.txt".

Any questions, comments or fixes are VERY welcome. There are probably English mistakes so feel free to point it out to me.

Quoted 8 lines

Thanks!
David

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com