Skip to contentSkip to conversation

Triggers

RFC Jérémie Galarneau 4 participants 5 messages Apr 11, 2013 – Apr 15, 2013 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

I'd propose changing <WHAT> to <WHERE> since it represents a condition. No other comments; it's pretty exciting indeed :)

Jérémie

Quoted 17 lines · David Goulet

Hi everyone,

Here is the second RFC of the day.

By reading this, your imagination will probably go pretty crazy with possibilities ;). The first implementation will only have one option describe in the RFC but note that with this kind of feature, the sky is the limit! and of course world domination is never far.

Thanks!
David

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Signature · 3 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
#2 lore raw
In reply to a message not in the archive
Quoted 8 lines

Hi everyone,

Here is the second RFC of the day.

By reading this, your imagination will probably go pretty crazy with possibilities ;). The first implementation will only have one option describe in the RFC but note that with this kind of feature, the sky is the limit! and of course world domination is never far.

illustrace --> illustrate

"take a snapshot of the session where this" --> "take a snapshot of all the sessions where this"

I would propose to add a "command" option to trigger, in order to allow to add, list and del triggers, also a trigger name/alias might become useful really soon.

Maybe something like that ?

$ lttng trigger [OPTIONS] {add|list|del} <NAME> <WHAT/WHERE> <ACTION>

Thanks,

Julien

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

Julien Desfossez:

Quoted 14 lines
Quoted 8 lines

Hi everyone,

Here is the second RFC of the day.

By reading this, your imagination will probably go pretty crazy with possibilities ;). The first implementation will only have one option describe in the RFC but note that with this kind of feature, the sky is the limit! and of course world domination is never far.

illustrace --> illustrate

"take a snapshot of the session where this" --> "take a snapshot of all the sessions where this"

Quoted 6 lines

I would propose to add a "command" option to trigger, in order to allow to add, list and del triggers, also a trigger name/alias might become useful really soon.

Maybe something like that ?

$ lttng trigger [OPTIONS] {add|list|del} <NAME> <WHAT/WHERE> <ACTION>

Hmmm yea, I think this will come handy in the future.

Quoted 4 lines

Thanks,

Julien

#5 lore raw
In reply to a message not in the archive

Hey tracing architects,
Just a thought of consistency.
we have
lttng add-context (you can have many)
lttng disable-context
lttng enable-consumer (you can only have one)
lttng disable-consumer
I would suggest
lttng add-trigger (you can have many)
lttng disable-trigger
lttng modify-trigger ???

TLDR: there should be a naming convention for lttng commands, there probably are but I have not seen them, or maybe I have but I do not remember seeing them.

TLDR-TLDR: name things the same way please. :)

Quoted 9 lines · David Goulet

Hi everyone,

Here is the second RFC of the day.

By reading this, your imagination will probably go pretty crazy with possibilities ;). The first implementation will only have one option describe in the RFC but note that with this kind of feature, the sky is the limit! and of course world domination is never far.

Quoted 8 lines

Thanks!
David

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

A message that is not in the archive (sent off-list or not yet received): [email protected]

#7 lore raw

FYI, disable and enable-consumer are gone in 2.2-rc1.

That's an interesting discussion to have. For the last years, we've used "lttng ACTION OPTIONS" scheme. Now, we choose to change that for the triggers and snapshots (RFC) is to have less commands and focus on the "object semantic" like "lttng OBJECT ACTION OPTIONS" mainly because we are pretty sure that more options and possibilities will come in the future with these complex commands.

So, the main reasons is that instead of creating 3+ more commands, we go for one command that allows the user to use triggers with all the different options under the same "roof".

It's a bit like "git commit" and "git remote". Git is still very usable but commands are simply different.

Hope that it clarifies why we propose this new scheme.

David

Matthew Khouzam:

Quoted 41 lines

Hey tracing architects,
Just a thought of consistency.
we have
lttng add-context (you can have many)
lttng disable-context
lttng enable-consumer (you can only have one)
lttng disable-consumer
I would suggest
lttng add-trigger (you can have many)
lttng disable-trigger
lttng modify-trigger ???

TLDR: there should be a naming convention for lttng commands, there probably are but I have not seen them, or maybe I have but I do not remember seeing them.

TLDR-TLDR: name things the same way please. :)

Quoted 9 lines · David Goulet

Hi everyone,

Here is the second RFC of the day.

By reading this, your imagination will probably go pretty crazy with possibilities ;). The first implementation will only have one option describe in the RFC but note that with this kind of feature, the sky is the limit! and of course world domination is never far.

Quoted 8 lines

Thanks!
David

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

This body part will be downloaded on demand.