xfstests: kludge patch for per-dir test number sorting by ./check
I'm trying to get the new xfstests to run the XFS tests first, then run the generic group, then run the shared group. One attempt was to work with this variable in the ./check script:
SRC_GROUPS="generic shared"
There is a final file sort in ./check that means, no matter which order groups are specified in SRC_GROUPS, the groups will be executed in alphabetical order. This sysadmin kludge patch fixes that behavior and seems to work. By moving the sorting into the trim_test_list() function, test numbers are still sorted, but the groups seem to run in the order specified in the SRC_GROUPS variable.
Let me know if this helps or if I'm simply not using the new xfstests correctly.
Michael
check renamed from check.orig +2 -2
@@ -138,7 +138,7 @@ echo "^$t\$" >>$tmp.grep numsed=`expr $numsed + 1` done - grep -v -f $tmp.grep <$tmp.list >$tmp.tmp + grep -v -f $tmp.grep <$tmp.list | sort -n >$tmp.tmp mv $tmp.tmp $tmp.list }
@@ -268,7 +268,7 @@ fi # sort the list of tests into numeric order -list=`sort -n $tmp.list` +list=`cat $tmp.list` rm -f $tmp.list $tmp.tmp $tmp.grep if $randomize
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 1 line · Michael L. Semon
I'm trying to get the new xfstests to run the XFS tests first, then
The question is why do you want to do this? Is there any specific reason for running the tests in that order?
FWIW, if all you want to do is run the xfs tests, run:
$ sudo ./check xfs[0-9][0-9][0-9]
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 6 lines · Dave Chinner
Quoted 1 line · Michael L. Semon
I'm trying to get the new xfstests to run the XFS tests first, then
The question is why do you want to do this? Is there any specific reason for running the tests in that order?
Quoted 8 lines
FWIW, if all you want to do is run the xfs tests, run:
$ sudo ./check xfs[0-9][0-9][0-9]Cheers,
Dave.
Personal preference. I'd like to run both series of tests, sometimes attended, sometimes unattended. It's fine if a generic/ test crashes the PC while running unattended, but I'd much rather the xfs/ tests have first crack at that.
My version of the syntax was ./check xfs/[0-9][0-9][0-9], but that becomes rough when skipping tests. I'll still try your version, but irrationality and frustration have driven me to simply adding a "mls" group to all of the tests/<fsgroup>/group files, then hoping that a ./check -g mls would run everything in the correct order. That led to trying to figure out why the generic/ tests were running first, and so on and so forth...
Thanks!
Michael
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 16 lines · Michael L. Semon
Quoted 6 lines · Dave Chinner
Quoted 1 line · Michael L. Semon
I'm trying to get the new xfstests to run the XFS tests first, then
The question is why do you want to do this? Is there any specific reason for running the tests in that order?
Quoted 8 lines
FWIW, if all you want to do is run the xfs tests, run:
$ sudo ./check xfs[0-9][0-9][0-9]Cheers,
Dave.
Quoted 7 lines
Personal preference. I'd like to run both series of tests, sometimes attended, sometimes unattended. It's fine if a generic/ test crashes the PC while running unattended, but I'd much rather the xfs/ tests have first crack at that.
My version of the syntax was
./check xfs/[0-9][0-9][0-9], but that becomes rough when skipping tests. I'll still try your version, but
I think this is a reasonable change request and I can see how this would be very rough if you wanted to skip tests. Anyone have a reason why not to do this?
Regards,
--Rich
Quoted 9 lines
irrationality and frustration have driven me to simply adding a "mls" group to all of the tests/<fsgroup>/group files, then hoping that a
./check -g mlswould run everything in the correct order. That led to trying to figure out why the generic/ tests were running first, and so on and so forth...Thanks!
Michael
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 25 lines · Rich Johnston
Quoted 16 lines · Michael L. Semon
Quoted 6 lines · Dave Chinner
Quoted 1 line · Michael L. Semon
I'm trying to get the new xfstests to run the XFS tests first, then
The question is why do you want to do this? Is there any specific reason for running the tests in that order?
Quoted 8 lines
FWIW, if all you want to do is run the xfs tests, run:
$ sudo ./check xfs[0-9][0-9][0-9]Cheers,
Dave.
Quoted 7 lines
Personal preference. I'd like to run both series of tests, sometimes attended, sometimes unattended. It's fine if a generic/ test crashes the PC while running unattended, but I'd much rather the xfs/ tests have first crack at that.
My version of the syntax was
./check xfs/[0-9][0-9][0-9], but that becomes rough when skipping tests. I'll still try your version, but
Quoted 6 lines
I think this is a reasonable change request and I can see how this would be very rough if you wanted to skip tests. Anyone have a reason why not to do this?
Regards,
--Rich
It's a good change request, but on further testing, it seems like my kludge patch breaks basic sorting, i.e. ./check generic/003 generic/001 generic/002 will run the tests in exactly that order. That's not necessarily bad--principle of least surprise--but it means that to get the old xfstests sorting behavior, it would have to be sorted using another method.
Thanks for considering the need for more control over the order in which groups are run. It's most certainly appreciated.
Thinking out loud: Is there a disadvantage to setting $SRC_DIR to "." instead of "tests"? It looks like a nice way to get ./check tests/generic/001 to run tests/generic/001 instead of issuing "unknown test, ignored", but I've tested it only for generic/001 here at work.
Michael
Quoted 9 lines
Quoted 9 lines
irrationality and frustration have driven me to simply adding a "mls" group to all of the tests/<fsgroup>/group files, then hoping that a
./check -g mlswould run everything in the correct order. That led to trying to figure out why the generic/ tests were running first, and so on and so forth...Thanks!
Michael
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs