Skip to contentSkip to conversation

nfnl_acct_new: add packet/byte values check

PATCH New Michael Zintakis 1 participant 1 message Apr 14, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 nfnl_acct_new: add packet/byte values check

* check that in nfnetlink_acct.c::nfnl_acct_new both packet and byte values are specified and return EINVAL if that is not the case

---
 net/netfilter/nfnetlink_acct.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
net/netfilter/nfnetlink_acct.c +3 -1
index dc3fd5d..c8d1282 100644
@@ -45,7 +45,9 @@ nfnl_acct_new(struct sock *nfnl, struct sk_buff *skb,
 	struct nf_acct *nfacct, *matching = NULL;
 	char *acct_name;
 
-	if (!tb[NFACCT_NAME])
+	if (!tb[NFACCT_NAME] ||
+	    (tb[NFACCT_BYTES] && !tb[NFACCT_PKTS]) ||
+	    (!tb[NFACCT_BYTES] && tb[NFACCT_PKTS]))
 		return -EINVAL;
 
 	acct_name = nla_data(tb[NFACCT_NAME]);