Btrfs: do not continue if out of memory happens
PATCH 1/1 Btrfs: do not continue if out of memory happens
If out of memory happens, we should return -ENOMEM directly to the caller rather than continue the work.
Signed-off-by Wang Shilong <[email protected]>
--- fs/btrfs/backref.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
fs/btrfs/backref.c +4 -2
@@ -352,6 +352,8 @@ static int __resolve_indirect_refs(struct btrfs_fs_info *fs_info, err =__resolve_indirect_ref (fs_info, search_commit_root, time_seq, ref, parents, extent_item_pos); +if (err == -ENOMEM ) + goto out;if (err)continue ;
@@ -367,7 +369,7 @@ static int __resolve_indirect_refs(struct btrfs_fs_info *fs_info, new_ref =kmalloc (sizeof (*new_ref),GFP_NOFS );if (!new_ref) { ret = -ENOMEM ; -break ; + goto out; }memcpy (new_ref, ref,sizeof (*ref)); new_ref->parent = node->val;
@@ -377,7 +379,7 @@ static int __resolve_indirect_refs(struct btrfs_fs_info *fs_info, }ulist_reinit (parents); } - +out:ulist_free (parents);return ret; }
-- 1.7.7.6
Quoted 2 lines · Wang Shilong
If out of memory happens, we should return
-ENOMEMdirectly to the caller rather than continue the work.
Reviewed-by David Sterba <[email protected]>