ARM64: kernel: compiling issue, need implement cmpxchg64 with assembler language.
in arch/arm64/include/asm, not define the function cmpxchg64
when compiling with allmodconfig,
drivers/block/blockconsole.c will need this function.
I am not quite familiar with ARM64 (neither ARM64 assembler)
can any member helps to send related patch ?
if no one have time to send related patch, I should try. and I am glad to try, but need additional time resources, if I try, I should finish it within this month (2013-4-30).
welcome any suggestions or completions.
thanks.
gchen.
Quoted 5 lines · Chen Gang
in
arch/arm64/include/asm, not define the function cmpxchg64when compiling with allmodconfig,
drivers/block/blockconsole.cwill need this function.
Quoted 8 lines
I am not quite familiar with ARM64 (neither ARM64 assembler)
can any member helps to send related patch ?
if no one have time to send related patch, I should try. and I am glad to try, but need additional time resources, if I try, I should finish it within this month (2013-4-30).welcome any suggestions or completions.
cmpxchg64 is the same as cmpxchg on 64-bit platforms, can't the driver be changed to use the latter?
Arnd
Quoted 13 lines · Arnd Bergmann
Quoted 12 lines · Chen Gang
in
arch/arm64/include/asm, not define the function cmpxchg64when compiling with allmodconfig,
drivers/block/blockconsole.cwill need this function.I am not quite familiar with ARM64 (neither ARM64 assembler)
can any member helps to send related patch ?
if no one have time to send related patch, I should try. and I am glad to try, but need additional time resources, if I try, I should finish it within this month (2013-4-30).
Quoted 8 lines
Quoted 1 line
welcome any suggestions or completions.
cmpxchg64 is the same as cmpxchg on 64-bit platforms, can't the driver be changed to use the latter?
Arnd
can we be sure that cmpxchg64 is equal to cmpchg on all 64-bit platforms ?
(I guess, the driver may need cross multiple platforms)
(it seems, under x86, s390, better use cmpxchg64, at least they define it).
whether we can be sure or not,
I still prefer to define the macro cmpxchg64 just the alias of cmpxchg.
(and I also guess ARM64 is always on 64-bit platform)
the related patch may be like below.
-------------------------------patch begin--------------------------------------
arch/arm64/include/asm/cmpxchg.h +2 -0
@@ -170,4 +170,6 @@ static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old, (unsigned long)(n), \ sizeof(*(ptr)))) +#define cmpxchg64 (ptr,o,n) cmpxchg((ptr),(o),(n)) +#endif /* __ASM_CMPXCHG_H */
-------------------------------patch end----------------------------------------
I think, we can also reference the implementation of s390:
it is in arch/s390/include/asm/cmpxchg.h.
since we are ARM64, excluding ARM(32,16...), we can only consider 64-bit.
if in the future, ARM64 and ARM are merged together:
we can use CONFIG_64BIT to switch the cmpxchg64 definition.
if define CONFIG_64BIT, use cmpxchg instead of cmpxchg64.
else, use the definition of ARM (arch/arm/include/asm/cmpxchg.h already defines cmpxchg64)
-------------------------------reference begin----------------------------------
#ifdef CONFIG_64BIT
#define cmpxchg64(ptr, o, n) \
({ \
cmpxchg((ptr), (o), (n)); \
})#else /* CONFIG_64BIT */
...
-------------------------------reference end------------------------------------
:-)
Signature · 3 lines
Chen Gang Asianux Corporation
Quoted 8 lines · On Saturday 20 April 2013 10:28:55 Chen Gang wrote:
-------------------------------patch begin--------------------------------------
arch/arm64/include/asm/cmpxchg.h +0
-0
arch/arm64/include/asm/cmpxchg.h static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old, · line 175
Quoted 6 lines
arch/arm64/include/asm/cmpxchg.h +2
-0@@ -170,4 +170,6 @@ static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old, (unsigned long)(n), \ sizeof(*(ptr)))) +#define cmpxchg64 (ptr,o,n) cmpxchg((ptr),(o),(n)) +#endif /* __ASM_CMPXCHG_H */
Yes, this looks good. Please provide the same for cmpxchg64_local.
Quoted 11 lines
-------------------------------patch end----------------------------------------
I think, we can also reference the implementation of s390:
it is inarch/s390/include/asm/cmpxchg.h.
since we are ARM64, excludingARM(32,16...), we can only consider 64-bit.
if in the future, ARM64 and ARM are merged together:
we can useCONFIG_64BITto switch the cmpxchg64 definition.
if defineCONFIG_64BIT, use cmpxchg instead of cmpxchg64.
else, use the definition of ARM (arch/arm/include/asm/cmpxchg.halready defines cmpxchg64)
I would not worry aobut merging the two at the moment.
Quoted 10 lines
-------------------------------reference begin----------------------------------
#ifdef
CONFIG_64BIT#define cmpxchg64(ptr, o, n) \ ({ \ cmpxchg((ptr), (o), (n)); \})
#else /*CONFIG_64BIT*/
...
-------------------------------reference end------------------------------------
This implementation in unnecessarily verbose, I think the one you have above is nicer.
Arnd
Quoted 12 lines · Arnd Bergmann
Quoted 11 lines · On Saturday 20 April 2013 10:28:55 Chen Gang wrote:
-------------------------------patch begin--------------------------------------
arch/arm64/include/asm/cmpxchg.h +0
-0@@ -170,4 +170,6 @@ static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old, (unsigned long )(n), \ sizeof(*(ptr))))
Quoted 6 lines
arch/arm64/include/asm/cmpxchg.h static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old, · line 175
Quoted 3 lines
arch/arm64/include/asm/cmpxchg.h +2
-0+#define cmpxchg64 (ptr,o,n) cmpxchg((ptr),(o),(n)) +#endif /* __ASM_CMPXCHG_H */ Yes, this looks good. Please provide the same for
cmpxchg64_local.
ok, thanks, I will send related patch.
gchen.
PATCH 1/1 ARM64: kernel: compiling issue, define cmpxchg64 and cmpxchg64_local for outside using.
In reply to Arnd Bergmann drivers use cmpxchg64, cmpxchg64_local ... to perform 64-bit operation, so they can cross 32-bit and 64-bit platforms (it is a standard way).
--- arch/arm64/include/asm/cmpxchg.h | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm64/include/asm/cmpxchg.h +3 -0
@@ -170,4 +170,7 @@ static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old, (unsigned long)(n), \ sizeof(*(ptr)))) +#define cmpxchg64 (ptr,o,n) cmpxchg((ptr),(o),(n)) +#define cmpxchg64_local (ptr,o,n) cmpxchg_local((ptr),(o),(n)) +#endif /* __ASM_CMPXCHG_H */
Signature · 1 line
1.7.7.6
Re: [PATCH] ARM64: kernel: compiling issue, define cmpxchg64 and cmpxchg64_local for outside using.
Quoted 6 lines · Chen Gang
drivers use cmpxchg64,
cmpxchg64_local... to perform 64-bit operation, so they can cross 32-bit and 64-bit platforms (it is a standard way).Signed-off-by Chen Gang <[email protected]>
Applied, thanks.
Signature · 1 line
Catalin
Re: [PATCH] ARM64: kernel: compiling issue, define cmpxchg64 and cmpxchg64_local for outside using.
Quoted 8 lines · Catalin Marinas
Quoted 6 lines · Chen Gang
Quoted 6 lines
drivers use cmpxchg64,
cmpxchg64_local... to perform 64-bit operation, so they can cross 32-bit and 64-bit platforms (it is a standard way).Signed-off-by Chen Gang <[email protected]>Applied, thanks.
Thanks too. I should continue to find and make new patches for arm64.
Signature · 3 lines
Chen Gang Asianux Corporation