xfstests: remove recursive include in filter.btrfs
PATCH 1/1 xfstests: remove recursive include in filter.btrfs
Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307)
---
common/filter.btrfs +0 -2
@@ -1,7 +1,5 @@ # Filters for btrfs command output -. ./common/filter.btrfs - # Some, but not all, commands emit "Btrfs <version>" _filter_btrfs_version() {
PATCH v2 1/1 xfstests: remove recursive include in filter.btrfs
Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307)
It should be including the common/filter not common/filter.btrfs
---
common/filter.btrfs +1 -1
@@ -1,6 +1,6 @@ # Filters for btrfs command output -. ./common/filter.btrfs +. ./filter # Some, but not all, commands emit "Btrfs <version>" _filter_btrfs_version()
PATCH v3 1/1 xfstests: fix common filter include in filter.btrfs
Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307)
It should be including ./common/filter not ./common/filter.btrfs
---
cripes, I'm sorry that took 3 times to get right :/
common/filter.btrfs +1 -1
@@ -1,6 +1,6 @@ # Filters for btrfs command output -. ./common/filter.btrfs +. ./common/filter # Some, but not all, commands emit "Btrfs <version>" _filter_btrfs_version()
Re: [PATCH V3] xfstests: fix common filter include in filter.btrfs
Quoted 11 lines · Eric Sandeen
Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307)
It should be including ./common/filter not ./common/filter.btrfs
Signed-off-by Eric Sandeen <[email protected]>---
cripes, I'm sorry that took 3 times to get right :/
Third time is the charm ;) Looks good.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Thanks for the patch Eric, V3 has been committed.
--Rich
commit e771c54c45a5c475bedbc5a2d6becc05be940dba
Author: Eric Sandeen <[email protected]> Date: Sun Apr 21 22:51:54 2013 +0000
xfstests: fix common filter include in filter.btrfs