Skip to contentSkip to conversation

xfstests: remove recursive include in filter.btrfs

PATCH In review Eric Sandeen 3 participants 5 messages Apr 21, 2013 – Apr 22, 2013 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: remove recursive include in filter.btrfs

Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307)

---

common/filter.btrfs +0 -2
index b1aa733..99d04a6 100644
@@ -1,7 +1,5 @@
 # Filters for btrfs command output
 
-. ./common/filter.btrfs
-
 # Some, but not all, commands emit "Btrfs <version>"
 _filter_btrfs_version()
 {
#1 lore raw

PATCH v2 1/1 xfstests: remove recursive include in filter.btrfs

Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307)

It should be including the common/filter not common/filter.btrfs

---

common/filter.btrfs +1 -1
index b1aa733..3435d8d 100644
@@ -1,6 +1,6 @@
 # Filters for btrfs command output
 
-. ./common/filter.btrfs
+. ./filter
 
 # Some, but not all, commands emit "Btrfs <version>"
 _filter_btrfs_version()
#2 lore raw

PATCH v3 1/1 xfstests: fix common filter include in filter.btrfs

Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307)

It should be including ./common/filter not ./common/filter.btrfs

---

cripes, I'm sorry that took 3 times to get right :/

common/filter.btrfs +1 -1
index b1aa733..e9a2bc2 100644
@@ -1,6 +1,6 @@
 # Filters for btrfs command output
 
-. ./common/filter.btrfs
+. ./common/filter
 
 # Some, but not all, commands emit "Btrfs <version>"
 _filter_btrfs_version()
Reviewed-by on v3 1/1
#3 lore raw

Re: [PATCH V3] xfstests: fix common filter include in filter.btrfs

Quoted 11 lines · Eric Sandeen

Not sure how this happened, but filter.btrfs including itself leads to immense sadness for any file that includes it. (I got a segfault when I tried to run 307)

It should be including ./common/filter not ./common/filter.btrfs

---

cripes, I'm sorry that took 3 times to get right :/

Third time is the charm ;) Looks good.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs