mei file2alias compile error
Linus's current git isn't compiling for me:
Quoted 6 lines
HOSTCC
scripts/mod/file2alias.o/home/davehans/linux.git/scripts/mod/file2alias.c: In function ‘do_mei_entry’:/home/davehans/linux.git/scripts/mod/file2alias.c:1140:1: error: ‘OFF_mei_cl_device_id_name’ undeclared (first use in this function)/home/davehans/linux.git/scripts/mod/file2alias.c:1140:1: note: each undeclared identifier is reported only once for each function it appears in/home/davehans/linux.git/scripts/mod/file2alias.c: At top level:/home/davehans/linux.git/scripts/mod/file2alias.c:1146:1: error: ‘SIZE_mei_cl_device_id’ undeclared here (not in a function)
I confirmed that this commit: e5354107e is the one causing it for me. My .config is here:
http://sr71.net/~dave/linux/config-3.9-meibad
Note that I don't even have CONFIG_INTEL_MEI enabled with this config.
Quoted 9 lines · Dave Hansen
Linus's current git isn't compiling for me:
Quoted 6 lines
HOSTCC
scripts/mod/file2alias.o/home/davehans/linux.git/scripts/mod/file2alias.c: In function ‘do_mei_entry’:/home/davehans/linux.git/scripts/mod/file2alias.c:1140:1: error: ‘OFF_mei_cl_device_id_name’ undeclared (first use in this function)/home/davehans/linux.git/scripts/mod/file2alias.c:1140:1: note: each undeclared identifier is reported only once for each function it appears in/home/davehans/linux.git/scripts/mod/file2alias.c: At top level:/home/davehans/linux.git/scripts/mod/file2alias.c:1146:1: error: ‘SIZE_mei_cl_device_id’ undeclared here (not in a function)
Quoted 6 lines
I confirmed that this commit:
e5354107eis the one causing it for me. My .config is here:http://sr71.net/~dave/linux/config-3.9-meibadNote that I don't even have
CONFIG_INTEL_MEIenabled with this config.
I don't have CONFIG_INTEL_MEI set either, and I can't duplicate this. Samuel and Tomas, can you please track this down?
thanks,
greg k-h
Quoted 19 lines · Dave Hansen
Quoted 4 lines
Linus's current git isn't compiling for me:
Quoted 2 lines
HOSTCC
scripts/mod/file2alias.o/home/davehans/linux.git/scripts/mod/file2alias.c: In function‘do_mei_entry’:
Quoted 1 line
Quoted 1 line
/home/davehans/linux.git/scripts/mod/file2alias.c:1140:1: error:‘OFF_mei_cl_device_id_name’ undeclared (first use in this function)
Quoted 1 line
Quoted 1 line
/home/davehans/linux.git/scripts/mod/file2alias.c:1140:1: note: eachundeclared identifier is reported only once for each function it appears in
Quoted 2 lines
Quoted 2 lines
/home/davehans/linux.git/scripts/mod/file2alias.c: At top level:/home/davehans/linux.git/scripts/mod/file2alias.c:1146:1: error:‘SIZE_mei_cl_device_id’ undeclared here (not in a function)
Quoted 4 lines
I confirmed that this commit:
e5354107eis the one causing it for me. My .config is here:
Quoted 6 lines
Quoted 3 lines
http://sr71.net/~dave/linux/config-3.9-meibadNote that I don't even have
CONFIG_INTEL_MEIenabled with this config.I don't have
CONFIG_INTEL_MEIset either, and I can't duplicate this. Samuel and Tomas, can you please track this down?
I cannot reproduce it as well. I've tried with v3.9 and also with the latest tip.
Thanks
Tomas ���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay� ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�
Quoted 16 lines · Tomas
Quoted 16 lines · Dave Hansen
Quoted 3 lines
Linus's current git isn't compiling for me:
Quoted 2 lines
HOSTCC
scripts/mod/file2alias.o/home/davehans/linux.git/scripts/mod/file2alias.c: In function‘do_mei_entry’:
Quoted 1 line
Quoted 1 line
/home/davehans/linux.git/scripts/mod/file2alias.c:1140:1: error:‘OFF_mei_cl_device_id_name’ undeclared (first use in this function)
Quoted 1 line
Quoted 1 line
/home/davehans/linux.git/scripts/mod/file2alias.c:1140:1: note: eachundeclared identifier is reported only once for each function it appears in
Quoted 2 lines
Quoted 2 lines
/home/davehans/linux.git/scripts/mod/file2alias.c: At top level:/home/davehans/linux.git/scripts/mod/file2alias.c:1146:1: error:‘SIZE_mei_cl_device_id’ undeclared here (not in a function)
Quoted 4 lines
I confirmed that this commit:
e5354107eis the one causing it for me. My .config is here:
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
http://sr71.net/~dave/linux/config-3.9-meibadNote that I don't even have
CONFIG_INTEL_MEIenabled with this config.I don't have
CONFIG_INTEL_MEIset either, and I can't duplicate this. Samuel and Tomas, can you please track this down?I cannot reproduce it as well. I've tried with v3.9 and also with the latest tip.
I did some more poking around. I was building with O= to put the binaries in another dir. When I saw the error, one of the first things I did was do a "make mrproper" on the binary directory. But, I never did one one the source directory. Doing that seems to have made this go away. There must have been some build gunk in the source directory causing this.
Tomas, thanks for taking a look.
For posterity:
gcc version 4.6.3 20120306 (Red Hat 4.6.3-2) (GCC) Fedora release 16 (Verne) v3.9-5295-ga49fe6d
Quoted 24 lines · Dave Hansen
Quoted 23 lines · Tomas
Quoted 22 lines · Dave Hansen
Quoted 3 lines
Linus's current git isn't compiling for me:
Quoted 2 lines
HOSTCC
scripts/mod/file2alias.o/home/davehans/linux.git/scripts/mod/file2alias.c: In function‘do_mei_entry’:
Quoted 1 line
Quoted 1 line
/home/davehans/linux.git/scripts/mod/file2alias.c:1140:1: error:‘OFF_mei_cl_device_id_name’ undeclared (first use in this function)
Quoted 1 line
Quoted 1 line
/home/davehans/linux.git/scripts/mod/file2alias.c:1140:1: note: eachundeclared identifier is reported only once for each function it appears in
Quoted 2 lines
Quoted 2 lines
/home/davehans/linux.git/scripts/mod/file2alias.c: At top level:/home/davehans/linux.git/scripts/mod/file2alias.c:1146:1: error:‘SIZE_mei_cl_device_id’ undeclared here (not in a function)
Quoted 7 lines
I confirmed that this commit:
e5354107eis the one causing it for me. My .config is here:http://sr71.net/~dave/linux/config-3.9-meibadNote that I don't even have
CONFIG_INTEL_MEIenabled with this config.I don't have
CONFIG_INTEL_MEIset either, and I can't duplicate this. Samuel and Tomas, can you please track this down?
Quoted 8 lines
Quoted 1 line
I cannot reproduce it as well. I've tried with v3.9 and also with the latest tip.
I did some more poking around. I was building with O= to put the binaries in another dir. When I saw the error, one of the first things I did was do a "make mrproper" on the binary directory. But, I never did one one the source directory. Doing that seems to have made this go away. There must have been some build gunk in the source directory causing this.
Same here.
Removing "scripts/mod/devicetable-offsets.h" from the source directory fixes it. Unfortunately I forgot to check the date on the bogus scripts/mod/devicetable-offsets.h,
so I don't know when it was generated.
Usually, if you build in the source directory, a subsequent build in the output directory will tell you to run "make mrproper" in the source directory. That obviously didn't happen.
Note that I did run "make tags" in the source directory. So far that never caused
problems. Just checked, it does not create scripts/mod/devicetable-offsets.h.
JFYI, putting back scripts/mod/devicetable-offsets.h by copying from a freshly generated one in the output directory, with the mei lines removed, resurrects the problem.
Even after touching scripts/mod/devicetable-offsets.c afterwards, it is not regenerated.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 1/1 Fix cleaning in scripts/mod
Make sure devicetable-offsets.h is cleaned in the scripts/mod directory
--- scripts/mod/Makefile | 2 ++ 1 file changed, 2 insertions(+)
scripts/mod/Makefile +2 -0
@@ -37,6 +37,8 @@ scripts/mod/devicetable-offsets.s: scripts/mod/devicetable-offsets.c FORCE $(obj)/$(devicetable-offsets-file): scripts/mod/devicetable-offsets.s $(call cmd,offsets) +targets += $(devicetable-offsets-file) + # dependencies on generated files need to be listed explicitly $(obj)/modpost.o $(obj)/file2alias.o $(obj)/sumversion.o: $(obj)/elfconfig.h
Signature · 1 line
1.8.2.2
Re: [PATCH] Fix cleaning in scripts/mod
Quoted 3 lines · Andreas Schwab
Make sure
devicetable-offsets.his cleaned in thescripts/moddirectorySigned-off-by Andreas Schwab <[email protected]>
Quoted 9 lines
--- scripts/mod/Makefile | 2 ++ 1 file changed, 2 insertions(+)scripts/mod/Makefile +0
-0
scripts/mod/Makefile scripts/mod/devicetable-offsets.s: scripts/mod/devicetable-offsets.c FORCE · line 44
Quoted 8 lines
scripts/mod/Makefile +2
-0@@ -37,6 +37,8 @@ scripts/mod/devicetable-offsets.s: scripts/mod/devicetable-offsets.c FORCE $(obj)/$(devicetable-offsets-file): scripts/mod/devicetable-offsets.s $(call cmd,offsets) +targets += $(devicetable-offsets-file) + # dependencies on generated files need to be listed explicitly $(obj)/modpost.o $(obj)/file2alias.o $(obj)/sumversion.o: $(obj)/elfconfig.h
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] Fix cleaning in scripts/mod
Quoted 6 lines · Geert Uytterhoeven
Quoted 3 lines · Andreas Schwab
Make sure
devicetable-offsets.his cleaned in thescripts/moddirectorySigned-off-by Andreas Schwab <[email protected]>Tested-by Geert Uytterhoeven <[email protected]>
Applied to kbuild.git#kbuild.
Michal