Skip to contentSkip to conversation

xfs: Remove struct xfs_chash from xfs_mount

PATCH Applied Jeff Liu 3 participants 4 messages May 2, 2013 – Jun 17, 2013 XFS filesystem

lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

PATCH v2 1/1 xfs: Remove struct xfs_chash from xfs_mount

v2->v1:
Fix a typo at comments, i.e. s/xfs_krash/xfs_chash/.

From: Jie Liu <[email protected]>

Remove struct xfs_chash from struct xfs_mount as there is no user of it nowadays.

---
 fs/xfs/xfs_mount.h |    2 --
 1 file changed, 2 deletions(-)
fs/xfs/xfs_mount.h +0 -2
index bc90706..b68e56b 100644
@@ -192,8 +192,6 @@ typedef struct xfs_mount {
        xfs_dablk_t             m_dirleafblk;   /* blockno of dir non-data v2 */
        xfs_dablk_t             m_dirfreeblk;   /* blockno of dirfreeindex v2 */
        uint                    m_chsize;       /* size of next field */
-       struct xfs_chash        *m_chash;       /* fs private inode per-cluster
-                                                * hash table */
        atomic_t                m_active_trans; /* number trans frozen */
 #ifdef HAVE_PERCPU_SB
        xfs_icsb_cnts_t __percpu *m_sb_cnts;    /* per-cpu superblock counters */
Signature · 6 lines
1.7.9.5

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Reviewed-by on v2 1/1
#1 lore raw
Quoted 20 lines · Jeff Liu

v2->v1:
Fix a typo at comments, i.e. s/xfs_krash/xfs_chash/.

From: Jie Liu<[email protected]>

Remove struct xfs_chash from struct xfs_mount as there is no user of it nowadays.

---
  fs/xfs/xfs_mount.h |    2 --
  1 file changed, 2 deletions(-)
fs/xfs/xfs_mount.h +0 -0
index bc90706..b68e56b 100644

fs/xfs/xfs_mount.h typedef struct xfs_mount { · line 197

Quoted 8 lines
fs/xfs/xfs_mount.h +0 -2
@@ -192,8 +192,6 @@ typedef struct xfs_mount {
         xfs_dablk_t             m_dirleafblk;   /* blockno of dir non-data v2 */
         xfs_dablk_t             m_dirfreeblk;   /* blockno of dirfreeindex v2 */
         uint                    m_chsize;       /* size of next field */
-       struct xfs_chash        *m_chash;       /* fs private inode per-cluster
-                                                * hash table */
         atomic_t                m_active_trans; /* number trans frozen */
  #ifdef HAVE_PERCPU_SB
         xfs_icsb_cnts_t __percpu *m_sb_cnts;    /* per-cpu superblock counters */

Your mailer may have damaged the patch. The <TAB> are now spaces.

FYI, I had problems with another patch of yours:

	http://oss.sgi.com/archives/xfs/2013-05/msg00022.html
starting at the line:
	@@ -630,6 +688,12 @@ xfs_log_mount(

I think that this patch can be fixed rather resent. Looks good.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

author
#2 lore raw
Quoted 32 lines · Mark Tinguely
Quoted 20 lines · Jeff Liu

v2->v1:
Fix a typo at comments, i.e. s/xfs_krash/xfs_chash/.

From: Jie Liu<[email protected]>

Remove struct xfs_chash from struct xfs_mount as there is no user of it nowadays.

---
  fs/xfs/xfs_mount.h |    2 --
  1 file changed, 2 deletions(-)
fs/xfs/xfs_mount.h +0 -0
index bc90706..b68e56b 100644

fs/xfs/xfs_mount.h typedef struct xfs_mount { · line 197

Quoted 8 lines
fs/xfs/xfs_mount.h +0 -2
@@ -192,8 +192,6 @@ typedef struct xfs_mount {
         xfs_dablk_t             m_dirleafblk;   /* blockno of dir non-data v2 */
         xfs_dablk_t             m_dirfreeblk;   /* blockno of dirfreeindex v2 */
         uint                    m_chsize;       /* size of next field */
-       struct xfs_chash        *m_chash;       /* fs private inode per-cluster
-                                                * hash table */
         atomic_t                m_active_trans; /* number trans frozen */
  #ifdef HAVE_PERCPU_SB
         xfs_icsb_cnts_t __percpu *m_sb_cnts;    /* per-cpu superblock counters */

Your mailer may have damaged the patch. The <TAB> are now spaces.

Quoted 6 lines

FYI, I had problems with another patch of yours:

	http://oss.sgi.com/archives/xfs/2013-05/msg00022.html
starting at the line:
	@@ -630,6 +688,12 @@ xfs_log_mount(

I think that this patch can be fixed rather resent. Looks good.

Not sure why my email client did a bad formating, will take care of it anyway.

Thanks,
-Jeff

Quoted 8 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs