Skip to contentSkip to conversation

f2fs: Continue to mount after failing recovery

PATCH Superseded Chris Fries 1 participant 1 message May 2, 2013 F2FS file system

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 f2fs: Continue to mount after failing recovery

From: Chris Fries <[email protected]>

When unable to roll forward the journal, we shouldn't bail out and not mount, we should continue to attempt the mount. Bad recovery data is likely unrecoverable at this point, and requiring the user to try to mount again doesn't solve any issues.

---
 fs/f2fs/super.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
fs/f2fs/super.c +3 -4
index 2643c49..d8f7ed3 100644
@@ -649,10 +649,9 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
     /* recover fsynced data */
     if (!test_opt(sbi, DISABLE_ROLL_FORWARD)) {
         err = recover_fsync_data(sbi);
-        if (err) {
-            f2fs_msg(sb, KERN_ERR, "Failed to recover fsync data");
-            goto free_root_inode;
-        }
+        if (err)
+            f2fs_msg(sb, KERN_ERR,
+                "Cannot recover all fsync data, continue\n");
     }
 
     /* After POR, we can run background GC thread */
Signature · 1 line
1.8.0