i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful
PATCH 1/2 i2c: i2c-bfin-twi: don`t free peripheral before it`s init successful
down out_error_no_irq. When platform_get_irq fail, no need to free peripheral
--- drivers/i2c/busses/i2c-bfin-twi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/i2c/busses/i2c-bfin-twi.c +1 -1
@@ -709,8 +709,8 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev) out_error_add_adapter:free_irq (iface->irq, iface); out_error_req_irq: -out_error_no_irq:peripheral_free_list ((unsigned short *)pdev->dev.platform_data); +out_error_no_irq: out_error_pin_mux:iounmap (iface->regs_base); out_error_ioremap:
Signature · 1 line
1.7.1
Hi Libo,
Quoted 30 lines
-----Original Message-----
From: uclinux-dist-devel-bounces-ZG0+EudsQA8dtHy/[email protected] [mailto:uclinux-dist-devel- bounces-ZG0+EudsQA8dtHy/[email protected]] On Behalf Of Libo Chen
Sent: Monday, May 06, 2013 9:11 PM
To: wsa-z923LK4zBo2bacvFa/[email protected]
Cc: uclinux-dist-devel-ZG0+EudsQA8dtHy/[email protected]; Li Zefan; [email protected]; [email protected]
Subject: [uclinux-dist-devel] [PATCH 1/2] i2c: i2c-bfin-twi: don`t free peripheral
before it`s init successfuldown
out_error_no_irq. Whenplatform_get_irqfail, no need to free peripheralSigned-off-by Libo Chen <[email protected]>---
drivers/i2c/busses/i2c-bfin-twi.c| 2 +-1 files changed, 1 insertions(+), 1 deletions(-)drivers/i2c/busses/i2c-bfin-twi.c +0
-0@@ -709,8 +709,8 @@ static int i2c_bfin_twi_probe(struct platform_device *pdev)
out_error_add_adapter:free_irq(iface->irq, iface);
out_error_req_irq:drivers/i2c/busses/i2c-bfin-twi.c +1
-1-out_error_no_irq:peripheral_free_list ((unsigned short *)pdev->dev.platform_data); +out_error_no_irq:
out_error_pin_mux:
Quoted 2 lines
iounmap(iface->regs_base);
out_error_ioremap:
You should exchange line out_error_no_irq: and line out_error_pin_mux: other than. Could you send me a new patch?
Regards,
Sonic