Introduce stricter type-correctness
PATCH 1/1 Introduce stricter type-correctness
Hello,
I'm attaching a patch introducing stricter type-correctness.
Most of the changes are fixing issues with operating over signed with unsigned types. One of the changes aims to fix an insecure passing of a character* buffer through a parameter.
Regards,
From 66ba27f0dc3cdb3edf4fe4e04d2e23c348294bc5 Mon Sep 17 00:00:00 2001
From: Kamil Rytarowski <[email protected]>
Date: Sat, 11 May 2013 17:06:45 +0200
Subject: [PATCH] Introduce stricter type correctness
--- install/dracut-install.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
install/dracut-install.c +6 -6
@@ -80,9 +80,9 @@ static char *convert_abs_rel(const char *from, const char *target) _cleanup_free_ char *realtarget = NULL; _cleanup_free_ char *target_dir_p = NULL, *realpath_p = NULL;const char *realfrom = from; -int level =0 , fromlevel =0 , targetlevel =0 ; -int l, i, rl; -int dirlen; +size_t level =0 , fromlevel =0 , targetlevel =0 ; +int l; +size_t i, rl, dirlen;int ret; target_dir_p =strdup (target);
@@ -220,7 +220,7 @@ static int cp(const char *src, const char *dst)if (ret ==0 ) {struct timeval tv[2 ];if (fchown (dest_desc, sb.st_uid, sb.st_gid) !=0 ) -fchown (dest_desc,-1 , sb.st_gid); +fchown (dest_desc, (__uid_t)-1 , sb.st_gid); tv[0 ].tv_sec = sb.st_atime; tv[0 ].tv_usec =0 ; tv[1 ].tv_sec = sb.st_mtime;
@@ -305,7 +305,7 @@ static int resolve_deps(const char *src)log_debug ("ldd: '%s'" , buf);if (strstr (buf,"you do not have execution permission" )) { -log_error (buf); +log_error ("%s" , buf); ret+=1 ;break ; }
@@ -705,7 +705,7 @@ static int parse_argv(int argc, char *argv[])static int resolve_lazy (int argc,char **argv) {int i; -int destrootdirlen =strlen (destrootdir); +size_t destrootdirlen =strlen (destrootdir);int ret =0 ;char *item;for (i =0 ; i < argc; i++) {
Signature · 1 line
1.8.1.5
A message that is not in the archive (sent off-list or not yet received): [email protected]
Harald Hoyer
AppliedQuoted 8 lines · Kamil Rytarowski
Hello,
I'm attaching a patch introducing stricter type-correctness.
Most of the changes are fixing issues with operating over signed with unsigned types. One of the changes aims to fix an insecure passing of a character* buffer through a parameter.Regards,
Thanks! Applied!