Skip to contentSkip to conversation

kernel/irqdesc.c: not checking whether failure occurs for alloc_desc() in early_irq_init().

Suggestion Chen Gang 1 participant 1 message May 14, 2013

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

Hello Maintainers:

For early_irq_init(), it may be failure (can return an error code), and for alloc_desc(), also may return 'NULL' when '-ENOMEM'.

But it seems the authors are sure that early_irq_init() are always success, is it correct ? (or early_irq_init() will never be used ?)

I think, it is better to also check alloc_desc() return value in early_irq_init().

Please help check when you have time.

Thanks.

Signature · 3 lines
Chen Gang

Asianux Corporation