Skip to contentSkip to conversation

IMAGE_FEATURES check broken

PATCH Gary Thomas 3 participants 5 messages May 14, 2013

lore
Share & tools
lore
#0 lore raw

This commit breaks systems where IMAGE_FEATURES includes "package-management":

commit d63c8a1597c9bd0a838cb59ca461ac432b630a90

Author: Paul Eggleton <[email protected]>
Date:   Thu May 9 17:24:25 2013 +0100

classes/image: show an error on invalid IMAGE_FEATURES

A quick look at that class shows that package-management is being left out of the "validitems". This patch fixes it:

meta/classes/image.bbclass +1 -1
index 2b42e12..4f07708 100644
@@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
 # IMAGE_FEATURES may contain any available package group
 IMAGE_FEATURES ?= ""
 IMAGE_FEATURES[type] = "list"
-IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
+IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs package-management"
 
 # rootfs bootstrap install
 ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES", "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR

Am I missing something else, or was this just overlooked?

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#1 lore raw
Quoted 24 lines · On Tuesday 14 May 2013 04:45:02 Gary Thomas wrote:

This commit breaks systems where IMAGE_FEATURES includes "package-management":

commit d63c8a1597c9bd0a838cb59ca461ac432b630a90

Author: Paul Eggleton <[email protected]>
Date:   Thu May 9 17:24:25 2013 +0100

classes/image: show an error on invalid IMAGE_FEATURES

A quick look at that class shows that package-management is being left out of the "validitems". This patch fixes it:

meta/classes/image.bbclass +1 -1
index 2b42e12..4f07708 100644
@@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
  # IMAGE_FEATURES may contain any available package group
  IMAGE_FEATURES ?= ""
  IMAGE_FEATURES[type] = "list"
-IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
+IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs

package-management"

Quoted 5 lines
  # rootfs bootstrap install
  ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES",
"package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR

Am I missing something else, or was this just overlooked?

It was overlooked, I'm afraid - images that inherit core-image don't have this problem because the package-management PACKAGE_GROUP is defined and this gets picked up. Images that don't (which is perfectly acceptable) get the failure, and I missed testing this case.

There is a patch pending to fix this however:

http://patchwork.openembedded.org/patch/49795/

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#3 lore raw
In reply to Gary Thomas
Quoted 25 lines · Gary Thomas

This commit breaks systems where IMAGE_FEATURES includes "package-management":

commit d63c8a1597c9bd0a838cb59ca461ac432b630a90

Author: Paul Eggleton <[email protected]>
Date:   Thu May 9 17:24:25 2013 +0100

classes/image: show an error on invalid IMAGE_FEATURES

A quick look at that class shows that package-management is being left out of the "validitems". This patch fixes it:

meta/classes/image.bbclass +1 -1
index 2b42e12..4f07708 100644
@@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
  # IMAGE_FEATURES may contain any available package group
  IMAGE_FEATURES ?= ""
  IMAGE_FEATURES[type] = "list"
-IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
+IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs package-management"
 
  # rootfs bootstrap install
  ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES", "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR
Quoted 1 line

Am I missing something else, or was this just overlooked?

The same patch is already on oe-core ML where it belongs:
http://lists.linuxtogo.org/pipermail/openembedded-core/2013-May/039541.html

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw
Quoted 23 lines · Martin Jansa
Quoted 22 lines · Gary Thomas

This commit breaks systems where IMAGE_FEATURES includes "package-management":

commit d63c8a1597c9bd0a838cb59ca461ac432b630a90

Author: Paul Eggleton <[email protected]>
Date:   Thu May 9 17:24:25 2013 +0100

classes/image: show an error on invalid IMAGE_FEATURES

A quick look at that class shows that package-management is being left out of the "validitems". This patch fixes it:

meta/classes/image.bbclass +1 -1
index 2b42e12..4f07708 100644
@@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
   # IMAGE_FEATURES may contain any available package group
   IMAGE_FEATURES ?= ""
   IMAGE_FEATURES[type] = "list"
-IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
+IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs package-management"
 
Quoted 7 lines
Quoted 4 lines
meta/classes/image.bbclass +0 -0
   # rootfs bootstrap install
   ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES", "package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR

Am I missing something else, or was this just overlooked?

The same patch is already on oe-core ML where it belongs:
http://lists.linuxtogo.org/pipermail/openembedded-core/2013-May/039541.html

Thanks (I missed that one because it happened late Sunday over here)

Note: I sent my email to this list because of the comment in the commit which referred directly to a Yocto bug. ... I have a hard time figuring out where Yocto ends and OE-core begins ...

Signature · 4 lines
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------
#2 lore raw
In reply to Paul Eggleton
Quoted 39 lines · On Tuesday 14 May 2013 11:48:55 Paul Eggleton wrote:
Quoted 26 lines · On Tuesday 14 May 2013 04:45:02 Gary Thomas wrote:

This commit breaks systems where IMAGE_FEATURES includes "package-management":

commit d63c8a1597c9bd0a838cb59ca461ac432b630a90

Author: Paul Eggleton <[email protected]>
Date:   Thu May 9 17:24:25 2013 +0100

classes/image: show an error on invalid IMAGE_FEATURES

A quick look at that class shows that package-management is being left out of the "validitems". This patch fixes it:

meta/classes/image.bbclass +1 -1
index 2b42e12..4f07708 100644
@@ -19,7 +19,7 @@ INHIBIT_DEFAULT_DEPS = "1"
 
  # IMAGE_FEATURES may contain any available package group
  IMAGE_FEATURES ?= ""
  IMAGE_FEATURES[type] = "list"
 
-IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs"
+IMAGE_FEATURES[validitems] += "debug-tweaks read-only-rootfs

package-management"

Quoted 6 lines
  # rootfs bootstrap install
  ROOTFS_BOOTSTRAP_INSTALL = "${@base_contains("IMAGE_FEATURES",

"package-management", "", "${ROOTFS_PKGMANAGE_BOOTSTR

Am I missing something else, or was this just overlooked?

It was overlooked, I'm afraid - images that inherit core-image don't have this problem because the package-management PACKAGE_GROUP is defined and this gets picked up. Images that don't (which is perfectly acceptable) get the failure, and I missed testing this case.

Quoted 3 lines

There is a patch pending to fix this however:

http://patchwork.openembedded.org/patch/49795/

FYI, this patch has now been merged.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre